backups/4jcraft
2
0
Fork 0
mirror of https://github.com/4jcraft/4jcraft.git synced 2026-08-20 09:57:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: add null check to renderItemInHand

Browse source
This commit is contained in:
Sally Knight 2026-03-28 03:47:49 +03:00
parent 293590ef77
commit 40a3f90d89
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Minecraft.Client/Rendering/GameRenderer.cpp
View file

@ -671,6 +671,11 @@ void GameRenderer::setupCamera(float a, int eye) {
void GameRenderer::renderItemInHand(float a, int eye) { void GameRenderer::renderItemInHand(float a, int eye) {
if (cameraFlip > 0) return; if (cameraFlip > 0) return;
// 4jcraft: this function sometimes causes a segfault (was hell to catch
// this in gdb) because of itemInHandRenderer not being initialized so let's
// add a nullcheck
if (itemInHandRenderer == nullptr) return;
// 4J-JEV: I'm fairly confident this method would crash if the cameratarget // 4J-JEV: I'm fairly confident this method would crash if the cameratarget
// isnt a local player anyway, but oh well. // isnt a local player anyway, but oh well.
std::shared_ptr<LocalPlayer> localplayer = std::shared_ptr<LocalPlayer> localplayer =