From 40a3f90d894644256bdd715f4e371a2280f502c8 Mon Sep 17 00:00:00 2001 From: Sally Knight Date: Sat, 28 Mar 2026 03:47:49 +0300 Subject: [PATCH] fix: add null check to renderItemInHand --- Minecraft.Client/Rendering/GameRenderer.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Minecraft.Client/Rendering/GameRenderer.cpp b/Minecraft.Client/Rendering/GameRenderer.cpp index 6364b2ba1..d228b1030 100644 --- a/Minecraft.Client/Rendering/GameRenderer.cpp +++ b/Minecraft.Client/Rendering/GameRenderer.cpp @@ -671,6 +671,11 @@ void GameRenderer::setupCamera(float a, int eye) { void GameRenderer::renderItemInHand(float a, int eye) { if (cameraFlip > 0) return; + // 4jcraft: this function sometimes causes a segfault (was hell to catch + // this in gdb) because of itemInHandRenderer not being initialized so let's + // add a nullcheck + if (itemInHandRenderer == nullptr) return; + // 4J-JEV: I'm fairly confident this method would crash if the cameratarget // isnt a local player anyway, but oh well. std::shared_ptr localplayer =