null/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden synced 2026-05-01 11:44:23 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
16995 commits 154 branches 24 tags 186 MiB
Commit graph

7252 commits

Author SHA1 Message Date
Morph a7bee25d73 applets: Rename LibraryAppletVersion to ControllerAppletVersion 2020-11-08 10:04:12 -05:00
Morph 02b6d04d64 applets/controller: Pop normal data for StrapGuide and FirmwareUpdate 2020-11-08 09:35:25 -05:00
Morph 5c26e16783 applets/controller: Introduce additional checks for mode and caller 
Some games like Cave Story+ set invalid values in the ControllerPrivateArg's mode and caller fields.
Use other fields to determine the appropriate mode and caller should either or both fields be invalid.
 2020-11-08 09:35:25 -05:00
Morph eca32e90db applets/controller: Add ControllerUpdateFirmwareArg struct 2020-11-08 09:35:25 -05:00
bunnei d52953b66e Merge pull request #4903 from bunnei/remove-gpu-integrity 
video_core: dma_pusher: Remove integrity check on command lists.
 2020-11-08 02:48:22 -08:00
LC d52a8168a2 Merge pull request #4906 from lat9nq/log-cpu-accuracy 
settings: log value of CPU_Accuracy
 2020-11-07 17:01:33 -05:00
lat9nq ec0f96cdd1 settings: log value of CPU_Accuracy 2020-11-07 16:14:10 -05:00
bunnei 0b6324b3a6 video_core: dma_pusher: Remove integrity check on command lists. 
- This seems to cause softlocks in Breath of the Wild.
 2020-11-07 00:08:19 -08:00
bunnei 08056a8c3d Merge pull request #4888 from lioncash/unicorn-remove 
core: Remove usage of unicorn
 2020-11-06 22:39:05 -08:00
bunnei 479a52a8d4 hle: service: caps_u: Stub GetAlbumFileList3AaeAruid. 
- This works similiar to GetAlbumContentsFileListForApplication.
- Since we do not implement the album, this should be safe to stub for now.
- Used by Super Smash Bros. Ultimate (newer updates) in World of Light.
 2020-11-06 22:23:15 -08:00
Lioncash 4c3b3b3cd1 settings: Simplify initializer of resolution factor 
This can use a braced initializer to accomplish the same thing with less
code.
 2020-11-05 22:07:10 -05:00
bunnei 653b82fbc3 Merge pull request #4889 from lioncash/setting-global 
core/settings: Move configuring_global behind an API
 2020-11-04 17:09:19 -08:00
bunnei 97547d70f5 Merge pull request #4858 from lioncash/initializer 
General: Resolve a few missing initializer warnings
 2020-11-04 12:10:10 -08:00
Lioncash b1de33af75 core/settings: Move configuring_global behind an API 
Rather than have directly modified global state here, we can make it an
implementation detail and have an interface that changes are queried
through.
 2020-11-04 04:16:37 -05:00
Chloe c16acdfb9b Merge pull request #4869 from bunnei/improve-gpu-sync 
Improvements to GPU synchronization & various refactoring
 2020-11-04 18:36:55 +11:00
Lioncash 5c55f3b585 core: Remove usage of unicorn 
Unicorn long-since lost most of its use, due to dynarmic gaining support
for handling most instructions. At this point any further issues
encountered should be used to make dynarmic better.

This also allows us to remove our dependency on Python.
 2020-11-03 20:22:05 -05:00
bunnei 04f9045b01 Merge pull request #4878 from bunnei/unload-nrr 
hle: service: ldr: Implement UnloadNrr.
 2020-11-03 08:52:40 -08:00
bunnei f8b764dbf2 fixup! hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements. 2020-11-01 01:52:38 -07:00
bunnei 0e90fce8d4 core: Initialize GPU before services. 2020-11-01 01:52:38 -07:00
bunnei 57f20d0d70 hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements. 
- Refactor so that SubmitGPFIFO and KickoffPB use shared functionality.
- Implement add_wait and add_increment flags.
 2020-11-01 01:52:38 -07:00
bunnei d787a5bfde service: hle: nvflinger: Fix potential shutdown crash when GPU is destroyed. 2020-11-01 01:52:38 -07:00
bunnei 617372b751 hle service: nvdrv: nvhost_ctrl: Update to use SyncpointManager. 2020-11-01 01:52:37 -07:00
bunnei df095c8963 hle service: nvdrv: Update to instantiate SyncpointManager. 2020-11-01 01:52:34 -07:00
bunnei 317c2ac884 hle: service: nvdrv: Implement SyncpointManager, to manage syncpoints. 2020-11-01 01:51:54 -07:00
Levi Behunin 381586d56c Rename to align with switchbrew and remove gpu function (#4714) 
* Rename to align with switchbrew

* Rename to align with switchbrew and remove gpu function that checks if clearing should be done.
 2020-11-01 01:24:17 -07:00
bunnei 4c09a6399c hle: service: ldr: Implement UnloadNrr. 
- Used by Final Fantasy X/X-2 HD Remaster.
 2020-10-31 01:22:53 -07:00
Jan Beich c751be210e video_core: unbreak -Werror in NVDEC with Clang 
src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.cpp:41:15: error: unused variable 'OutOfMemory' [-Werror,-Wunused-const-variable]
constexpr u32 OutOfMemory{static_cast<u32>(-12)};
              ^
 2020-10-30 16:43:10 +00:00
Lioncash 3e654ff0d0 General: Resolve a few missing initializer warnings 
Resolves a few -Wmissing-initializer warnings.
 2020-10-29 19:37:07 -04:00
Morph fc09a13d34 kernel/process: Add missing <ctime> include 
Fixes compilation on MSVC
 2020-10-29 03:17:20 -04:00
bunnei b4556dd78d Merge pull request #4835 from lat9nq/rng-default-time 
kernel: Use the current time as the default RNG seed
 2020-10-28 22:51:29 -07:00
bunnei f3f1558313 Merge pull request #4846 from lioncash/service-fn 
service: Update function tables
 2020-10-28 13:47:56 -07:00
Lioncash 0368d43dff service: Update function tables 
Updates function tables according to info on SwitchBrew.
 2020-10-27 21:19:46 -04:00
bunnei 89e414a2fb Merge pull request #4729 from ameerj/nvdec-prod 
video_core: NVDEC Implementation
 2020-10-26 23:02:42 -07:00
ReinUsesLisp 1a1ca86eb5 hle/kernel: Remove unused registered_core_threads to fix data races 
This member was only used on asserts and it triggered data races.
Remove it to fix them.
 2020-10-27 01:55:39 -03:00
bunnei 5815928653 Merge pull request #4832 from bunnei/cpu-manager-microprofile-fix 
core: cpu_manager: Add missing call to MicroProfileOnThreadExit().
 2020-10-26 21:29:09 -07:00
bunnei fc2d916976 Merge pull request #4833 from bunnei/timezonemanager-explicit 
hle: services: TimeZoneContentManager: This can be made explicit.
 2020-10-26 21:28:45 -07:00
ameerj 9ef5c53e52 video_core: NVDEC Implementation 
This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library.

The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data.

To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library.

Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header.

Async GPU is not properly implemented at the moment.

Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
 2020-10-26 23:07:36 -04:00
bunnei 5760a283f6 Merge pull request #4834 from lioncash/copy-fn 
controller: Pass ControllerParameters by reference in ReconfigureControllers()
 2020-10-26 18:49:26 -07:00
lat9nq 2974d72a2a kernel: Use the current time as the default RNG seed 
Use the current time, not zero, as the default RNG seed.
 2020-10-26 21:42:11 -04:00
Lioncash c3f019b9eb controller: Pass ControllerParameters by reference in ReconfigureControllers() 
Prevents unnecessary copies and heap reallocations from occurring.
 2020-10-26 21:06:15 -04:00
bunnei 379ef37035 hle: services: TimeZoneContentManager: This can be made explicit. 2020-10-26 16:11:45 -07:00
bunnei 321fbec267 core: cpu_manager: Add missing call to MicroProfileOnThreadExit(). 
- Fixes an occasional crash when trying to launch subsequent games.
 2020-10-26 16:09:15 -07:00
Rodrigo Locatti e790827d99 Merge pull request #4828 from lioncash/lockguard 
general: Use template deduction guides for lock_guard
 2020-10-25 16:55:54 -03:00
Lioncash 59a56fa810 general: Use template deduction guides for lock_guard 
Same behavior, less code.
 2020-10-25 13:53:22 -04:00
bunnei 8246151e3a Merge pull request #4792 from bunnei/rtc-fix 
service: time: Update current time with changes to RTC setting.
 2020-10-22 20:46:54 -07:00
Lioncash c7b6027f34 core: Fix clang build pt.3 
Should finally resolve building with clang.
 2020-10-21 22:14:23 -04:00
Lioncash 2d48020ca5 core: Fix clang build pt.2 
Resolves the clang build issue in a more unintrusive way.
 2020-10-20 22:16:03 -04:00
bunnei deb3536936 Revert "core: Fix clang build" 2020-10-20 19:07:39 -07:00
Lioncash 1367e8fb75 kernel: Fix build with recent compiler flag changes 
This slipped through the cracks due to another change being merged
before the compiler flag changes.
 2020-10-20 20:23:18 -04:00
LC b02702a86a Merge pull request #4796 from lioncash/clang 
core: Fix clang build
 2020-10-20 19:19:12 -04:00
bunnei 28b9805482 Merge pull request #4390 from ogniK5377/get-applet-inf-stub 
nifm: GetAppletInfo stub
 2020-10-20 15:59:19 -07:00
David Marcec b54f39b1d4 Added remaining params 2020-10-20 16:45:01 +11:00
David Marcec 83cb5a2c74 nifm: GetAppletInfo stub 
Fixes crash for Catherine Full Body
 2020-10-20 16:42:40 +11:00
bunnei 639ff00184 Merge pull request #4788 from ReinUsesLisp/lockfree-host-thread 
kernel: Implement host thread register methods without locking
 2020-10-19 22:31:52 -07:00
bunnei b1883e0c5f Merge pull request #4785 from Morph1984/fs-hades 
filesystem: Fix CreateDirectory and DeleteFile
 2020-10-19 16:04:01 -07:00
bunnei 8e2a35be16 Merge pull request #4802 from lioncash/bcat 
core: Add boxcat sources with target_sources
 2020-10-19 12:40:49 -07:00
bunnei 65569c049e Merge pull request #4783 from bunnei/nvdrv-freespace 
hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace.
 2020-10-18 12:41:18 -07:00
Lioncash a1b5ea953f core: Add boxcat sources with target_sources 
Same behavior, minus a script variable.
 2020-10-18 08:09:06 -04:00
bunnei 91e384c640 Merge pull request #4801 from lioncash/missing-bound 
mii/manager: Make use of unused lower bound in GetRandomValue()
 2020-10-17 23:32:40 -07:00
Lioncash 18636013c9 core: Fix clang build 
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.

Fixes #4795
 2020-10-17 19:50:39 -04:00
Lioncash ab33132ccb mii/manager: Make use of unused lower bound in GetRandomValue() 
Previously, the lower bound wasn't being used and zero was being used as
the lower bound every time this function was called.

This affects the outcome of some of the randomized entries a little bit,
for example, the lower-bound for beard and mustache flags was supposed
to be 1, not 0.

Aside from these cases, the bug didn't affect anything else.
 2020-10-17 09:50:04 -04:00
bunnei bf6d4d3052 service: bcat: Check client connection before interacting with socket. 
- Fixes a crash when BCAT service is offline.
 2020-10-16 21:16:56 -07:00
bunnei 1ccbb35400 Merge pull request #4784 from bunnei/cancelbuffer 
hle: service: vi: Implement BufferQueue::CancelBuffer.
 2020-10-15 19:57:27 -07:00
bunnei de8829370d service: acc: Stub IManagerForApplication::StoreOpenContext. 
- Used by Super Mario 3D All-Stars.
 2020-10-14 20:06:33 -07:00
bunnei cab012dd01 hle: service: vi: Implement BufferQueue::CancelBuffer. 
- This is used by Super Mario 3D All-Stars.
 2020-10-13 22:11:52 -07:00
ReinUsesLisp a13623c68b kernel: Implement host thread register methods without locking 
Locks on GetCurrentHostThreadID were causing performance issues
according to Visual Studio's profiler. It was consuming twice the time
as arm_interface.Run(). The cost was not in the function itself but in
the lockinig it required.

Reimplement these functions using atomics and static storage instead of
an unordered_map. This is a side effect to avoid locking and using linked
lists for reads.

Replace unordered_map with a linear search.
 2020-10-13 18:00:25 -03:00
Lioncash 16de0a6a96 core/CMakeLists: Make some warnings errors 
Makes our error coverage a little more consistent across the board by
applying it to Linux side of things as well. This also makes it more
consistent with the warning settings in other libraries in the project.

This also updates httplib to 0.7.9, as there are several warning
cleanups made that allow us to enable several warnings as errors.
 2020-10-13 13:16:49 -04:00
Morph 585838ca42 filesystem: Fix CreateDirectory and DeleteFile 
Add a check if dir is nullptr (does not exist)

Fixes save game creation in Hades
 2020-10-13 00:57:04 -04:00
bunnei 3fb8109c94 service: time: Update current time with changes to RTC setting. 
- This can be used to advance time, e.g. for Pokemon Sword/Shield pokejobs.
 2020-10-12 18:09:15 -07:00
bunnei 77bf864c94 Merge pull request #3929 from FearlessTobi/ticket-keys 
file_sys/nsp: Make SetTicketKeys actually do something
 2020-10-12 17:58:36 -07:00
bunnei 649a262f4e hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace. 
- This is used by Super Mario 3D All-Stars.
 2020-10-12 17:39:14 -07:00
bunnei 44641fe2a9 Merge pull request #4736 from Morph1984/home-button-input-protection-stub 
hid: Stub HomeButtonInputProtection service commands
 2020-10-07 14:54:05 -07:00
bunnei a2784b68b7 Merge pull request #4710 from Morph1984/fix-integrated-updates 
submission_package: Fix updates integrated into cartridge images.
 2020-10-06 22:27:52 -07:00
bunnei d2850ea1f9 Merge pull request #4737 from Morph1984/setshimlibraryversion-stub 
capsrv: Stub 3 variants of SetShimLibraryVersion
 2020-10-06 21:39:38 -07:00
bunnei 49806f49a3 Merge pull request #4742 from german77/InputFilter 
HID: Only use inputs corresponding to controller type
 2020-10-05 21:40:09 -07:00
bunnei 1a09214fd5 Merge pull request #4734 from german77/motionfusion 
HID: Add Stub for EnableSixAxisSensorFusion
 2020-10-01 22:39:39 -07:00
german 3fa9068948 Only use inputs corresponding to controller type 2020-10-01 19:39:53 -05:00
german 450a3c0f42 Stubbed EnableSixAxisSensorFusion 2020-09-30 10:00:24 -05:00
David 99e921f52e Merge pull request #4291 from german77/ImplementControllerRumble 
input_common: First implementation of controller rumble
 2020-09-30 21:24:11 +10:00
David bf47adf1b3 Merge pull request #4726 from lioncash/applet 
frontend/controller: Eliminate dependency on the global system instance
 2020-09-30 21:22:45 +10:00
Morph ba883c8c84 caps_c: Stub SetShimLibraryVersion 
- Used by caps_su SetShimLibraryVersion
 2020-09-30 07:19:46 -04:00
Morph e1d561f647 caps_u: Stub SetShimLibraryVersion 
- Used in Super Smash Bros. Ultimate
 2020-09-30 07:19:46 -04:00
Morph a03d4d663c caps_su: Properly stub SetShimLibraryVersion 2020-09-30 07:19:46 -04:00
Morph f3e928bb6a hid: Stub HomeButtonInputProtection service commands 
- Used in 1-2 Switch. Given that we do not emulate the functionality of the home button yet, we can stub this for now.
 2020-09-30 06:38:24 -04:00
bunnei 3266cc0a32 Merge pull request #4705 from german77/SplitMotionPoller 
HID: Use different timing for motion
 2020-09-30 01:04:22 -07:00
bunnei 7d55163e1d Merge pull request #1703 from DarkLordZach/nvdec-ioctl 
nvdrv: Stub nvdec/vic ioctls to bypass nvdec movies
 2020-09-29 15:00:48 -07:00
german 782aab6cf2 First implementation of controller rumble 2020-09-29 10:38:25 -04:00
Lioncash dba567cfbf core: Mark GetInstance() as deprecated 
This way it's obvious that this function shouldn't be used in any future
code.
 2020-09-25 19:23:23 -04:00
Lioncash 9861290969 frontend/controller: Eliminate dependency on the global system instance 2020-09-25 19:23:20 -04:00
LC d2d0909b84 Merge pull request #4717 from lioncash/debug 
service: Restore "unused" function
 2020-09-25 00:07:19 -04:00
Lioncash 711c5c7bdf service: Restore "unused" function 
Turns out this function is actually used, but within a trace log.
 2020-09-25 00:06:40 -04:00
Morph 58f0798f1f submission_package: Fix updates integrated into cartridge images. 2020-09-24 17:23:14 -04:00
bunnei 221e4c3e41 Merge pull request #4678 from Morph1984/LoadOpenContext-partial-impl 
acc: Partially implement LoadOpenContext
 2020-09-24 11:21:25 -07:00
german c3fb504201 Use different timing for motion 2020-09-23 19:09:33 -05:00
Lioncash 3abd28c35a memory: Resolve a -Wdocumentation warning 
memory doesn't exist as a parameter any more.
 2020-09-23 13:39:27 -04:00
Lioncash e457001dce General: Make use of std::nullopt where applicable 
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.

This also makes it consistent how we return empty optionals.
 2020-09-22 17:32:33 -04:00
Lioncash 485eec243d ips_layer: Eliminate a redundant copy in Parse() 
Prevents unnecessary copying of the line being parsed.
 2020-09-22 16:38:45 -04:00
bunnei 292693b696 Merge pull request #4675 from Morph1984/fix-boot-multicontent 
submission_package: Account for multi-content NSPs
 2020-09-21 16:36:46 -07:00
Morph 152b529a00 acc: Stub LoadOpenContext 
This is used in multiple games such as:
- Clubhouse Games: 51 Worldwide Classics
- Grandia HD Collection
- XCOM 2 Collection
- Baldur's Gate 1/2
- Dr Kawashima's Brain Training
- Super Mario 3D All-Stars
 2020-09-21 01:01:02 -04:00
bunnei 24b421b14c Merge pull request #4683 from Morph1984/NpadHandheldActivationMode-impl 
hid: Implement Get/SetNpadHandheldActivationMode
 2020-09-20 12:39:20 -07:00
bunnei 1a3f019bad Merge pull request #4643 from FearlessTobi/decrease-pad-update-interval 
Test: Decrease pad_update_ns
 2020-09-19 00:39:50 -07:00
Morph 505ce79b9d hid: Implement Get/SetNpadHandheldActivationMode 
- Used in Clubhouse Games: 51 Worldwide Classics
 2020-09-18 10:10:30 -04:00
Morph 5435e0ee39 am: Stub GetPreviousProgramIndex 
- Used in Super Mario 3D All-Stars
 2020-09-17 22:03:02 -04:00
Morph 0b72422a10 submission_package: Account for multi-content NSPs 
Previously we assumed a submission package can only contain one Program NCA with a single TitleID.
However, Super Mario 3D All-Stars contains four Program NCAs, each with their unique TitleIDs.
This accounts for the existence of multi-content games such as this one.
- Fixes booting Super Mario 3D All-Stars from the games list.
 2020-09-17 20:44:51 -04:00
Rodrigo Locatti 2ca7e7160a Merge pull request #4670 from lioncash/initializer 
arm_dynarmic_cp15: Initialize member variables
 2020-09-17 21:20:53 +00:00
Rodrigo Locatti c1fdda9ff9 Merge pull request #4665 from lioncash/sm-kernel 
service/sm: Eliminate dependency on the global system instance
 2020-09-17 21:20:39 +00:00
Rodrigo Locatti 3a962913c7 Merge pull request #4666 from lioncash/unused-func 
service: Remove unused funcation
 2020-09-17 21:19:48 +00:00
Rodrigo Locatti 70b922675e Merge pull request #4671 from lioncash/nfp-copy 
command_generator/nfp: Eliminate unnecessary copies
 2020-09-17 21:19:12 +00:00
bunnei 9a2553c952 Merge pull request #4594 from german77/MotionHID 
hid/configuration: Implement motion controls to HID
 2020-09-17 12:39:01 -07:00
Lioncash 45a608088c nfp: Eliminate two unnecessary copies 
GetAmiiboBuffer() returns by const reference, so we can use a reference
instead of taking the returned buffer by value.
 2020-09-17 13:35:55 -04:00
Lioncash 4d0fa3544f arm_dynarmic_cp15: Initialize member variables 
Ensures that the member variables are always initialized to a
deterministic value on creation.
 2020-09-17 13:03:49 -04:00
Lioncash 43a09c9bfc control_metadata: Resolve typo in Portuguese language name 
This isn't used anywhere, so this is a trivial fix.
 2020-09-17 11:45:30 -04:00
Lioncash 341c612474 service: Remove unused funcation 
This is now completely unused, so it can be removed.
 2020-09-17 11:03:26 -04:00
Lioncash e4747039da service/sm: Slightly more efficient string name validation 
We can check the end of the string first for null-termination, rather
than the beginning of the string.
 2020-09-17 10:54:12 -04:00
Lioncash 95e8dff0d7 service/sm: Eliminate dependency on the global system instance 2020-09-17 10:43:54 -04:00
Lioncash 7824da5961 file_sys/romfs_factory: Eliminate usage of the global system accessor 2020-09-16 19:15:19 -04:00
Lioncash e45b727db5 file_sys/bis_factory: Eliminate usage of the global system accessor 2020-09-16 18:16:04 -04:00
Lioncash 279b79c880 loader/nso: Remove unnecessary [[maybe_unused]] 2020-09-16 18:09:01 -04:00
Lioncash bcb796ee92 core/loader: Remove dependencies on the global system instance 
Now all that remains is:

18 instances in file_sys code
14 instances in GDB stub code (this can be tossed wholesale)
4 instances in HLE code
2 instances in settings code.
 2020-09-16 08:46:59 -04:00
Rodrigo Locatti d05ab5ec3c Merge pull request #4658 from lioncash/copy3 
nca_patch: Reduce stack usage size within SearchBucketEntry()
 2020-09-16 00:25:11 +00:00
Lioncash 80e57658ac nca_patch: Significantly reduce the stack usage size within SearchBucketEntry() 
Previously this function was using ~16KB of stack (16528 bytes), which
was caused by the function arguments being taken by value rather than by
reference.

We can make this significantly lighter on the stack by taking them by
reference.
 2020-09-15 09:10:58 -04:00
Lioncash a92c6ddd22 nca_patch: Make SearchBucketEntry() internally linked 
This is only used internally and doesn't depend on any class state, so
we can make it fully internal.
 2020-09-15 09:06:46 -04:00
Lioncash 15fa8f52fc cheat_engine: Convert ExtractName into a non-template function 
We don't need to create two separate instantiations of the same code, we
can simply make the character template argument a regular function
parameter.
 2020-09-15 03:24:44 -04:00
Lioncash 6711031e7d cheat_engine: Remove unnecessary system argument to CheatParser's Parse function 
This isn't used within the function at all in any implementations, so we
can remove it entirely.
 2020-09-15 03:20:40 -04:00
Lioncash 5c77fffc80 patch_manager: Resolve implicit truncations in FormatTitleVersion() 
We make it explicit that we're truncating arithmetic here to resolve
compiler warnings (even if the sizes weren't u32/u64 arithmetic
generally promotes to int :<)
 2020-09-14 19:19:59 -04:00
Lioncash 7abb47303e patch_manager: Make use of type aliases 
We can use these to avoid typing the same type redundantly. This way, if
these ever change, only a single location needs to be modified.
 2020-09-14 19:17:50 -04:00
Lioncash e8092e4099 patch_manager: Make a few functions internally linked 
These functions are only used within this translation unit, so we can
make them internally linked.
 2020-09-14 19:04:51 -04:00
Lioncash 767fcd8a81 crypto/key_manager: Remove dependency on the global system accessor 
We can supply the content provider as an argument instead of hardcoding
a global accessor in the implementation.
 2020-09-14 16:49:59 -04:00
Lioncash f700c48cc0 kernel: Remove all dependencies on the global system instance 
With this, the kernel finally doesn't depend directly on the global
system instance anymore.
 2020-09-14 14:03:13 -04:00
bunnei 35a0ff1d6f Merge pull request #4636 from lioncash/kernel-hle 
service: Remove two usages of the global system accessor
 2020-09-14 09:17:10 -07:00
bunnei 7b536a07f2 Merge pull request #4323 from ReinUsesLisp/no-spin 
kernel/scheduler: Use std::mutex instead of spin lock
 2020-09-11 23:23:53 -07:00
bunnei cbe7cdf7ca Merge pull request #4634 from lioncash/blocking 
bsd: Resolve a few warnings
 2020-09-11 15:17:34 -07:00
bunnei b205c01a95 Merge pull request #4310 from ogniK5377/apollo-1-prod 
audio_core: Apollo Part 1, AudioRenderer refactor
 2020-09-11 10:57:27 -04:00
bunnei c2ad9f6fc9 Merge pull request #4597 from Morph1984/mjolnir-p2 
Project Mjölnir: Part 2 - Controller Applet
 2020-09-10 19:28:23 -04:00
FearlessTobi b3d2fd39d3 Test: Decrease pad_update_ns 
There have been reports of quite heavy input lag in the past.
Compared to Citra for example, our pad_update_ns value is very high.
So let's decrease it and see if it helps with this problem.
 2020-09-10 16:38:53 +02:00
Rodrigo Locatti 8fcafa37a8 Merge pull request #4633 from ReinUsesLisp/gpu-init 
video_core: Remove all Core::System references in renderer
 2020-09-10 02:28:54 +00:00
Lioncash 054735e3fe service: Remove two usages of the global system accessor 
Removes more instances of reliance on global state.
 2020-09-07 03:18:45 -04:00
Lioncash b1c64e8c4f bsd: Resolve unused value within SendToImpl 
Previously the address provided to SendToImpl would never be propagated
to SendTo(). This fixes that.
 2020-09-07 01:06:30 -04:00
Lioncash 0bf0d9d3c3 bsd: Resolve sign comparison warnings 2020-09-07 01:06:27 -04:00
Lioncash 3467cfb357 sockets_translate: Make use of designated initializers 
Same behavior, less typing.
 2020-09-07 00:53:10 -04:00
Lioncash 2c196e7c6e blocking_worker: Make use of templated lambda 
We can simplify this a little by explicitly specifying the typename for
the lambda function.
 2020-09-07 00:47:46 -04:00
Lioncash 0d180e23f0 blocking_worker: Resolve -Wdocumentation warning 2020-09-07 00:45:53 -04:00
ReinUsesLisp 8efb2c5537 video_core: Remove all Core::System references in renderer 
Now that the GPU is initialized when video backends are initialized,
it's no longer needed to query components once the game is running: it
can be done when yuzu is booting.

This allows us to pass components between constructors and in the
process remove all Core::System references in the video backend.
 2020-09-06 05:28:48 -03:00
bunnei a6945afa54 Merge pull request #4397 from ReinUsesLisp/bsd 
services: Implement most of bsd:s and GetCurrentIpAddress from nifm
 2020-09-05 22:40:59 -04:00
Morph 55db7a4e0a configure_input: Hook up the motion button and checkbox 
This allows toggling motion on or off, and allows access to the motion configuration.
Also changes the [waiting] text for motion buttons to Shake! as this is how motion is connected to a player.
 2020-09-05 09:46:34 -04:00
german 82eb4be33b Add cemu hook changes related to PR #4609 2020-09-04 21:48:13 -05:00
german 17b48f8d42 Remove RealMotionDevice 2020-09-04 21:48:13 -05:00
Morph a04a7174c7 controllers/npad: Simplify motion entry assignment 
Simplifies the motion assignment in the Dual Joycon entry and assigns index 1 of the motion entry (Motion 2) for the right joycon.
 2020-09-04 21:48:13 -05:00
german 876e6fc255 Include HID and configuration changes related to motion 2020-09-04 21:48:03 -05:00
Morph ce1c6f2eea hid: Implement MergeSingleJoyasDualJoy 
- Used in multiple games such as Super Mario Odyssey.
 2020-09-04 15:38:33 -04:00
Morph 0ce52a8070 applets/controller: Resolve several compiler warnings 
Resolves -Wsign-compare and -Wunused-variable
 2020-09-04 12:23:26 -04:00
Morph 5c853d4dc7 Address feedback 2020-09-04 12:23:25 -04:00
Morph b9cde4fa6d applets/controller: Set min_players to have a minimum value of 1. 
- Some games like Shipped have a minimum requirement of 0 connected players and is undesired behavior. We must require a minimum of 1 player connected regardless of what games may ask.
 2020-09-04 12:23:25 -04:00
Morph 212b4a584d applets/controller: Modify heuristic to account for certain games 
Now left and right joycons have the same priority (meaning both needs to be supported by the game).

Explanation of the new heuristic:
Assign left joycons to even player indices and right joycons to odd player indices.
We do this since Captain Toad Treasure Tracker expects a left joycon for Player 1 and a right Joycon for Player 2 in 2 Player Assist mode.
 2020-09-04 12:23:25 -04:00
Morph 3742ae763c applets/controller: Implement fallback applet for the SDL frontend 
Implement the fallback applet for the SDL frontend, connecting only the minimum amount of players required.
 2020-09-04 12:23:25 -04:00
Morph 00df69232a applets/controller: Implement "Explain Text" 
"Explain Text" is additional text that is shown for each player in the controller applet.
 2020-09-04 12:23:25 -04:00
Morph 4c621b9b09 Project Mjölnir: Part 2 - Controller Applet 
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-09-04 12:23:25 -04:00
bunnei 2af4f1ac07 Merge pull request #4590 from ReinUsesLisp/tsan-sched 
hle/scheduler: Fix data race in is_context_switch_pending
 2020-09-03 14:39:57 -04:00
ReinUsesLisp 5bccefe24c file_sys/patch_manager: Add missing include 
Fixes build issues
 2020-09-03 04:51:49 -03:00
bunnei faea0ddc85 Merge pull request #4568 from lioncash/fsp 
fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem()
 2020-09-02 23:07:03 -04:00
bunnei 40d236b401 Merge pull request #4564 from lioncash/file-include 
file_sys: Replace inclusions with forward declarations where applicable
 2020-09-02 23:06:38 -04:00
bunnei 99ae6cfc68 Merge pull request #4382 from FearlessTobi/port-udp-config 
yuzu: Add motion and touch configuration from Citra
 2020-09-01 13:56:37 -04:00
bunnei 15cf2bfbcb Merge pull request #4589 from ReinUsesLisp/tsan-host 
hle/kernel: Fix data race in GetCurrentHostThreadID
 2020-08-31 21:20:49 -04:00
LC ce88bb3f00 Merge pull request #4461 from comex/thread-names 
Fix thread naming on Linux, which limits names to 15 bytes.
 2020-08-31 15:31:48 -04:00
FearlessTobi ee199ead59 Address second batch of reviews 2020-08-30 00:43:25 +02:00
FearlessTobi 2903f0f7ce yuzu: Add motion and touch configuration 2020-08-29 18:56:34 +02:00
bunnei 9fd13dd80a Merge pull request #4586 from yuzu-emu/tsan-cpu-interrupt 
cpu_interrupt_handler: Make is_interrupted an atomic
 2020-08-28 09:21:47 -04:00
Morph 9b0f5da0c6 controllers/npad: Fix inconsistencies with controller connection statuses 2020-08-26 02:32:32 -04:00
Morph 4d6a8f3e8f controllers/npad: Fix LibNX controller connection statuses 
This allows homebrew applications to be able to properly detect connected controllers.
 2020-08-26 02:32:32 -04:00
Morph 9fc2eb2ee0 controllers/npad: Fix LedPattern for P1-4 2020-08-26 02:32:32 -04:00
Morph 34a209d15c Project Mjölnir: Part 1 
Co-authored-by: James Rowe <jroweboy@gmail.com>
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-08-26 02:32:32 -04:00
ReinUsesLisp 8f050dd1d9 hle/scheduler: Fix data race in is_context_switch_pending 
As reported by tsan, SelectThreads could write to
is_context_switch_pending holding a mutex while SwitchToCurrent reads it
without holding any.

It is assumed that the author didn't want an atomic here, so the code is
reordered so that whenever is_context_switch_pending is read inside
SwitchToContext, the mutex is locked.
 2020-08-26 02:56:05 +00:00
ReinUsesLisp 6bf10ea8cf hle/kernel: Fix data race in GetCurrentHostThreadID 
As reported by tsan, host_thread_ids could be read while
any of the RegisterHostThread variants were called.

To fix this, lock the register mutex when yuzu is running in multicore
mode and GetCurrentHostThreadID is called.
 2020-08-26 02:52:50 +00:00
ReinUsesLisp ad0306e520 cpu_interrupt_handler: Misc style changes 2020-08-26 02:43:26 +00:00
ReinUsesLisp 7eb6cc742a cpu_interrupt_handler: Make is_interrupted an atomic 
Fixes a race condition detected from tsan
 2020-08-26 02:43:15 +00:00
bunnei e0b4361aaf Merge pull request #4563 from lioncash/rcache 
registered_cache: Make use of designated initializers
 2020-08-25 10:07:33 -04:00
M&M c6f9cad218 logging/settings: Increase maximum log size to 100 MB and add extended logging option 
The extended logging option is automatically disabled on boot but can be enabled afterwards, allowing the log file to go up to 1 GB during that session.
This commit also fixes a few errors that are present in the general debug menu.
 2020-08-24 21:39:56 -07:00
bunnei 420c6d11be Merge pull request #4562 from lioncash/loop 
cpu_manager: Make use of ranged for where applicable
 2020-08-24 17:58:41 -04:00
bunnei 18cce1dc8a Merge pull request #4561 from lioncash/key-constexpr 
key_manager: Make data arrays constexpr
 2020-08-23 20:41:05 -04:00
bunnei 88cf35db7d Merge pull request #4549 from lioncash/files 
vfs_real: Avoid redundant map lookups
 2020-08-23 19:08:36 -04:00
Lioncash 6eeeebeb9d fsp_srv: Resolve -Wunused-but-set-variable warning 
We can just log out the parameters in the meantime.
 2020-08-23 17:16:32 -04:00
Lioncash da15e9f8a7 file_sys: Replace inclusions with forward declarations where applicable 
Same behavior, minus unnecessary inclusions where not necessary.
 2020-08-23 17:02:55 -04:00
Lioncash c26b29c2c6 fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem() 
Initialize id to a deterministic value and also mark the unreachable
cases in the switch with UNREACHABLE().
 2020-08-23 16:37:57 -04:00
Lioncash 942badd1e7 registered_cache: Make use of ends_with for string suffix checking 
Simplifies code.
 2020-08-23 11:25:45 -04:00
Lioncash a185b6cf21 registered_cache: Make use of designated initializers 
Removes the need for comments to indicate the fields being assigned.
 2020-08-23 10:26:20 -04:00
bunnei 5a675f4633 Merge pull request #4560 from lioncash/convert 
core_timing: Resolve sign conversion warning
 2020-08-23 02:11:14 -04:00
Lioncash ebe30ea145 key_manager: Make data arrays constexpr 
We can convert these maps into constexpr arrays to eliminate some
runtime static constructors.
 2020-08-22 22:47:24 -04:00
Lioncash beca7a0429 cpu_manager: Make use of ranged for where applicable 
We can simplify a few loops by making use of ranged for.
 2020-08-22 22:43:19 -04:00
Lioncash 96214f8600 core_timing: Remove unused header 2020-08-22 22:12:37 -04:00
Lioncash aae74a55da core_timing: Move clock initializer into constructor initializer list 
Same behavior, minus unnecessary zeroing out of the pointer.
 2020-08-22 20:26:48 -04:00
Lioncash 41c74f4f0c core_timing: Resolve sign conversion warning 
This constant is only ever assigned to downcount, which is a s64, not a
u64.
 2020-08-22 20:26:45 -04:00
bunnei 915aeb2550 Merge pull request #4541 from MerryMage/yolo 
dynarmic: Add unsafe optimizations
 2020-08-21 23:06:21 -04:00
Lioncash ecb9029c6a common/telemetry: Migrate namespace into the Common namespace 
Migrates the Telemetry namespace into the Common namespace to make the
code consistent with the rest of our common code.
 2020-08-18 15:08:32 -04:00
Lioncash d9fc3abc1f vfs_real: Resolve sign conversion warnings 2020-08-18 14:58:33 -04:00
Lioncash 182739ce1b vfs_real: Avoid redundant map lookups 
Avoids some trivially avoidable map lookups by keeping the result of
find operations around and querying them.
 2020-08-18 14:58:29 -04:00
bunnei ab2ebb773e Merge pull request #4535 from lioncash/fileutil 
common/fileutil: Convert namespace to Common::FS
 2020-08-17 22:35:30 -04:00
bunnei 337c9de4bd Merge pull request #4494 from lioncash/transcode 
aes_util: Make use of non-template variant of Transcode
 2020-08-17 03:50:35 -04:00
MerryMage 1057908c3a dynarmic: Add unsafe optimizations 2020-08-16 14:15:39 +01:00
Lioncash a87209e09d common/fileutil: Convert namespace to Common::FS 
Migrates a remaining common file over to the Common namespace, making it
consistent with the rest of common files.

This also allows for high-traffic FS related code to alias the
filesystem function namespace as

namespace FS = Common::FS;

for more concise typing.
 2020-08-16 06:52:40 -04:00
bunnei 81eae1562a Merge pull request #4526 from lioncash/core-semi 
core: Resolve several -Wextra-semi warnings
 2020-08-15 02:14:11 -04:00
bunnei 2f477fe630 Merge pull request #4527 from lioncash/pessimizing2 
software_keyboard: Resolve a pessimizing move warning
 2020-08-15 02:13:44 -04:00
bunnei a191355688 Merge pull request #4492 from lioncash/linkage 
system_control: Make functions internally linked where applicable
 2020-08-15 02:11:49 -04:00
bunnei 88fdc4c659 Merge pull request #4463 from lioncash/lockdiscard 
kernel/scheduler: Mark SchedulerLock constructor as nodiscard
 2020-08-15 01:31:23 -04:00
Lioncash b86bba9f7e time_zone_content_manager: Collapse auto and default case 
Prevents a useless self-assignment from occurring.
 2020-08-14 10:58:58 -04:00
Lioncash 910dff8816 software_keyboard: Resolve a pessimizing move warning 
A std::vector created in place like this is already an rvalue and
doesn't need to be moved.
 2020-08-14 09:14:54 -04:00
Lioncash 0c78ed16df core: Resolve several -Wextra-semi warnings 
We can amend one of the cascade macros to require semicolons in order to
compile. In other cases, we can just remove the superfluous semicolons.
 2020-08-14 09:09:20 -04:00
Lioncash f44ad07f2f emu_window: Mark Scoped constructor and Acquire() as nodiscard 
Ensures that callers make use of the constructor, preventing bugs from
silently occurring.
 2020-08-14 04:43:44 -04:00
Lioncash 8d7e58562f kernel/scheduler: Mark SchedulerLock constructor as nodiscard 
Allows the compiler to warn about cases where the constructor is used
but then immediately discarded, which is a potential cause of
locking/unlocking bugs.
 2020-08-14 04:43:44 -04:00
Rodrigo Locatti 2740be0f9d Merge pull request #4495 from lioncash/conv 
cheat_engine: Resolve implicit bool->u64 conversion
 2020-08-14 03:10:17 -03:00
LC 77a3efb1c5 Merge pull request #4511 from lioncash/build2 
General: Tidy up clang-format warnings part 2
 2020-08-13 15:13:21 -04:00
Lioncash 78ddcbe3ba General: Tidy up clang-format warnings part 2 2020-08-13 14:19:08 -04:00
bunnei d7958019b6 Merge pull request #4497 from lioncash/freezer-alg 
freezer: Make use of std::erase_if
 2020-08-11 23:07:17 -04:00
bunnei 10c4fff79c Merge pull request #4496 from lioncash/ce-desig 
cheat_engine: Make use of designated initializers
 2020-08-10 13:53:43 -04:00
bunnei 16993fc92b Merge pull request #4491 from lioncash/unused-vars 
kernel: Remove unused variables
 2020-08-10 12:04:30 -04:00
bunnei 51bfe3397f Merge pull request #4488 from lioncash/file 
vfs_vector: Make creation of array vfs files less verbose
 2020-08-09 17:19:34 -04:00
bunnei 7483e76613 Merge pull request #4457 from ogniK5377/SetScreenShotPermission 
am: Unstub SetScreenShotPermission
 2020-08-07 09:34:20 -04:00
Lioncash 80d04c0daa common/concepts: Rename IsBaseOf to DerivedFrom 
This makes it more inline with its currently unavailable standardized
analogue std::derived_from.

While we're at it, we can also make the template match the requirements
of the standardized variant as well.
 2020-08-07 08:09:57 -04:00
bunnei 27636c8a7a Merge pull request #4483 from lioncash/constexpr-hex 
partition_data_manager: Make data arrays constexpr
 2020-08-06 23:14:14 -04:00
bunnei 556422d711 Merge pull request #4490 from lioncash/arbiter 
address_arbiter/scheduler: Resolve sign conversion warnings
 2020-08-06 22:28:11 -04:00
Lioncash 21229948aa freezer: Move entry finding to its own function 
Cleans up the callsites in other functions.
 2020-08-06 03:11:21 -04:00
Lioncash 4a54d99f0d freezer: Take address values by value 
VAddr will always be 64-bit, so there's no need to take a trivial
primitive alias by reference.
 2020-08-06 03:04:54 -04:00
Lioncash b67eb6746b freezer: Make use of std::erase_if 
With C++20 we can simplify the erasing idiom.
 2020-08-06 03:03:05 -04:00
Lioncash 304da7bfc8 cheat_engine: Resolve implicit bool->u64 conversion 
We can just return zero here.
 2020-08-06 02:55:47 -04:00
Lioncash 6c2392941b cheat_engine: Make use of designated initializers 
Same behavior, but makes the member being assigned obvious.
 2020-08-06 02:48:13 -04:00
Lioncash accf36193b partition_data_manager: Update master key hashes 
Fills in some hashes that were previously unhandled.
 2020-08-06 02:42:01 -04:00
Lioncash b0c3f66dc7 partition_data_manager: Make data arrays constexpr 
Previously the constructor for all of these would run at program
startup, consuming time before the application can enter main().

This is also particularly dangerous, given the logging system wouldn't
have been initialized properly yet, yet the program would use the logs
to signify an error.

To rectify this, we can replace the literals with constexpr functions
that perform the conversion at compile-time, completely eliminating the
runtime cost of initializing these arrays.
 2020-08-06 02:41:58 -04:00
Lioncash c4f9130264 partition_data_manager: Eliminate magic value 
We can use sizeof to make it obvious at the call site where the value is
coming from.
 2020-08-06 02:34:10 -04:00
Lioncash 8b8cb4da9f aes_util: Make use of non-template variant of Transcode 
Same behavior, less template instantiations.
 2020-08-06 02:31:19 -04:00
comex 23523e4c0a Fix thread naming on Linux, which limits names to 15 bytes. 
- In `SetCurrentThreadName`, when on Linux, truncate to 15 bytes, as (at
  least on glibc) `pthread_set_name_np` will otherwise return `ERANGE` and
  do nothing.
- Also, add logging in case `pthread_set_name_np` returns an error
  anyway.  This is Linux-specific, as the Apple and BSD versions of
  `pthread_set_name_np return `void`.
- Change the name for CPU threads in multi-core mode from
  "yuzu:CoreCPUThread_N" (19 bytes) to "yuzu:CPUCore_N" (14 bytes) so it
  fits into the Linux limit.  Some other thread names are also cut off,
  but I didn't bother addressing them as you can guess them from the
  truncated versions.  For a CPU thread, truncation means you can't see
  which core it is!
 2020-08-05 20:34:49 -07:00
bunnei f0be76a50a Merge pull request #4489 from lioncash/typesafe 
ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
 2020-08-05 23:20:23 -04:00
bunnei 7f6689983f Merge pull request #4484 from lioncash/aesutil 
aes_util: Allow SetIV() to be non-allocating
 2020-08-05 22:35:41 -04:00
bunnei c6ea0b876c Merge pull request #4475 from lioncash/bqueue 
buffer_queue: Make use of designated initializers/std::nullopt where applicable
 2020-08-05 16:56:46 -04:00
Lioncash 9e72b1df7d system_control: Make functions internally linked where applicable 
These functions are only ever used internally as implementation details
for GenerateRandomRange(), so these can be given internal linkage.
 2020-08-05 15:34:27 -04:00
Lioncash 3ea31a9922 kernel: Remove unused variables 
Resolves a few compiler warnings.
 2020-08-05 15:19:48 -04:00
Lioncash 353cd8dc24 scheduler: Resolve sign conversion warning 2020-08-05 15:12:29 -04:00
Lioncash 792c1666f7 address_arbiter: Resolve sign conversion warning 
Makes our type conversion explicit.
 2020-08-05 15:07:19 -04:00
bunnei 88efb0c4ce Merge pull request #4444 from lioncash/volatile 
common/atomic_ops: Don't cast away volatile from pointers
 2020-08-05 14:22:36 -04:00
Lioncash 43ef4a7305 ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw() 
It's undefined behavior to use non-trivially copyable objects with
std::memcpy, so we can add asserts to catch usages of these at
compile-time.
 2020-08-05 14:08:28 -04:00
Lioncash 42c79b8507 vfs_vector: Make creation of array vfs files less verbose 
We can add a helper function to make creation of these files nicer.
While we're at it, we can eliminate an unnecessary std::array copy in
the constructor. This makes the overhead on some of these functions way
less intensive, given some arrays were quite large.

e.g. The timezone location names are 9633 bytes in size.
 2020-08-05 12:37:00 -04:00
bunnei ccd9337ec7 Merge pull request #4466 from ogniK5377/loader-type-safe 
loader: Make IdentifyFile typesafe
 2020-08-05 12:34:25 -04:00
bunnei 460d686bbd Merge pull request #4476 from lioncash/tz 
time_zone_binary: Make use of designated initializers
 2020-08-04 18:56:28 -04:00
bunnei 4e96278c63 Merge pull request #4401 from ogniK5377/GetIndirectLayerImageRequiredMemoryInfo 
vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo
 2020-08-04 18:45:11 -04:00
bunnei 09bd480eab Merge pull request #4430 from bunnei/new-gpu-vmm 
hle: nvdrv: Rewrite of GPU memory management.
 2020-08-04 18:44:26 -04:00
bunnei e909b4731b Merge pull request #4472 from lioncash/const-get 
perf_stats: Mark GetMeanFrametime() as const
 2020-08-04 07:00:23 -07:00
David 614476af30 Merge pull request #4470 from lioncash/qualifier 
patch_manager: Resolve -Wignored-qualifier warnings
 2020-08-04 14:09:48 +10:00
David 82f4fb21e8 Merge pull request #4481 from lioncash/cpp-dep 
yuzu: Resolve C++20 deprecation warnings related to lambda captures
 2020-08-04 14:06:07 +10:00
David a7fa221005 Merge pull request #4474 from lioncash/hle-profile 
profile_manager: Make use of designated initializers
 2020-08-04 13:51:15 +10:00
bunnei a4ff924420 Merge pull request #4473 from lioncash/cheat-desig 
dmnt_cheat_vm: Make use of designated initializers
 2020-08-03 18:07:17 -07:00
bunnei cf35405a71 Merge pull request #4456 from Morph1984/stub-really-long-fs-func 
fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute
 2020-08-03 18:06:48 -07:00
Lioncash c28e7f51f3 aes_util: Allow SetIV to be non-allocating 
In a few places, the data to be set as the IV is already within an array.
We shouldn't require this data to be heap-allocated if it doesn't need
to be. This allows certain callers to reduce heap churn.
 2020-08-03 14:29:58 -04:00
bunnei cdd9f577b4 Merge pull request #4482 from lioncash/ldr-sign 
service/ldr: Resolve sign mismatch warnings
 2020-08-03 11:27:13 -07:00
bunnei 70a59da903 Merge pull request #4468 from lioncash/regcache 
registered_cache: Resolve -Wmaybe_uninitialized warnings
 2020-08-03 11:26:45 -07:00
bunnei 9a685a6c85 Merge pull request #4471 from ogniK5377/sm-getservice-concept 
sm: Make use of IsBaseOf for GetService
 2020-08-03 11:11:22 -07:00
Lioncash bb711ced9d perf_stats: Make use of designated initializers 
Same behavior, but allows us to avoid a now-unnecessary zero
initialization.
 2020-08-03 12:33:40 -04:00
Lioncash 2a2bc9c147 perf_stats: Mark GetMeanFrametime() as const 
The general pattern is to mark mutexes as mutable when it comes to
matters of constness, given the mutex acts as a transient member of a
data structure.
 2020-08-03 12:33:35 -04:00
Lioncash 08e30e0240 yuzu: Resolve C++20 deprecation warnings related to lambda captures 
C++20 deprecates capturing the this pointer via the '=' capture.
Instead, we replace it or extend the capture specification.
 2020-08-03 11:54:04 -04:00
Lioncash 78ff298d6d service/ldr: Resolve sign mismatch warnings 
We were performing an int < size_t comparison. We can just correct the
type of the induction variable.
 2020-08-03 11:48:16 -04:00
bunnei be05759325 Merge pull request #4467 from lioncash/mode 
file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode
 2020-08-03 08:07:56 -07:00
Lioncash 607a02edda time_zone_binary: Make use of designated initializers 2020-08-03 10:42:38 -04:00
Lioncash a1aab876e6 buffer_queue: Make use of std::nullopt 
Allows compilers to eliminate unnecessary zeroing out of the optional's
buffer.
 2020-08-03 09:31:51 -04:00
Lioncash 9b1ab372a7 buffer_queue: Make use of designated initializers 2020-08-03 09:31:51 -04:00
Lioncash 5430961f0d profile_manager: Make use of std::nullopt 
Allows some implementations to completely avoid unnecessarily zeroing
out the internal buffer.
 2020-08-03 09:03:42 -04:00
Lioncash 1f909d614c profile_manager: Make use of designated initializers 
More compact code.
 2020-08-03 09:01:31 -04:00
Lioncash 743ed2b727 dmnt_cheat_vm: Make use of designated initializers 
Allows for more compact code.
 2020-08-03 08:50:51 -04:00
Lioncash 2fa750dd6b file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode 
Same behavior, minus a hand-rolled operator.
 2020-08-03 07:52:36 -04:00
David Marcec 4d0ba04c73 sm: Make use of IsBaseOf for GetService 2020-08-03 21:46:14 +10:00
Lioncash 39ac833461 patch_manager: Resolve -Wignored-qualifier warnings 
Top level const will always be ignored in this case, so it can be
removed.
 2020-08-03 07:42:56 -04:00
Lioncash 872200c7a9 registered_cache: Resolve -Wmaybe_uninitialized warnings 
While we're at it, we can avoid a redundant map lookup.
 2020-08-03 07:34:46 -04:00
David Marcec b20f4de430 Place in anonymous namespace 2020-08-03 21:31:28 +10:00
David Marcec 46d3c84839 loader: Make IdentifyFile typesafe 
Relies on #4465 for concept.h Common::IsBaseOf
 2020-08-03 21:31:27 +10:00
David ecaac59acd ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer (#4465) 
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer

With the support of C++20, we can use concepts to deduce if a type is an STL container or not.

* More agressive concept for stl containers

* Add -fconcepts

* Move to common namespace

* Add Common::IsBaseOf
 2020-08-03 07:28:54 -04:00
David 6b05ff83bb Merge pull request #4439 from lioncash/cpu 
cpu_manager: Remove redundant std::function declarations
 2020-08-03 20:58:31 +10:00
Morph f6fa311cf9 minor nits 2020-07-31 11:02:59 -04:00
David Marcec 542ea8c6e8 am: Unstub SetScreenShotPermission 2020-08-01 00:44:14 +10:00
Morph 488cacca52 fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute 
Stub these 2 service commands required for Animal Crossing: New Horizons Update 1.4.0
 2020-07-30 15:39:44 -04:00
Morph 06adef078c fs: Rename SaveDataDescriptor to SaveDataAttribute 2020-07-30 15:29:39 -04:00
Morph 4a6d4ab839 xts_archive: Check if the file is nullptr prior to parsing 
Fixes an access violation where the file no longer exists at the specified path while being parsed.
 2020-07-29 06:50:30 -04:00
Morph 0724e89467 registered_cache: Add support for removing folder ncas 2020-07-29 06:50:30 -04:00
bunnei 04a8b17939 Merge pull request #4442 from lioncash/devicemem 
device_memory: Remove unused system member
 2020-07-28 13:03:30 -07:00
Morph 9fa696c0d5 configure_graphics: Remove Force 30 FPS mode 
The introduction of multicore rendered this setting non-functional as timing code was changed.

This removes the setting entirely.
 2020-07-28 08:07:26 -04:00
Lioncash 32ce1467e5 common/atomic_ops: Don't cast away volatile from pointers 
Preserves the volatility of the pointers being casted.
 2020-07-28 04:36:53 -04:00
ReinUsesLisp 87e6485855 service/bsd: Handle Poll with no entries accurately 
Testing shows that Poll called with zero entries returns -1 and signals
an errno of zero.
 2020-07-28 01:51:47 -03:00
ReinUsesLisp 853ee47a15 services/bsd: Implement most of bsd:s 
This implements: Socket, Poll, Accept, Bind, Connect, GetPeerName,
GetSockName, Listen, Fcntl, SetSockOpt, Shutdown, Recv, RecvFrom,
Send, SendTo, Write, and Close

The implementation was done referencing: SwIPC, switchbrew, testing
with libnx and inspecting its code, general information about bsd
sockets online, and analysing official software.

Not everything from these service calls is implemented, but everything
that is not implemented will be logged in some way.
 2020-07-28 01:48:42 -03:00
ReinUsesLisp 20ac4ae8b7 service/sockets: Add worker pool abstraction 
Manage worker threads with an easy to use abstraction.
We can expand this to support thread deletion in the future.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp 3cd68cade4 service/sockets: Add worker abstraction to execute blocking calls asynchronously 
This abstraction allows executing blocking functions (like recvfrom on a
socket configured for blocking) without blocking the service thread.
It is intended to be used with SleepClientThread.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp 8a8f687fd2 service/sockets: Add translate functions 
These functions translate from Network enumerations/structures to guest
enumerations/structures and viceversa.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp c2a607014a service/sockets: Add enumerations and structures 
Add guest enumerations and structures used in socket services
 2020-07-28 01:47:03 -03:00
ReinUsesLisp bd466d12be services/nifm: Implement GetCurrentIpAddress 
This is trivially implemented using the Network abstraction

- Used by ftpd
 2020-07-28 01:47:03 -03:00
Lioncash 078b7446c7 device_memory: Remove unused system member 
This isn't used by anything in particular, so it can be removed.
 2020-07-27 23:37:49 -04:00
Lioncash 3c31a08802 cpu_manager: Remove redundant std::function declarations 
We can just return the function directly. Making for less reading.
 2020-07-27 21:57:05 -04:00
bunnei 1bd1d08fc4 Update src/core/hle/service/nvdrv/devices/nvmap.cpp 
Co-authored-by: LC <mathew1800@gmail.com>
 2020-07-27 18:27:20 -07:00
Lioncash 7decda6bc2 core_timing: Make use of uintptr_t to represent user_data 
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
 2020-07-27 21:21:01 -04:00
CrazyMax ac316a25a1 remove unused variable; 2020-07-27 10:36:26 +03:00
bunnei 991aca142e hle: nvdrv: Rewrite of GPU memory management. 2020-07-26 00:49:43 -04:00
Lioncash f35d0d8f83 nvflinger: Mark interface functions with return values as [[nodiscard]] 
Not using the return value of these functions are undeniably the source
of a bug. This way we allow compilers to loudly make any future misuses
evident.
 2020-07-25 19:42:45 -04:00
Lioncash 94ae1a0bf1 nvflinger: Use return value of Lock() 
comex reported in #4424 that we were incorrectly discarding the return
value of Lock() which is correct.
 2020-07-25 19:04:53 -04:00
bunnei 34f9706950 Merge pull request #4350 from ogniK5377/hid-update-connected 
hid: Only update keyboard & debug pad inputs if enabled
 2020-07-25 11:57:24 -07:00
bunnei 2f7d9afee7 Merge pull request #4380 from ogniK5377/swkbd-inline-1 
swkbd: Return result for Calc request for inlined swkbd
 2020-07-24 22:31:24 -07:00
David Marcec 81b2b4fbe9 audio_core: Apollo Part 1, AudioRenderer refactor 2020-07-25 12:39:34 +10:00
Jan Beich 423d410d7c network: add missing include for BSDs 
src/core/network/network.cpp:112:28: error: use of undeclared identifier 'SHUT_RD'
constexpr int SD_RECEIVE = SHUT_RD;
                           ^
src/core/network/network.cpp:113:25: error: use of undeclared identifier 'SHUT_WR'
constexpr int SD_SEND = SHUT_WR;
                        ^
src/core/network/network.cpp:114:25: error: use of undeclared identifier 'SHUT_RDWR'
constexpr int SD_BOTH = SHUT_RDWR;
                        ^
src/core/network/network.cpp:120:37: error: unknown type name 'in_addr'; did you mean 'in_addr_t'?
constexpr IPv4Address TranslateIPv4(in_addr addr) {
                                    ^~~~~~~
                                    in_addr_t
/usr/include/netdb.h:66:20: note: 'in_addr_t' declared here
typedef __uint32_t      in_addr_t;
                        ^
src/core/network/network.cpp:121:27: error: member reference base type 'in_addr_t' (aka 'unsigned int') is not a structure or union
    const u32 bytes = addr.s_addr;
                      ~~~~^~~~~~~
src/core/network/network.cpp:121:15: error: variables defined in a constexpr function must be initialized
    const u32 bytes = addr.s_addr;
              ^
src/core/network/network.cpp:126:10: error: incomplete result type 'sockaddr' in function definition
sockaddr TranslateFromSockAddrIn(SockAddrIn input) {
         ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:5: error: unknown type name 'sockaddr_in'; did you mean 'sockaddr'?
    sockaddr_in result;
    ^~~~~~~~~~~
    sockaddr
/usr/include/netdb.h:142:9: note: 'sockaddr' declared here
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:17: error: variable has incomplete type 'sockaddr'
    sockaddr_in result;
                ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:131:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:135:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:139:23: error: use of undeclared identifier 'htons'
    result.sin_port = htons(input.portno);
                      ^
src/core/network/network.cpp:143:14: error: variable has incomplete type 'sockaddr'
    sockaddr addr;
             ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:156:1: error: unknown type name 'linger'
linger MakeLinger(bool enable, u32 linger_value) {
^
src/core/network/network.cpp:157:5: error: unknown type name 'linger'
    linger value;
    ^
src/core/network/network.cpp:185:16: error: use of undeclared identifier 'AF_INET'
        return AF_INET;
               ^
src/core/network/network.cpp:195:16: error: use of undeclared identifier 'SOCK_STREAM'
        return SOCK_STREAM;
               ^
src/core/network/network.cpp:197:16: error: use of undeclared identifier 'SOCK_DGRAM'
        return SOCK_DGRAM;
               ^
src/core/network/network.cpp:207:16: error: use of undeclared identifier 'IPPROTO_TCP'
        return IPPROTO_TCP;
               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
 2020-07-22 22:10:15 +00:00