fix: clear stale per-system chunk-sent flags on reconnect to restore terrain load speed

- Add SystemFlagClearForSystem (PlatformNetworkManagerInterface / GameNetworkManager)
- In PlayerList::placeNewPlayer, clear flags when no active player exists on the same system
- Prevent initial chunk transmission from being incorrectly skipped after disconnect/reconnect

Minecraft.Client/Common/Network/GameNetworkManager.cpp

@@ -1264,6 +1264,11 @@ bool CGameNetworkManager::SystemFlagGet(INetworkPlayer *pNetworkPlayer, int inde
 	return s_pPlatformNetworkManager->SystemFlagGet( pNetworkPlayer, index );
 }
 
+void CGameNetworkManager::SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer)
+{
+	s_pPlatformNetworkManager->SystemFlagClearForSystem( pNetworkPlayer );
+}
+
 wstring CGameNetworkManager::GatherStats()
 {
 	return s_pPlatformNetworkManager->GatherStats();

Minecraft.Client/Common/Network/GameNetworkManager.h

@@ -133,6 +133,7 @@ public:
 
 	void SystemFlagSet(INetworkPlayer *pNetworkPlayer, int index);
 	bool SystemFlagGet(INetworkPlayer *pNetworkPlayer, int index);
+	void SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer);
 
 	// Events
 

Minecraft.Client/Common/Network/PlatformNetworkManagerInterface.h

@@ -101,6 +101,7 @@ private:
 public:
 	virtual void SystemFlagSet(INetworkPlayer *pNetworkPlayer, int index) = 0;
 	virtual bool SystemFlagGet(INetworkPlayer *pNetworkPlayer, int index) = 0;
+	virtual void SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer) {}
 
 	virtual wstring GatherStats() = 0;
 	virtual wstring GatherRTTStats() = 0;

Minecraft.Client/Common/Network/PlatformNetworkManagerStub.cpp

@@ -707,6 +707,19 @@ bool CPlatformNetworkManagerStub::SystemFlagGet(INetworkPlayer *pNetworkPlayer,
 	return false;
 }
 
+void CPlatformNetworkManagerStub::SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer)
+{
+	if( pNetworkPlayer == NULL ) return;
+
+	for( unsigned int i = 0; i < m_playerFlags.size(); i++ )
+	{
+		if( pNetworkPlayer->IsSameSystem(m_playerFlags[i]->m_pNetworkPlayer) )
+		{
+			memset(m_playerFlags[i]->flags, 0, m_playerFlags[i]->count / 8);
+		}
+	}
+}
+
 wstring CPlatformNetworkManagerStub::GatherStats()
 {
 	return L"";

Minecraft.Client/Common/Network/PlatformNetworkManagerStub.h

@@ -108,6 +108,7 @@ private:
 public:
 	virtual void SystemFlagSet(INetworkPlayer *pNetworkPlayer, int index);
 	virtual bool SystemFlagGet(INetworkPlayer *pNetworkPlayer, int index);
+	virtual void SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer);
 
 	// For telemetry
 private:

Minecraft.Client/Common/Network/Sony/PlatformNetworkManagerSony.cpp

@@ -1064,6 +1064,19 @@ bool CPlatformNetworkManagerSony::SystemFlagGet(INetworkPlayer *pNetworkPlayer,
 	return false;
 }
 
+void CPlatformNetworkManagerSony::SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer)
+{
+	if( pNetworkPlayer == NULL ) return;
+
+	for( unsigned int i = 0; i < m_playerFlags.size(); i++ )
+	{
+		if( pNetworkPlayer->IsSameSystem(m_playerFlags[i]->m_pNetworkPlayer) )
+		{
+			memset(m_playerFlags[i]->flags, 0, m_playerFlags[i]->count / 8);
+		}
+	}
+}
+
 wstring CPlatformNetworkManagerSony::GatherStats()
 {
 #if 0

Minecraft.Client/Common/Network/Sony/PlatformNetworkManagerSony.h

@@ -129,6 +129,7 @@ private:
 public:
 	virtual void SystemFlagSet(INetworkPlayer *pNetworkPlayer, int index);
 	virtual bool SystemFlagGet(INetworkPlayer *pNetworkPlayer, int index);
+	virtual void SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer);
 
 	// For telemetry
 private:

Minecraft.Client/Durango/Network/PlatformNetworkManagerDurango.cpp

@@ -744,6 +744,19 @@ bool CPlatformNetworkManagerDurango::SystemFlagGet(INetworkPlayer *pNetworkPlaye
 	return false;
 }
 
+void CPlatformNetworkManagerDurango::SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer)
+{
+	if( pNetworkPlayer == NULL ) return;
+
+	for( unsigned int i = 0; i < m_playerFlags.size(); i++ )
+	{
+		if( pNetworkPlayer->IsSameSystem(m_playerFlags[i]->m_pNetworkPlayer) )
+		{
+			memset(m_playerFlags[i]->flags, 0, m_playerFlags[i]->count / 8);
+		}
+	}
+}
+
 wstring CPlatformNetworkManagerDurango::GatherStats()
 {
 	return L"";

Minecraft.Client/Durango/Network/PlatformNetworkManagerDurango.h

@@ -114,6 +114,7 @@ private:
 public:
 	virtual void SystemFlagSet(INetworkPlayer *pNetworkPlayer, int index);
 	virtual bool SystemFlagGet(INetworkPlayer *pNetworkPlayer, int index);
+	virtual void SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer);
 
 	// For telemetry
 private:

Minecraft.Client/PlayerList.cpp

@@ -86,6 +86,32 @@ void PlayerList::placeNewPlayer(Connection *connection, shared_ptr<ServerPlayer>
 			player->setPlayerGamePrivilege(Player::ePlayerGamePrivilege_HOST,1);
 		}
 
+		// A reconnect from the same machine can race with platform-level leave notifications.
+		// If this is the first active player we can currently see for this system, clear the per-system
+		// chunk-sent flags so initial terrain is always resent for this login.
+		if( networkPlayer != NULL )
+		{
+			bool hasActiveSameSystemPlayer = false;
+			for(AUTO_VAR(it, players.begin()); it < players.end(); ++it)
+			{
+				shared_ptr<ServerPlayer> existingPlayer = *it;
+				if( existingPlayer == NULL || existingPlayer->connection == NULL ) continue;
+
+				INetworkPlayer *existingNetworkPlayer = existingPlayer->connection->getNetworkPlayer();
+				if( existingNetworkPlayer == NULL ) continue;
+
+				if( networkPlayer->IsSameSystem(existingNetworkPlayer) )
+				{
+					hasActiveSameSystemPlayer = true;
+					break;
+				}
+			}
+
+			if( !hasActiveSameSystemPlayer )
+			{
+				g_NetworkManager.SystemFlagClearForSystem(networkPlayer);
+			}
+		}
 #if defined(__PS3__) || defined(__ORBIS__)
 		// PS3 networking library doesn't automatically assign PlayerUIDs to the network players for anything remote, so need to tell it what to set from the data in this packet now
 		if( !g_NetworkManager.IsLocalGame() )

Minecraft.Client/Xbox/Network/PlatformNetworkManagerXbox.cpp

@@ -1097,6 +1097,19 @@ bool CPlatformNetworkManagerXbox::SystemFlagGet(INetworkPlayer *pNetworkPlayer,
 	return false;
 }
 
+void CPlatformNetworkManagerXbox::SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer)
+{
+	if( pNetworkPlayer == NULL ) return;
+
+	for( unsigned int i = 0; i < m_playerFlags.size(); i++ )
+	{
+		if( pNetworkPlayer->IsSameSystem(m_playerFlags[i]->m_pNetworkPlayer) )
+		{
+			memset(m_playerFlags[i]->flags, 0, m_playerFlags[i]->count / 8);
+		}
+	}
+}
+
 wstring CPlatformNetworkManagerXbox::GatherStats()
 {
 	return L"Queue messages: " + _toString(((NetworkPlayerXbox *)GetHostPlayer())->GetQNetPlayer()->GetSendQueueSize( NULL, QNET_GETSENDQUEUESIZE_MESSAGES ) )

Minecraft.Client/Xbox/Network/PlatformNetworkManagerXbox.h

@@ -115,6 +115,7 @@ private:
 public:
 	virtual void SystemFlagSet(INetworkPlayer *pNetworkPlayer, int index);
 	virtual bool SystemFlagGet(INetworkPlayer *pNetworkPlayer, int index);
+	virtual void SystemFlagClearForSystem(INetworkPlayer *pNetworkPlayer);
 
 	// For telemetry
 private: