Nikita Edel
ee33f0663f
Merge branch '4jcraft:dev' into fix-with-ubsan
2026-03-12 17:17:38 +01:00
Nikita Edel
6d952e24f5
revising everything
2026-03-12 16:42:36 +01:00
Nikita Edel
6cfc1efec2
Merge branch '4jcraft:dev' into fix-with-ubsan
2026-03-12 14:40:02 +01:00
Tropical
ae84186d3a
chore: remove #pragma warning directives
...
These are only recognized by MSVC and will throw *additional* warnings on other compilers.
2026-03-11 16:49:12 -05:00
Nikita Edel
5d88fa9cf5
add explanation
2026-03-11 20:02:11 +01:00
Nikita Edel
c0198bb8a7
missed one error with clang
2026-03-11 19:41:31 +01:00
Nikita Edel
ec82ee1ea1
final commit
2026-03-11 19:22:28 +01:00
Nikita Edel
1712cd4f47
the tutorial does not crash
2026-03-11 19:04:02 +01:00
Nikita Edel
faa4a989ce
new blob
2026-03-11 18:49:36 +01:00
MathiewMay
96e3832b22
Reverted the SetEntityMotionPacket.cpp changes
2026-03-11 13:36:49 -04:00
MathiewMay
026cb24d66
Revert "Fix entity ID TLS key recreating on every call of getSmallid() for linux, this caused a ID pool corruption."
...
This reverts commit 047615dbbe .
2026-03-11 13:29:14 -04:00
Nikita Edel
b763a92f8e
I FOUND I FOUND IT OMG
2026-03-11 17:42:03 +01:00
Nikita Edel
69a8ce84b9
giant batch BOOOOM
2026-03-11 17:28:13 +01:00
Nikita Edel
ed13020cf3
s integer overflow, unsafe cast
2026-03-11 16:10:48 +01:00
Nikita Edel
a24f9f5a5e
better rounding and s int overflow
2026-03-11 14:21:04 +01:00
MathiewMay
e36e58609d
Reverted the SetEntityMotionPacket.cpp changes
2026-03-11 08:42:19 -04:00
MathiewMay
77deb67b4a
Revert "Rewrote the entity movement packets to use full 16-bit signed short increasing the entity ID limit from 2048 (artifical lce limit) to 32768 ids (0 to 32767)"
...
This reverts commit dac0e883b6 .
2026-03-11 08:39:22 -04:00
Nikita Edel
8395277c0c
shift of signed int, s int overflow
2026-03-11 13:36:44 +01:00
Nikita Edel
63e4b9b18a
next little patch of ub, unallocated variable, s int overflow
2026-03-11 13:36:44 +01:00
MathiewMay
047615dbbe
Fix entity ID TLS key recreating on every call of getSmallid() for linux, this caused a ID pool corruption.
2026-03-11 08:34:20 -04:00
MathiewMay
702839176e
Revert " applied changes requested by tropicaaal"
...
This reverts commit 41d8202c47 .
# Conflicts:
# Minecraft.World/Network/Packets/MoveEntityPacket.cpp
2026-03-11 08:29:24 -04:00
Nikita Edel
11aa08aece
Merge branch '4jcraft:dev' into fix-with-ubsan
2026-03-11 11:57:46 +01:00
Tropical
32bd586c6e
Merge pull request #153 from MathiewMay/dev
...
Build (Linux, x86_64) / build-linux (push) Waiting to run
Build (Linux, x86_64) / build-linux-debug (push) Waiting to run
Changed entity id from 11-bit to 16-bit for movement and motion packets.
2026-03-11 00:31:32 -05:00
Tropical
5b4319556d
refactor: remove redundant casts in MoveEntityPacket
2026-03-11 00:20:23 -05:00
Nikita Edel
caadcfe9db
faulty casts of templated classes
2026-03-11 03:45:56 +01:00
Nikita Edel
dfb200d037
integer oferflow, shift of negative value
2026-03-11 00:26:31 +01:00
Nikita Edel
a006cc5aa0
uninitialized vptr
...
the vptr to isSolidRender() is not known before contruction of the Tile. Its true by default. if false, need to pass false. that is what i did. i verfied what isSolidRender() is in every file. and did exactly what isSolidRender() would return
2026-03-10 23:22:34 +01:00
MathiewMay
41d8202c47
applied changes requested by tropicaaal
...
"i would prefer that these be cast to sized integer types int8_t for portability reasons."
"The light layer changes are ultimately a hack over the broken renderer implementation and probably out of scope for this PR. There's an in-progress fix for the root cause of this, so this should be removed."
"std::numeric_limits<int16_t>::max()"
2026-03-10 18:20:33 -04:00
Nikita Edel
af16088015
improved a change
2026-03-10 20:13:01 +01:00
Nikita Edel
f9fc430c43
Merge branch '4jcraft:dev' into dev
2026-03-10 19:34:42 +01:00
MathiewMay
dac0e883b6
Rewrote the entity movement packets to use full 16-bit signed short increasing the entity ID limit from 2048 (artifical lce limit) to 32768 ids (0 to 32767)
2026-03-09 21:45:08 -04:00
Nikita Edel
021c2809f4
purged -Wdelete-non-abstract-non-virtual-dtor
2026-03-10 02:13:56 +01:00
Tropical
e4868446bd
chore: add comments for 4jcraft-added functionality, undo #135
2026-03-09 19:46:54 -05:00
Nikita Edel
66b31669c3
new batch of delete operator missmatch
2026-03-09 22:48:36 +01:00
Nikita Edel
10ee2085ff
Merge branch '4jcraft:dev' into dev
2026-03-09 22:10:47 +01:00
Nikita Edel
5265eef759
first patch of UB
2026-03-09 21:54:43 +01:00
MathiewMay
9c254bbf4d
SetEntityMotionPacket::write() was sending raw entity ID without masking, changing it to mask the ID to 11 bits first since large entity IDs were accidentally setting the compression flag bit and causing wrong number of bytes to be read by receiver.
2026-03-09 15:34:08 -04:00
sewn
37d285dba1
fix: compile ConsoleSaveFileSplit for standard C++
2026-03-09 15:08:59 +03:00
Tropical
e571795e99
Merge remote-tracking branch 'origin/dev' into refactor/untangle-assets-mess
2026-03-09 00:58:36 -05:00
Tropical
dd46307e4a
Merge branch 'dev' into refactor/untangle-assets-mess
2026-03-09 00:38:30 -05:00
Tropical
ad1e8369bc
refactor: move Common to Platform/Common
2026-03-09 00:17:42 -05:00
MathiewMay
7de4c8a408
Fixed typo in my System::currentTimeMillis which was resulting in very slow or no passed time on world ticks.
2026-03-09 01:04:52 -04:00
Tropical
54dab7708d
refactor: rename Build -> Platform in Minecraft.World
2026-03-08 21:33:18 -05:00
MathiewMay
2ca66673b4
Fix System::currentTimeMillis() not returning correct numbers for linux and preventing the game tick, which then broke the input system.
2026-03-08 22:09:37 -04:00
JuiceyDev
f12cd2e1f2
Merge origin/dev into reapply/dev-on-upstream-202603082259 - auto-resolved conflicts preferring origin/dev
2026-03-08 23:19:14 +01:00
JuiceyDev
e631a62620
Fix: Ensure host-local socket streams created before any Connection is built
2026-03-08 22:59:57 +01:00
JuiceyDev
aadb7172a9
buffer fix
2026-03-08 22:59:57 +01:00
Tropical
66248339e5
refactor: unglob std::dynamic_pointer_cast
2026-03-08 22:44:00 +01:00
Tropical
5045acb86e
fix: unglob everything else and make it build
2026-03-08 22:44:00 +01:00
Tropical
a2e6957383
fix: unglob std::{min, max}, manual stuff
2026-03-08 22:43:59 +01:00