mirror of
https://git.eden-emu.dev/eden-emu/eden
synced 2026-04-26 17:23:56 +00:00
3d0eb4b5d7
This pr aims to make a first step into giving Eden's Vulkan backend maintenance with better formatting, understanding and reduce the redundancy between some wrong implementations: -> ProvokingVertex: Has been reworked completely, now the wiring to ExtendedDynamicState3 (ProvokingVertexMode) it works safe, the gating of the extension no longer requires user enabling on UI, it will be enabled automatically based on what features of the extension are available on driver, depending if first or last mode are available and also will be properly set under TrasformFeedback operations; this way we're gonna ensure all drivers, including Android stock drivers on QCOM, Mali and other mobile vendors drivers access correctly to the extension, fixing some graphical issues (flickering textures or wrong sccisors on vertex that required first mode) generated by the missing first mode handling or the proper clearing on pipeline state. This change will increase/ decrease slightly the performance on some games that changes dynamically between first and last modes, but will also ensure a clear path to GPU to use resources smartly, reducing VRAM consumption in PC and MEM/GPU percentage of use on Android (marginal to 5 - 8% approx). -> Removal VK_EXT_multi_draw: It has passed some months since the first try to implement this feature, but wasn't completed so functionality was null to negative, taking space in source and using small CPU cicles for initialization during device creation that reduced CPU effectiveness by 2 - 5%, aside that, after reviewing the situation of formally introducing handling for multidraws to reduce the floods of constants draw calls into 1 per batch, seems to not pay the overhead when the multidraw capacity is less or equal to 1, aside that, for the time being batching multidraws will introduce indirections on each batch of command draws, that graphical issues will appear and reducing performance can happen, something it was gonna solve. For the time being it's discarded, but, may be analyzed the chance to introduce it properly in a later date. -> Removal VK_EXT_indexing_descriptor: Currently the implementation of this feature was partial, with not proper handling on layouts; just the initial checks on device creation and chained up to the pNext feature, currently this extension will require a buffer cache and texture cache rework to set layouts and reduce the amount of use of descriptor into making it a less expensive cost effective, aside that to generate a path for the Bindless Texture and Bindless Buffer, allowing to track state of textures in runtime and ensuring the state of some compiled shaders doesn't change if it's no needed, among other benefits, besides that, enabling this feature was only generating innecessary checks on GPU, so consumption would be higher than it should be. -> Removal of VK_EXT_swapchain_maintenance1: The use of this feature was really conditional to certain support on newer drivers and cards, which wasn't available for all platforms, I concluded that if the support for this instance wasn't really there, the cost effective between the try to initialize it and running it, won't be good as when it didn't exist on our Vulkan device, with also the constant factor of not being completely implemented, right now I'm aiming to reduce the complexity on Vulkan side to keep it as simple as it could for a future video_core rework, which may start somewhere these weeks. -> Refined the Maintenance features: Meawhile this features are usually inherent to Vulkan core functionality, sometimes drivers doesn't expose them well, which leads to Eden run Vulkan without really noticing the existence of maintenance features on driver to improve stability, so we're tied to declare them and load them when a device creation starts by asking if driver supports and which, currently 1 - 5 are core maintenance features, meanwhile the 7 - 9 are more experimental and not being available everywhere, so right now to help drivers give attention to this features we not only load them, but also calculate with features bits which features inside Maintenance5 are available to use, that was the initial purpose, but we weren't using the full potential of the extension; I made cleaned part of the unneeded log code for the initialization of this Maintenance5 and it's feature flags, but also making an operation to sanitize depth/ stencil when One is not available in swizzle operations, making it easier to draw it; it's also needed to mention that Maintenance9 was removed from source code until we can have better handling on Arrays2D, aside that, the use of the extension was really conditional to certain drivers being capable of use it, so I remove it. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3839 Co-authored-by: CamilleLaVey <camillelavey99@gmail.com> Co-committed-by: CamilleLaVey <camillelavey99@gmail.com> |
||
|---|---|---|
| .. | ||
| android | ||
| arm64 | ||
| fs | ||
| windows | ||
| x64 | ||
| address_space.cpp | ||
| address_space.h | ||
| address_space.inc | ||
| algorithm.h | ||
| alignment.h | ||
| announce_multiplayer_room.h | ||
| assert.cpp | ||
| assert.h | ||
| atomic_ops.h | ||
| bit_field.h | ||
| bit_util.h | ||
| bounded_threadsafe_queue.h | ||
| cityhash.cpp | ||
| cityhash.h | ||
| CMakeLists.txt | ||
| common_funcs.h | ||
| common_types.h | ||
| concepts.h | ||
| container_hash.h | ||
| demangle.cpp | ||
| demangle.h | ||
| detached_tasks.cpp | ||
| detached_tasks.h | ||
| device_power_state.cpp | ||
| device_power_state.h | ||
| div_ceil.h | ||
| dynamic_library.cpp | ||
| dynamic_library.h | ||
| elf.h | ||
| error.cpp | ||
| error.h | ||
| expected.h | ||
| fiber.cpp | ||
| fiber.h | ||
| fixed_point.h | ||
| free_region_manager.h | ||
| hash.h | ||
| heap_tracker.cpp | ||
| heap_tracker.h | ||
| hex_util.cpp | ||
| hex_util.h | ||
| host_memory.cpp | ||
| host_memory.h | ||
| httplib.h | ||
| input.h | ||
| intrusive_list.h | ||
| intrusive_red_black_tree.h | ||
| literals.h | ||
| log_classes.inc | ||
| logging.cpp | ||
| logging.h | ||
| lru_cache.h | ||
| lz4_compression.cpp | ||
| lz4_compression.h | ||
| make_unique_for_overwrite.h | ||
| math_util.h | ||
| memory_detect.cpp | ||
| memory_detect.h | ||
| multi_level_page_table.cpp | ||
| multi_level_page_table.h | ||
| multi_level_page_table.inc | ||
| overflow.h | ||
| page_table.cpp | ||
| page_table.h | ||
| param_package.cpp | ||
| param_package.h | ||
| parent_of_member.h | ||
| point.h | ||
| polyfill_thread.h | ||
| quaternion.h | ||
| random.cpp | ||
| random.h | ||
| range_map.h | ||
| range_mutex.h | ||
| range_sets.h | ||
| range_sets.inc | ||
| ring_buffer.h | ||
| scm_rev.cpp.in | ||
| scm_rev.h | ||
| scope_exit.h | ||
| scratch_buffer.h | ||
| settings.cpp | ||
| settings.h | ||
| settings_common.cpp | ||
| settings_common.h | ||
| settings_enums.h | ||
| settings_input.cpp | ||
| settings_input.h | ||
| settings_setting.h | ||
| signal_chain.cpp | ||
| signal_chain.h | ||
| slot_vector.h | ||
| socket_types.h | ||
| spin_lock.h | ||
| stb.cpp | ||
| stb.h | ||
| steady_clock.cpp | ||
| steady_clock.h | ||
| stream.cpp | ||
| stream.h | ||
| string_util.cpp | ||
| string_util.h | ||
| swap.h | ||
| thread.cpp | ||
| thread.h | ||
| thread_queue_list.h | ||
| thread_worker.h | ||
| threadsafe_queue.h | ||
| time_zone.cpp | ||
| time_zone.h | ||
| tiny_mt.h | ||
| tree.h | ||
| typed_address.h | ||
| uint128.h | ||
| unique_function.h | ||
| uuid.cpp | ||
| uuid.h | ||
| vector_math.h | ||
| virtual_buffer.cpp | ||
| virtual_buffer.h | ||
| wall_clock.cpp | ||
| wall_clock.h | ||
| zstd_compression.cpp | ||
| zstd_compression.h | ||