null/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden synced 2026-05-01 19:54:10 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
16995 commits 156 branches 24 tags 186 MiB
Commit graph

7252 commits

Author SHA1 Message Date
David c95dd42b72 audio_renderer: Preliminary BehaviorInfo (#3736) 
* audio_renderer: Preliminary BehaviorInfo

* clang format

* Fixed IsRevisionSupported

* fixed IsValidRevision

* Fixed logic error & spelling errors & crash

* Addressed issues
 2020-04-20 22:57:30 -04:00
bunnei 405c9b15c9 loader: nro: Fix process initialization using ProgramMetadata default. 2020-04-20 18:19:45 -04:00
bunnei 8ef209a529 loader: elf: Fix process initialization using ProgramMetadata default. 2020-04-20 18:19:45 -04:00
bunnei 4dbf21a6cf file_sys: program_metadata: Add a helper function for generating reasonable default metadata. 
- We need this for homebrew process initialization.
 2020-04-20 18:19:45 -04:00
Lioncash d73e0ef309 service: Update function tables 
Keeps the service function tables up to date.

Updated based off information on SwitchBrew.
 2020-04-20 15:53:49 -04:00
Mat M 70d6c5b246 Merge pull request #3739 from MerryMage/disable_cpu_opt 
dynarmic: Add option to disable CPU JIT optimizations
 2020-04-20 14:19:18 -04:00
FearlessTobi 45243e63d8 npad: Lower log level for VibrateController to Debug 2020-04-20 18:44:57 +02:00
FearlessTobi f1135379fd audren: Lower log level for RequestUpdateImpl to Debug 2020-04-20 18:44:41 +02:00
MerryMage 0bbafff3db dynarmic: Add option to disable CPU JIT optimizations 2020-04-20 13:36:26 +01:00
bunnei 2f257f51a9 Merge pull request #3712 from lioncash/remove 
service: Remove unused RequestParser instances
 2020-04-20 01:04:04 -04:00
bunnei 42f889f2a2 Merge pull request #3709 from lioncash/am 
am: Resolve ineffective moves
 2020-04-20 00:15:00 -04:00
Lioncash 8bcb8b177c service/time: Remove reliance on the global system accessor 
Eliminates usages of the global system accessor and instead passes the
existing system instance into the interfaces.
 2020-04-19 16:31:28 -04:00
bunnei 2aacd00137 Merge pull request #3696 from lioncash/cast-size 
hle_ipc: Remove std::size_t casts where applicable
 2020-04-19 14:24:15 -04:00
MerryMage 5451c81b74 thread: FPCR.FZ is likely not 1 2020-04-19 08:37:20 +01:00
bunnei 5ce3dc16a5 core: arm_unicorn: Fix interpret fallback by temporarily mapping instruction page. 2020-04-19 00:53:23 -04:00
bunnei 610f78e1eb Merge pull request #3710 from lioncash/nso 
loader/nso: Resolve moves not occurring in DecompressSegment
 2020-04-18 14:44:42 -04:00
Mat M fb321bdb18 Merge pull request #3715 from bunnei/fix-impl-fallthrough 
service: hid: npad: Fix implicit fallthrough errors.
 2020-04-18 14:44:20 -04:00
bunnei f220140e8a service: hid: npad: Fix implicit fallthrough errors. 2020-04-18 14:41:08 -04:00
bunnei 32fd01e339 Merge pull request #3713 from lioncash/time 
service/time: Minor changes
 2020-04-17 21:04:43 -04:00
Lioncash de87fe690e time/system_clock_core: Remove unnecessary initializer 
This is already initialized within the class body.
 2020-04-17 20:04:06 -04:00
Lioncash 8c0589239b service/time: Mark IsStandardNetworkSystemClockAccuracySufficient as const 
This doesn't modify internal member state.
 2020-04-17 20:02:45 -04:00
Lioncash 30af9f0d5c service/time: Add virtual destructors where applicable 
Many of these implementations are used to implement a polymorphic
interface. While not directly used polymorphically, this prevents
virtual destruction from ever becoming an issue.
 2020-04-17 19:59:31 -04:00
Lioncash 5f25db88b1 service: Remove unused RequestParser instances 
These aren't used, so they should be removed to reduce compilation
warnings.
 2020-04-17 19:47:43 -04:00
Lioncash ac3ff8c9ba memory/slab_heap: Make use of static_cast over reinterpret_cast 
Casting from void* with static_cast is permitted by the standard, so we
can just make use of that instead.
 2020-04-17 19:38:59 -04:00
Lioncash d0569a0865 loader/nso: Resolve moves not occurring in DecompressSegment 
Given the std::vector was const, an automatic move out of the function
could not occur.

We can allow automatic return value optimizations to occur by making the
buffer non-const.
 2020-04-17 19:26:50 -04:00
Lioncash 972240e94a am: Resolve ineffective moves 
Previously const objects were being std::moved, which results in no move
actually occurring. This resolves that.
 2020-04-17 19:22:46 -04:00
bunnei 4cdbd44f51 core: hle: Address various feedback & code cleanup. 
- Should be no functional changes.
 2020-04-17 00:59:36 -04:00
bunnei 2e718b26c8 core: device_memory: Remove incorrect usage of constexpr. 2020-04-17 00:59:36 -04:00
bunnei bdf7501e7b memory: Add copyright notice for Atmosphere where applicable. 2020-04-17 00:59:35 -04:00
bunnei 0cf0195874 kernel: Remove old VMManager class. 2020-04-17 00:59:35 -04:00
bunnei a48860f7ba loader: nso: Fix loader size and arguments. 2020-04-17 00:59:35 -04:00
bunnei 9b2526392a loader: elf/kip/nro: Updates for new VMM. 2020-04-17 00:59:35 -04:00
bunnei 0707404f34 service: ldr: Updates for new VMM. 
- Includes removing some service impls. that are untested.
 2020-04-17 00:59:35 -04:00
bunnei 27b5b6c36f kernel: memory: page_table: Simplify GetPhysicalAddr impl. 2020-04-17 00:59:35 -04:00
bunnei 6b40850b9a kernel: svc: Updates for new VMM. 
- Includes removing some SVC impls. that are untested.
 2020-04-17 00:59:34 -04:00
bunnei 8a67b3058e core: memory: Fix memory access on page boundaries. 
- Fixes Super Smash Bros. Ultimate.
 2020-04-17 00:59:34 -04:00
bunnei 43321c1a69 core: memory: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei b592621ffe core: gdbstub: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei 93828bffc2 core: reporter: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 88324e3513 memory: cheat_engine: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 5fd6e219ea kernel: process: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 7e1001c2d3 service: pl_u: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 38b51e2ffe service: time: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 410667d72a service: hid: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 6d110ee83c service: irs: Update for new shared memory layout. 2020-04-17 00:59:32 -04:00
bunnei 15e751e36c kernel: resource_limit: Reserve physical memory. 2020-04-17 00:59:32 -04:00
bunnei 76a040f50d kernel: Initialize memory layout for new VMM. 2020-04-17 00:59:32 -04:00
bunnei 769f8cbf79 core: system: Rename GetDeviceManager -> DeviceManager. 
- More consistent with other system components.
 2020-04-17 00:59:32 -04:00
bunnei d04147e731 kernel: transfer_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei 89776f7ef7 core: Construct/Destruct DeviceMemory on Init/Shutdown. 2020-04-17 00:59:32 -04:00
bunnei 9edd67f475 kernel: shared_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei 5b2cf55742 core: device_memory: Update to use VirtualBuffer class. 2020-04-17 00:59:31 -04:00
bunnei 6ef844fab3 kernel: errors: Add ERR_OUT_OF_RESOURCES. 2020-04-17 00:59:31 -04:00
bunnei 1717cdf811 kernel: process_capability: Update to use Memory::PageTable. 2020-04-17 00:59:31 -04:00
bunnei 6fe68ddea2 kernel: memory: Add PageTable class, to manage process address space. 2020-04-17 00:59:31 -04:00
bunnei ea8bc8e759 kernel: memory: Add MemoryLayout class, to build physical memory layout. 2020-04-17 00:59:31 -04:00
bunnei 9b912d155a kernel: memory: Add MemoryManager class, to manage page heaps. 2020-04-17 00:59:30 -04:00
bunnei 227e9ac5d7 kernel: memory: Add MemoryBlockManager class, to manage memory blocks. 2020-04-17 00:59:30 -04:00
bunnei 036f2f9176 kernel: memory: Add PageHeap class, to manage a heap of pages. 2020-04-17 00:59:30 -04:00
bunnei b013b110bc kernel: memory: Add PageLinkedList class, to manage a list of pages. 2020-04-17 00:59:30 -04:00
bunnei b94f043b7b kernel: memory: Add system_control code, which will be used for ASLR support. 2020-04-17 00:59:30 -04:00
bunnei 72d1cda09a physical_memory: Add missing include for <vector>. 2020-04-17 00:59:30 -04:00
bunnei 91a38e3fa8 kernel: memory: Add MemoryBlock class, for managing memory blocks and their state. 2020-04-17 00:59:29 -04:00
bunnei eadd36d143 kernel: memory: Add memory_types.h, for things that are commonly used in memory code. 2020-04-17 00:59:29 -04:00
bunnei 91b899ff00 kernel: memory: Add SlabHeap class, for managing memory heaps. 
- This will be used for TLS pages, among other things.
 2020-04-17 00:59:29 -04:00
bunnei 9fd238a0f8 kernel: memory: Add AddressSpaceInfo class, for managing the memory address space. 2020-04-17 00:59:29 -04:00
bunnei ea806268fa core: device_manager: Add a simple class to manage device RAM. 2020-04-17 00:59:29 -04:00
bunnei a7b2390b73 dynarmic: Enable strict alignment checks. 
- Also add a missing include.
 2020-04-17 00:59:29 -04:00
bunnei 5b9e69e7fe core: memory: Move to Core::Memory namespace. 
- helpful to disambiguate Kernel::Memory namespace.
 2020-04-17 00:59:28 -04:00
bunnei a10f82b62d core: kernel: Add svc_types header to include SVC-specific types. 2020-04-17 00:59:28 -04:00
bunnei ed940661a8 core: kernel: Move SVC to its own namesapce. 2020-04-17 00:59:28 -04:00
bunnei bdd81bdebf kernel: resource_limit: Improvements to implementation. 2020-04-17 00:59:27 -04:00
bunnei 9006c82b27 loader: nso: Fix loading of static objects to be properly sized and aligned. 2020-04-17 00:59:27 -04:00
bunnei 365f14cd2c process: SetupMainThread: Zero out argument on process start. 2020-04-17 00:11:50 -04:00
bunnei 1be8e24189 arm_interface: Ensure ThreadContext is zero'd out. 2020-04-17 00:11:50 -04:00
Lioncash eaeb4520f7 General: Resolve warnings related to missing declarations 2020-04-16 23:43:34 -04:00
MerryMage b3a0ce058f gdbstub: Fix some gdbstub jankiness 
1. Ensure that register information available to gdbstub is most up-to-date.
2. There's no reason to check for current_thread == thread when emitting a trap.
   Doing this results in random hangs whenever a step happens upon a thread switch.
 2020-04-17 05:41:43 +02:00
bunnei f0b4b5be4c Merge pull request #3671 from lioncash/switch 
kernel/thread: Resolve -Wswitch warnings
 2020-04-16 23:30:32 -04:00
Lioncash 3c70e27d64 key_manager: Resolve missing field initializer warning 2020-04-16 22:45:44 -04:00
Lioncash bcc5066cfe time_zone_manager: Resolve sign conversion warnings 
ttis and ats will never exceed the length of INT32_MAX in our case, so
this is safe.
 2020-04-16 22:23:59 -04:00
Lioncash f8fe53c9f9 hle_ipc: Remove std::size_t casts where applicable 
These were added in the change that enabled -Wextra on linux builds so
as not to introduce interface changes in the same change as a
build-system flag addition.

Now that the flags are enabled, we can freely change the interface to
make these unnecessary.
 2020-04-16 22:02:10 -04:00
bunnei 7a4ed2581d Merge pull request #3673 from lioncash/extra 
CMakeLists: Specify -Wextra on linux builds
 2020-04-16 21:12:33 -04:00
Markus Wick 3567e464d2 externals: Move LibreSSL linking to httplib. 
Neither core nor web_services use OpenSSL nor LibreSSL.
However they need to link them as it's a requirement of httplib.
So let's declare this within httplib instead of core and web_services.
 2020-04-16 16:46:33 +02:00
Rodrigo Locatti 50a1a6e6a9 Merge pull request #3659 from bunnei/time-calc-standard-user 
service: time: Implement CalculateStandardUserSystemClockDifferenceByUser.
 2020-04-16 02:51:57 -03:00
Lioncash 02e095313a CMakeLists: Specify -Wextra on linux builds 
Allows reporting more cases where logic errors may exist, such as
implicit fallthrough cases, etc.

We currently ignore unused parameters, since we currently have many
cases where this is intentional (virtual interfaces).

While we're at it, we can also tidy up any existing code that causes
warnings. This also uncovered a few bugs as well.
 2020-04-15 21:33:46 -04:00
Lioncash 6ea751d910 CMakeLists: Make -Wreorder a compile-time error 
This can result in silent logic bugs within code, and given the amount
of times these kind of warnings are caused, they should be flagged at
compile-time so no new code is submitted with them.
 2020-04-15 14:14:41 -04:00
Lioncash 0f32ae2140 kernel/thread: Resolve -Wswitch warnings 2020-04-15 13:48:14 -04:00
bunnei ba413f9277 service: time: Implement CalculateStandardUserSystemClockDifferenceByUser. 
- Used by Animal Crossing: New Horizons.
 2020-04-14 22:28:41 -04:00
Zach Hilman 136e9aebfd Merge pull request #3660 from bunnei/friend-blocked-users 
service: friend: Stub IFriendService::GetBlockedUserListIds.
 2020-04-14 16:59:46 -04:00
bunnei 72c1dd467d file_sys: patch_manager: Return early when there are no layers to apply. 2020-04-14 16:25:55 -04:00
bunnei 7ecacdfa3b service: friend: Stub IFriendService::GetBlockedUserListIds. 
- This is safe to stub, as there should be no adverse consequences from reporting no blocked users.
 2020-04-14 16:20:51 -04:00
bunnei bd114e97fc Merge pull request #3606 from ReinUsesLisp/nvflinger 
service/vi: Partially implement BufferQueue disconnect
 2020-04-12 11:44:48 -04:00
Rodrigo Locatti 912162d42d Merge pull request #3635 from FernandoS27/buffer-free 
Buffer queue: Correct behavior of free buffer.
 2020-04-11 17:58:15 -03:00
bunnei aeac4d2d60 Merge pull request #3594 from ReinUsesLisp/vk-instance 
yuzu: Drop SDL2 and Qt frontend Vulkan requirements
 2020-04-10 20:06:55 -04:00
Fernando Sahmkow 7d65c9c9ea Buffer queue: Correct behavior of free buffer. 
This corrects the behavior of free buffer after witnessing it in an
unrelated hardware test. I haven't found any games affected by it but in
name of better accuracy we'll correct such behavior.
 2020-04-10 16:44:28 -04:00
ReinUsesLisp f35703f7cd service/vi: Partially implement BufferQueue disconnect 2020-04-10 01:00:50 -03:00
Rodrigo Locatti dcd672b1a6 Merge pull request #3610 from FernandoS27/gpu-caches 
Refactor all the GPU Caches to use VAddr for cache addressing
 2020-04-09 17:59:21 -03:00
Fernando Sahmkow f00f6bbdb6 Memory: Address Feedback. 2020-04-08 13:40:46 -04:00
ReinUsesLisp 30bbdc653c yuzu: Drop SDL2 and Qt frontend Vulkan requirements 
Create Vulkan instances and surfaces from the Vulkan backend.
 2020-04-07 16:32:19 -03:00
enler d7dc7964f1 file_sys: fix LayeredFS error when loading some games made with… (#3602) 
* fix LayeredFS error when loading some games made with the Unity
 2020-04-07 02:03:32 +02:00
Fernando Sahmkow 3728c7160f Buffer Cache: Use vAddr instead of physical memory. 2020-04-06 09:23:06 -04:00
Fernando Sahmkow 5cc292ac3c GPU: Setup Flush/Invalidate to use VAddr instead of CacheAddr 2020-04-06 09:21:46 -04:00
Fernando Sahmkow a2fb02c1e2 Merge pull request #3563 from bunnei/fix-ldr-memstate 
services: ldr: Fix MemoryState for read/write regions of NROs.
 2020-04-03 10:14:56 -04:00
Rodrigo Locatti 5bd5340d17 Merge pull request #3552 from jroweboy/single-context 
Refactor Context management (Fixes renderdoc on opengl issues)
 2020-04-02 01:38:25 -03:00
Morph bda37c4bb4 capsrv: Split Capture services into individual files and stub GetAlbumContentsFileListForApplication (#3571) 
* Organize capture services into individual files

* Stub GetAlbumContentsFileListForApplication

* Address feedback
 2020-03-31 19:16:36 -04:00
bunnei e842f70c4a Merge pull request #3568 from bunnei/time-calcspan 
services: time: Implement CalculateSpanBetween.
 2020-03-29 00:03:55 -04:00
bunnei 3660347e8d Merge pull request #3562 from perillamint/vrsvc 
am: Implement VR related APIs
 2020-03-28 13:32:52 -04:00
bunnei c84586b412 services: hid: Stub InitializeSevenSixAxisSensor. 
- Used by Super Smash Bros. Ultimate v7.0.0.
 2020-03-27 10:48:01 -04:00
bunnei 748ddc628c services: time: Implement CalculateSpanBetween. 
- Used by Super Smash Bros. Ultimate.
 2020-03-27 10:42:13 -04:00
perillamint 133948067c am: Implement VR related APIs 
Implement (and stub) VR related APIs in AM sysmodule.

This fixes issue #2938
 2020-03-27 18:22:28 +09:00
bunnei 7ee7aa21b1 services: ldr: Fix MemoryState for read/write regions of NROs. 
- Fixes #3541, used by Final Fantasy VIII Remastered.
 2020-03-26 15:52:59 -04:00
James Rowe c935a1a475 Address review and fix broken yuzu-tester build 2020-03-25 23:32:42 -06:00
James Rowe b37d69e5e1 Frontend/GPU: Refactor context management 
Changes the GraphicsContext to be managed by the GPU core. This
eliminates the need for the frontends to fool around with tricky
MakeCurrent/DoneCurrent calls that are dependent on the settings (such
as async gpu option).

This also refactors out the need to use QWidget::fromWindowContainer as
that caused issues with focus and input handling. Now we use a regular
QWidget and just access the native windowHandle() directly.

Another change is removing the debug tool setting in FrameMailbox.
Instead of trying to block the frontend until a new frame is ready, the
core will now take over presentation and draw directly to the window if
the renderer detects that its hooked by NSight or RenderDoc

Lastly, since it was in the way, I removed ScopeAcquireWindowContext and
replaced it with a simple subclass in GraphicsContext that achieves the
same result
 2020-03-24 21:03:42 -06:00
bunnei 84f3e27ffa Merge pull request #3524 from FearlessTobi/port-5106 
Port citra-emu/citra#5106: "gdbstub: Ensure gdbstub doesn't drop packets crucial to initialization"
 2020-03-24 16:50:58 -04:00
FearlessTobi 23a8887526 sm/controller: Increase PointerBufferSize 
This increases the PointerBufferSize as a lager one is required by some services.
This change is still not hw-accurate, but it is proven to work in Ryujinx.

Instead of using a hardcoded size, we should figure out the specific values for each service in the future. Some of them can be taken from Atmosphere: https://github.com/Atmosphere-NX/Atmosphere/search?q=PointerBufferSize.
 2020-03-23 03:19:30 +01:00
bunnei fb767310ca Merge pull request #3477 from FearlessTobi/webapplet-shit 
core/web_browser: Allow WebApplet to exit gracefully when an error occurs
 2020-03-22 13:11:02 -04:00
FearlessTobi 1c7dcf3858 core/web_browser: Allow WebApplet to exit gracefully when an error occurs 
Currently, yuzu just freezes when an error occurs while Initializing the WebApplet.
From a user perspective, this obviously isn't great as the game just softlocks.
With this change, yuzu will call the Finalize method, so to the game it seems like as the user just exited the WebApplet normally.

This works around https://github.com/yuzu-emu/yuzu/issues/2852.
 2020-03-22 16:01:13 +01:00
Dan d5c239a047 set: implement GetRegionCode 2020-03-19 10:37:42 +01:00
bunnei 32ef3d9487 Merge pull request #3527 from FearlessTobi/output-mode 
yuzu: Save sound output mode and set it to Stereo by default
 2020-03-18 23:19:22 -04:00
ReinUsesLisp e656938a5a time_zone_content_manager: Fix out of bounds read 
There were cases where raw_data didn't contain enough
space to hold the zero terminator.

This was caught with -fsanitize=address.
 2020-03-18 19:06:16 -03:00
FearlessTobi 918657de2e yuzu: Save sound output mode and set it to Stereo by default 2020-03-17 19:03:00 +01:00
Gauvain "GovanifY" Roussel-Tarbouriech fc6dfe012c gdbstub: small logic bug fix with defer_start 2020-03-17 11:18:39 +01:00
Gauvain "GovanifY" Roussel-Tarbouriech 32ebfa66fe gdbstub: Ensure gdbstub doesn't drop packets crucial to initialization 2020-03-17 11:18:13 +01:00
bunnei 586bdc38b0 Merge pull request #3497 from FernandoS27/microprogfile-extend 
Small corrections and features to microprofile
 2020-03-12 12:14:03 -04:00
Fernando Sahmkow babc572a47 NVFlinger: Do the microprofile Flip after processing a valid frame. 2020-03-12 10:52:44 -04:00
Vitor Kiguchi d28c202e1d framebuffer_layout.h: drop the use of enum for screen dimensions. 
+clang format
 2020-03-11 14:22:28 -03:00
Rodrigo Locatti 8d86741eb9 Merge pull request #3301 from ReinUsesLisp/state-tracker 
video_core: Remove gl_state and use a state tracker based on dirty flags
 2020-03-09 18:34:37 -03:00
bunnei 978cd350dd Merge pull request #3452 from Morph1984/anisotropic-filtering 
frontend/Graphics: Add "Advanced" graphics tab and experimental Anisotropic Filtering support
 2020-03-07 22:28:35 -05:00
bunnei 36c4c33bb8 core: hle: Implement separate A32/A64 SVC interfaces. 2020-03-02 21:52:03 -05:00
bunnei 048ac77adc core: Implement separate A32/A64 ARM interfaces. 2020-03-02 21:51:57 -05:00
bunnei 9b0419ce67 core: loader: Remove check for 32-bit. 2020-03-02 21:43:15 -05:00
bunnei 9137455d86 core: dynarmic: Add CP15 from Citra. 2020-03-02 21:43:15 -05:00
bunnei 07f23df4cb Merge pull request #3464 from FernandoS27/jit-fix 
ARM_Interface: Cache the JITs instead of deleting/recreating.
 2020-03-02 21:41:43 -05:00
ReinUsesLisp 005f5ca883 video_core: Reintroduce dirty flags infrastructure 2020-02-28 17:56:41 -03:00
Morph c6e07faf25 Create an "Advanced" tab in the graphics configuration tab and add anisotropic filtering levels. 2020-02-27 21:34:00 -05:00
bunnei 3b7528d736 Merge pull request #3430 from bunnei/split-presenter 
Port citra-emu/citra#4940: "Split Presentation thread from Render thread"
 2020-02-27 19:51:55 -05:00
Morph 055ebfc2e7 AM/ICommonStateGetter: Stub SetLcdBacklighOffEnabled (#3454) 
* Stub SetLcdBacklighOffEnabled

Used by Super Smash Bros. Ultimate
We require backlight services to be implemented to turn on/off the backlight.

* Address feedback
 2020-02-27 17:49:23 +01:00
bunnei cba9bdcab0 renderer_opengl: Move Frame/FrameMailbox to OpenGL namespace. 2020-02-26 18:28:50 -05:00
Fernando Sahmkow 2f55c11a35 ARM_Interface: Cache the JITs instead of deleting/recreating. 
This was a bug inherited from citra which was fixed by then at some 
time. This commit corrects such bug and ensures JITs are correctly 
recycled.
 2020-02-26 15:53:47 -04:00
bunnei e32ba13702 Merge pull request #3431 from CJBok/npad-fix 
InputCommon: analog_from_button get direction implementation
 2020-02-25 21:39:26 -05:00
bunnei f1f2405b9f core: frontend: Refactor scope_acquire_window_context to scope_acquire_context. 2020-02-25 21:23:00 -05:00
bunnei 6904e8442d frontend: sdl2: emu_window: Implement separate presentation thread. 2020-02-25 21:23:00 -05:00
bunnei 361819a125 renderer_opengl: Add texture mailbox support for presenter thread. 2020-02-25 21:22:59 -05:00
bunnei 27e56facc9 core: frontend: emu_window: Add TextureMailbox class. 2020-02-25 21:22:57 -05:00
bunnei f93fe8e862 core: settings: Add setting to enable vsync, which is on by default. 2020-02-25 20:57:02 -05:00
Fernando Sahmkow d0b12c793d Scheduler: Inline global scheduler in Scheduler Lock. 2020-02-22 12:39:17 -04:00
Fernando Sahmkow d6584d988f Kernel: Correct pending feedback. 2020-02-22 11:51:03 -04:00
Fernando Sahmkow 8a079a59ed System: Expose Host thread registering routines from kernel. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow 78f01601d0 Kernel: Address Feedback. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow 7c2b72bcef Kernel: Implement Scheduler locks 2020-02-22 11:18:07 -04:00
Fernando Sahmkow fe53ac3e33 Kernel: Implement Time Manager. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow e6cc0a48e0 Kernel: Rename ThreadCallbackHandleTable and Setup Thread Ids on Kernel. 2020-02-22 11:18:06 -04:00
Fernando Sahmkow f5da504663 Kernel: Make global scheduler depend on KernelCore 2020-02-22 11:18:06 -04:00
Brian Clinkenbeard 050a4362ad httplib compatibility 2020-02-18 18:04:33 -08:00
CJBok 7ec4bd7793 analog_from_button get direction implementation 2020-02-18 06:45:37 +01:00
bunnei 92e3fb6e2f Merge pull request #3412 from Morph1984/aspect-ratio 
GUI: Add aspect ratio dropdown
 2020-02-17 22:02:18 -05:00
bunnei a251713173 Merge pull request #3420 from namkazt/master2 
nvhost_gpu: implement ChannelSetTimeslice
 2020-02-17 00:31:11 -05:00
Nguyen Dac Nam 2807020c01 IUserLocalCommunicationService: add function Initialize2 2020-02-16 13:24:34 +07:00
Nguyen Dac Nam c4e8f9589a HLE: correct function name of IUserLocalCommunicationService 
402: function name should be Initialize2 (7.0.0+) not SetOperationMode
Follow by: https://switchbrew.org/wiki/LDN_services#IUserLocalCommunicationService
 2020-02-16 13:14:06 +07:00
namkazy 8bb64da7ac nvhost_gpu: implement ChannelSetTimeslice 2020-02-16 11:53:03 +07:00
bunnei 2e46017b66 Merge pull request #3401 from FernandoS27/synchronization 
Set of refactors for Kernel Synchronization and Hardware Constants
 2020-02-14 14:40:20 -05:00
Morph 5afb6b95ed Add 4:3 aspect ratio and address feedback 2020-02-14 14:39:04 -05:00
Fernando Sahmkow f326183e8b Core: Correct compilition in GCC 2020-02-14 05:53:30 -04:00
Morph 5abb2b6336 Address feedback 2020-02-14 00:06:26 -05:00
Morph db5dc22c68 Use enumeration instead of magic numbers 2020-02-13 23:13:23 -05:00
Morph 74a490c909 Add following aspect ratios: 16:9, 21:9, Stretch to Window 
Available as a drop down within the configure graphics tab.
 2020-02-13 22:17:28 -05:00
bunnei f542fc989d Merge pull request #3400 from makigumo/patch-1 
update hwopus DecodeInterleaved for FW 7.0.0+
 2020-02-13 21:26:13 -05:00
Fernando Sahmkow 0d2a459fae Core: Address Feedback 2020-02-13 19:10:33 -04:00
Lioncash 5c0742bb94 address_arbiter: Collapse loops in InsertThread() and RemoveThread() 
Same behavior, but without the need to explicitly loop through
everything manually.
 2020-02-12 15:34:07 -05:00
Lioncash 3105b7864c address_arbiter: Simplify GetThreadsWaitingOnAddress() 
Simplifies the overall function and also allows for it to become a
const-qualified member function.
 2020-02-12 15:10:16 -05:00
bunnei 3184bdd36c Merge pull request #3403 from lioncash/debug 
bcat/backend: Prevent fmt exception in debug log within NullBackend::Clear()
 2020-02-12 11:17:43 -05:00
Lioncash d5435df964 bcat/backend: Make formatting of passphrase consistent in NullBackend::SetPassphrase() 
Aligns the '=' to be consistent with the rest of the logs within this
source file.
 2020-02-12 01:18:29 -05:00
Lioncash 8792d4562c bcat/backend: Prevent fmt exception in debug log within NullBackend::Clear() 
A formatting specifier within Clear wasn't being used, which will cause
fmt to throw an exception. This fixes that.
 2020-02-12 01:14:47 -05:00
Lioncash 750c48af18 kernel/thread: Remove trivial usages of the global system accessor 
We can just use the kernel member variable directly instead of going
through the system to obtain the same thing.
 2020-02-12 01:00:41 -05:00
Fernando Sahmkow 6fc0790f3a Core: Set all hardware emulation constants in a single file. 2020-02-11 20:19:11 -04:00
Fernando Sahmkow 1ee7a4d926 Kernel: Refactor synchronization to better match RE 2020-02-11 18:47:31 -04:00
makigumo b71b872e74 update hwopus DecodeInterleaved for FW 7.0.0+ 
trivial change,
see https://switchbrew.org/wiki/Audio_services#IHardwareOpusDecoder
 2020-02-11 18:41:04 +01:00
Fernando Sahmkow 3a7f539463 Kernel: Change WaitObject to Synchronization object. In order to better reflect RE. 2020-02-11 10:46:25 -04:00
bunnei 3edec585bc hle: services: Use std::shared_ptr instead of copy by value. 2020-02-07 23:02:26 -05:00
bunnei e4c167aff9 Merge pull request #3381 from bunnei/ipc-fix 
hle: services: Fix prepo IPC, and add better error checking.
 2020-02-07 16:25:42 -05:00
bunnei 9ffdef96d9 kernel: transfer_memory: Properly reserve and reset memory region. 2020-02-05 23:06:54 -05:00
Zach Hilman a0400ebc19 wait_object: Make wait behavior only require one object to signal. 
- This was holdover from citra.
 2020-02-05 23:06:53 -05:00
bunnei 900b370e13 am: Correct IPC object count mismatch. 2020-02-05 23:06:53 -05:00
bunnei 141c06ca8b services: am: Clear events on PopOutData and PopInteractiveOutData. 2020-02-05 23:06:52 -05:00
bunnei b10a96347f am: Refactor IStorage interface. 2020-02-05 23:06:52 -05:00
bunnei 0d376ae49e applets: software_keyboard: Signal state change on end of interactive session. 2020-02-05 23:06:51 -05:00
bunnei b1bd8d852a applets: software_keyboard: Minor cleanup. 2020-02-05 23:06:50 -05:00
bunnei 7bdaae11ac services: prepo: Fix IPC interface with SaveReport/SaveReportWithUser. 2020-02-05 22:52:35 -05:00
bunnei bc76fe3100 hle_ipc: Add error checking to read/write buffer access. 2020-02-05 22:52:35 -05:00
bunnei d02c1c1f75 Merge pull request #3337 from ReinUsesLisp/vulkan-staged 
yuzu: Implement Vulkan frontend
 2020-02-03 16:56:25 -05:00
bunnei 0058ae07f7 Merge pull request #3284 from CJBok/hid-fix 
hid: Fix analog sticks directional states
 2020-02-01 14:02:41 -05:00
bunnei d1df3ef078 Merge pull request #3364 from lioncash/thread 
core/arm: Remove usage of global GetCurrentThread()
 2020-01-31 11:13:24 -05:00
bunnei c4ab8cd693 Merge pull request #3363 from lioncash/unique_ptr 
kernel/physical_core: Make use of std::unique_ptr instead of std::shared_ptr
 2020-01-30 23:33:02 -05:00
bunnei 72a8ed19c3 Revert "system_archive: Fix Korean and Chinese fonts" 2020-01-30 22:02:15 -05:00
Lioncash 11c5ae60e6 core/arm: Remove usage of global GetCurrentThread() 
Now both CPU backends go through their referenced system instance to
obtain the current thread.
 2020-01-30 18:52:25 -05:00
Lioncash 371f3ecf5d kernel/physical_core: Make use of std::unique_ptr 
shared_ptr was used in 8eb175481c due to a
misunderstanding of how the language generates move constructors and
move assignment operators.

If a destructor is user-provided, then the compiler won't generate the
move constructor and move assignment operators by default--they must be
explicitly opted into.

The reason for the compilation errors is due to the fact that the
language will fall back to attempting to use the copy constructor/copy
assignment operators if the respective move constructor or move
assignment operator is unavailable.

Given that we explicitly opt into them now, the the move constructor and
move assignment operators will be generated as expected.
 2020-01-30 18:42:40 -05:00
Lioncash 6bc28ed1c8 core/cpu_manager: Remove unused includes 
Nothing from these headers are used within this source file, so we can
remove them.
 2020-01-30 18:30:57 -05:00
Lioncash 379194237d kernel/physical_core: Remove unused kernel reference member variable 
This isn't used within the class, so it can be removed to simplify the
overall interface.

While we're in the same area, we can simplify a unique_ptr reset() call.
 2020-01-30 18:29:57 -05:00
bunnei 0edc152d5a Merge pull request #3353 from FernandoS27/aries 
System: Refactor CPU Core management and move ARMInterface and Schedulers to Kernel
 2020-01-30 18:13:59 -05:00
bunnei 40a54f6de7 Merge pull request #3151 from FearlessTobi/fix-korean 
system_archive: Fix Korean and Chinese fonts
 2020-01-30 15:09:55 -05:00
ReinUsesLisp 48cb021c34 yuzu: Implement Vulkan frontend 
Adds a Qt and SDL2 frontend for Vulkan. It also finishes the missing
bits on Vulkan initialization.
 2020-01-29 17:53:11 -03:00
ReinUsesLisp 2ba5519371 settings: Add settings for graphics backend 2020-01-29 17:53:11 -03:00
ReinUsesLisp e1da845841 core: Only wait for idle on gpu_core when it was initialized 
This fixes crashes when a Vulkan device fails to initialize.
 2020-01-29 17:53:11 -03:00
Fernando Sahmkow 8eb175481c System: Address Feedback 2020-01-27 09:54:11 -04:00
Fernando Sahmkow e9b557b38e System: Correct PrepareReschedule. 2020-01-26 14:32:50 -04:00
Fernando Sahmkow 3230cfebb7 Kernel: Remove a few global instances from the kernel. 2020-01-26 14:23:46 -04:00
Fernando Sahmkow 0a5e0d4777 Core: Refactor CpuCoreManager to CpuManager and Cpu to Core Manager. 
This commit instends on better naming the new purpose of this classes.
 2020-01-26 14:07:22 -04:00
Fernando Sahmkow fb17429a0b ArmInterface: Delegate Exclusive monitor factory to exclusive monitor interfasce. 2020-01-26 10:28:23 -04:00
Fernando Sahmkow 1c2981f6da Core: Refactor CPU Management. 
This commit moves ARM Interface and Scheduler handling into the kernel.
 2020-01-25 18:55:32 -04:00
bunnei ebb840daaf bsd: Stub several more functions. 
- Required for Little Town Hero to boot further.
 2020-01-25 00:47:15 -05:00
FearlessTobi 40c05f9028 Disable clang-format for font files 2020-01-24 23:54:19 +01:00
Fernando Sahmkow a402d6e870 Kernel: Implement Physical Core. 2020-01-24 15:38:20 -04:00
bunnei 97414178cb Merge pull request #3340 from SciresM/pmdx 
loader: provide default arguments (zero byte) to NSOs
 2020-01-24 10:31:43 -05:00
fearlessTobi b2f53cceb6 Input: UDP Client to provide motion and touch controls 
An implementation of the cemuhook motion/touch protocol, this adds the
ability for users to connect several different devices to citra to send
direct motion and touch data to citra.

Co-Authored-By: jroweboy <jroweboy@gmail.com>
 2020-01-23 20:55:26 +01:00
bunnei dcd1617ee2 service: time: Implement ToPosixTimeWithMyRule. 
- Used by Pokemon Mystery Dungeon.
 2020-01-22 23:20:19 -05:00
Michael Scire 56137d471a loader: provide default arguments (zero byte) to NSOs 
Certain newer unity games (Terraria, Pokemon Mystery Dungeon) require
that the argument region be populated. Failure to do so results in
an integer underflow in argument count, and eventually an unmapped
read at 0x800000000. Providing this default fixes this.

Note that the behavior of official software is as yet unverified,
arguments-wise.
 2020-01-22 20:14:06 -08:00
bunnei c0a7b5ee4c time: Fix month off-by-one error. 
- Fixes timestamp in ZLA and Astral Chain saves.
 2020-01-20 14:20:32 -05:00
bunnei 96029f90d1 Merge pull request #3271 from bunnei/time-rewrite 
service: time: Rewrite implementation of glue services.
 2020-01-19 22:45:05 -05:00
FearlessTobi 6df85b466d system_archive: Fix Chinese font 
Adds the proper OSS font for the Chinese language.
 2020-01-19 15:09:53 +01:00
FearlessTobi 4be062de19 system_archive: Fix Korean font 
Fixes Korean fonts when using Open-source system archives.
 2020-01-19 15:09:50 +01:00
Markus Wick 4042bd107b core/memory: Create a special MapMemoryRegion for physical memory. 
This allows us to create a fastmem arena within the memory.cpp helpers.
 2020-01-18 08:38:47 +01:00
Markus Wick b18f6d19e2 core/hle: Simplify PhysicalMemory usage in vm_manager. 2020-01-18 08:29:19 +01:00
Markus Wick b8b3264c31 core/loaders: Simplify PhysicalMemory usage. 
It is currently a std::vector, however we might want to replace it with a more fancy allocator.
So we can't use the C++ iterators any more.
 2020-01-18 08:29:19 +01:00
CJBok be576083dd Moved analog direction logic to sdl_impl 2020-01-15 11:25:15 +01:00
CJBok 5af2a8b2f6 Corrected directional states sensitivity 2020-01-14 21:51:58 +01:00
Markus Wick 2049ebc50e core/kernel: Fix GetTotalPhysicalMemoryUsed. 
module._memory was already moved over to a new shared_ptr.
So code_memory_size was not increased at all.

This lowers the heap space and so saves a bit of memory, usually between 50 to 100 MB.

This fixes a regression of b8ccd49d77
 2020-01-11 14:04:44 +01:00
CJBok 57998ae780 hid: Fix analog sticks directional states 2020-01-09 02:40:55 +01:00
bunnei 9bca3fcdb0 Merge pull request #3272 from bunnei/vi-close-layer 
service: vi: Implement CloseLayer.
 2020-01-07 12:45:34 -05:00
bunnei 5cefb60748 Merge pull request #3261 from degasus/page_table 
core/memory + arm/dynarmic: Use a global offset within our arm page table.
 2020-01-06 11:56:59 -05:00
bunnei 62d4e927d4 Merge pull request #3257 from degasus/no_busy_loops 
video_core: Block in WaitFence.
 2020-01-06 00:09:57 -05:00
bunnei 0eaf2e8672 Merge pull request #2945 from FernandoS27/fix-bcat 
nifm: Only return that there's an internet connection when there's a BCATServer
 2020-01-05 02:17:16 -05:00
bunnei 18e502d636 service: time: Implement GetStandardLocalSystemClock. 2020-01-04 22:18:54 -05:00
bunnei 940ed35ee2 time: Remove overflow error checking (currently breaks ADO builds). 2020-01-04 13:48:31 -05:00
bunnei 2fef8d9feb service: time: Implement GetClockSnapshotFromSystemClockContext. 2020-01-04 13:48:30 -05:00
bunnei 0d1c9fe2a9 service: time: Implement IsStandardNetworkSystemClockAccuracySufficient. 2020-01-04 13:48:30 -05:00
bunnei 756c19b448 system_archive: Add a basic HLE implementation for time zone binary. 2020-01-04 13:48:29 -05:00
bunnei ac22daaf4f service: time: Rewrite implementation of glue services. 2020-01-04 13:48:29 -05:00
bunnei 9431286523 core: Initialize several structs that make use of Common::UUID. 2020-01-04 13:29:55 -05:00
bunnei cbaf3b3c40 service: vi: Implement CloseLayer. 
- Needed for Undertale.
 2020-01-04 00:45:06 -05:00
bunnei 5b2b762ec9 Merge pull request #3247 from FernandoS27/remap-fix 
NvServices: Correct Ioctl Remap.
 2020-01-03 12:30:56 -05:00
ReinUsesLisp 9328c4be0b yuzu: Remove Maxwell debugger 
This was carried from Citra and wasn't really used on yuzu. It also adds
some runtime overhead. This commit removes it from yuzu's codebase.
 2020-01-02 23:09:44 -03:00
Markus Wick f74d95547e core/memory + arm/dynarmic: Use a global offset within our arm page table. 
This saves us two x64 instructions per load/store instruction.

TODO: Clean up our memory code. We can use this optimization here as well.
 2020-01-01 12:24:54 +01:00
Markus Wick 4bdaebe33e video_core: Block in WaitFence. 
This function is called rarely and blocks quite often for a long time.
So don't waste power and let the CPU sleep.

This might also increase the performance as the other cores might be allowed to clock higher.
 2019-12-30 13:04:53 +01:00
Fernando Sahmkow 367257a258 NvServices: Correct Ioctl Remap. 
This commit corrects a padding value in Ioctl Remap that was actually an 
offset to the mapping address.
 2019-12-25 14:37:28 -04:00
bunnei 84efe33017 Merge pull request #3214 from lioncash/svc-func 
kernel/svc: Amend function signature of SignalProcessWideKey
 2019-12-12 21:32:36 -05:00
Fernando Sahmkow 48dcf4c2d8 Kernel: Correct behavior of Address Arbiter threads. (#3165) 
* Kernel: Correct behavior of Address Arbiter threads.

This corrects arbitration threads to behave just like in Horizon OS.
They are added into a container and released according to what priority
they had when added. Horizon OS does not reorder them if their priority
changes.

* Kernel: Address Feedback.
 2019-12-11 10:55:38 -05:00
Lioncash 9e160743ac kernel/svc: Correct function signature of SignalProcessWideKey 
This function doesn't actually return a result code, so we can amend the
signature of it to match.
 2019-12-11 07:13:27 -05:00
bunnei bb3d5c700b Merge pull request #3201 from lioncash/dump 
kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNew
 2019-12-10 21:48:37 -05:00
Lioncash 7953f7b0d8 kernel: Remove unnecessary includes 
Over the course of the changes to the kernel code, a few includes are no
longer necessary, particularly with the change over to std::shared_ptr
from Boost's intrusive_ptr.
 2019-12-07 22:37:05 -05:00
Lioncash 28ac8d63ef kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNew 
These are fairly trivial to implement, we can just do nothing. This also
provides a spot for us to potentially dump out any relevant info in the
future (e.g. for debugging purposes with homebrew, etc).

While we're at it, we can also correct the names of both of these
supervisor calls.
 2019-12-07 22:01:17 -05:00
Fernando Sahmkow 2624ac7ae8 CpuCore: Clear exclusive state after doing a run in dynarmic. 
This commit corrects an error in which a Core could remain with an
exclusive state after running, leaving space for possible race
conditions between changing cores.
 2019-12-05 18:08:59 -04:00
ReinUsesLisp bcf24c9ed8 telemetry_session: Report renderer backend 
We only have OpenGL as an option for now. Hardcode the entry.
 2019-12-02 16:50:39 -03:00
ReinUsesLisp 3c521afbec telemetry_session: Use temporary to avoid writing the same enum 2019-12-02 16:49:46 -03:00
bunnei 4a4516868c kernel: Implement a more accurate IPC dispatch. 2019-11-28 12:01:53 -05:00
bunnei ec9f949bc8 Merge pull request #3169 from lioncash/memory 
core/memory: Deglobalize memory management code
 2019-11-28 11:43:17 -05:00
bunnei 5a1be49f6e Merge pull request #3171 from lioncash/internal-link 
filesys/romfs: Make ProcessFile and ProcessDirectory internally linked
 2019-11-28 01:18:10 -05:00
Morph 2b0823df12 patch_manager: Adds check for disabled cheats to prevent them from being enabled (#3178) 
* Adds check for disabled cheats to prevent them from being added to the CheatList

* Address feedback
 2019-11-28 01:17:17 -05:00
bunnei 43a6681a59 Merge pull request #3170 from lioncash/enum 
file_sys/directory: Make EntryType an enum class
 2019-11-27 23:23:01 -05:00
Lioncash 0da88a9876 filesys/romfs: Remove unused includes 
These inclusions aren't used at all within the public interface, so they
can be removed.
 2019-11-27 05:29:52 -05:00
Lioncash eada47f40f filesys/romfs: Make ProcessFile and ProcessDirectory internally linked 
These functions aren't used outside of this file, so we can place them
within an anonymous namespace.
 2019-11-27 05:26:35 -05:00
Lioncash a56ce41cc2 file_sys/directory: Make EntryType an enum class 
This can trivially be an enum class rather than a regular enum, making
it more strongly typed.
 2019-11-27 05:11:02 -05:00
Lioncash 50906bcf42 core/memory; Migrate over SetCurrentPageTable() to the Memory class 
Now that literally every other API function is converted over to the
Memory class, we can just move the file-local page table into the Memory
implementation class, finally getting rid of global state within the
memory code.
 2019-11-26 21:55:39 -05:00
Lioncash d03fbad80f core/memory: Migrate over GetPointerFromVMA() to the Memory class 
Now that everything else is migrated over, this is essentially just code
relocation and conversion of a global accessor to the class member
variable.

All that remains is to migrate over the page table.
 2019-11-26 21:55:39 -05:00
Lioncash b5f69f4cc9 core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory class 
The Write functions are used slightly less than the Read functions,
which make these a bit nicer to move over.

The only adjustments we really need to make here are to Dynarmic's
exclusive monitor instance. We need to keep a reference to the currently
active memory instance to perform exclusive read/write operations.
 2019-11-26 21:55:39 -05:00
Lioncash cc3d6fdf73 core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory class 
With all of the trivial parts of the memory interface moved over, we can
get right into moving over the bits that are used.

Note that this does require the use of GetInstance from the global
system instance to be used within hle_ipc.cpp and the gdbstub. This is
fine for the time being, as they both already rely on the global system
instance in other functions. These will be removed in a change directed
at both of these respectively.

For now, it's sufficient, as it still accomplishes the goal of
de-globalizing the memory code.
 2019-11-26 21:55:39 -05:00
Lioncash 9e3cbf71fc core/memory: Migrate over ZeroBlock() and CopyBlock() to the Memory class 
These currently aren't used anywhere in the codebase, so these are very
trivial to move over to the Memory class.
 2019-11-26 21:55:38 -05:00
Lioncash ad85ba53dd core/memory: Migrate over RasterizerMarkRegionCached() to the Memory class 
This is only used within the accelerated rasterizer in two places, so
this is also a very trivial migration.
 2019-11-26 21:55:38 -05:00
Lioncash 8d306269d0 core/memory: Migrate over ReadCString() to the Memory class 
This only had one usage spot, so this is fairly straightforward to
convert over.
 2019-11-26 21:55:38 -05:00
Lioncash 7110e6a128 core/memory: Migrate over GetPointer() 
With all of the interfaces ready for migration, it's trivial to migrate
over GetPointer().
 2019-11-26 21:55:38 -05:00
Lioncash e04aeb9531 core: Prepare various classes for memory read/write migration 
Amends a few interfaces to be able to handle the migration over to the
new Memory class by passing the class by reference as a function
parameter where necessary.

Notably, within the filesystem services, this eliminates two ReadBlock()
calls by using the helper functions of HLERequestContext to do that for
us.
 2019-11-26 21:55:37 -05:00
Lioncash 717e2d5b94 core/memory: Move memory read/write implementation functions into an anonymous namespace 
These will eventually be migrated into the main Memory class, but for
now, we put them in an anonymous namespace, so that the other functions
that use them, can be migrated over separately.
 2019-11-26 21:53:35 -05:00
Lioncash 811191a9c9 core/memory: Migrate over address checking functions to the new Memory class 
A fairly straightforward migration. These member functions can just be
mostly moved verbatim with minor changes. We already have the necessary
plumbing in places that they're used.

IsKernelVirtualAddress() can remain a non-member function, since it
doesn't rely on class state in any form.
 2019-11-26 21:53:34 -05:00
Lioncash 1d9be65e26 core/memory: Migrate over memory mapping functions to the new Memory class 
Migrates all of the direct mapping facilities over to the new memory
class. In the process, this also obsoletes the need for memory_setup.h,
so we can remove it entirely from the project.
 2019-11-26 21:53:34 -05:00
Lioncash ff443fa835 core/memory: Introduce skeleton of Memory class 
Currently, the main memory management code is one of the remaining
places where we have global state. The next series of changes will aim
to rectify this.

This change simply introduces the main skeleton of the class that will
contain all the necessary state.
 2019-11-26 21:53:34 -05:00
bunnei 8b35acbd29 core_timing: Use better reference tracking for EventType. (#3159) 
* core_timing: Use better reference tracking for EventType.

- Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects.
- Removes need for unique names - we won't be using this for save states anyways.
 2019-11-26 21:48:56 -05:00
bunnei 9a3cd7ccb8 kernel: Fix reference management for client/server session. 
- Fixes shutdown crash and crash in Pokemon SwSh.
 2019-11-25 18:17:49 -05:00
bunnei e8dd602a77 Merge pull request #3094 from lioncash/tables 
service: Update function tables
 2019-11-24 20:30:58 -05:00
bunnei 5cb0f276fe kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154) 
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects.

- See https://github.com/citra-emu/citra/pull/4710 for details.
 2019-11-24 20:15:51 -05:00
bunnei bde851fca2 Update svc.cpp 2019-11-23 16:01:06 -05:00
bunnei 5d381af66b svc: GetSystemTick should return cntpct_el0, not core ticks. 2019-11-23 15:29:15 -05:00
bunnei 16a9d0d6e0 Merge pull request #3114 from FernandoS27/cond-var 
Kernel: Correct behavior of Condition Variables to be more similar to real hardware.
 2019-11-23 13:24:39 -05:00
bunnei fd53e0bd02 Merge pull request #3130 from FernandoS27/cancel-sync 
Kernel: Correct Cancel Synchronization.
 2019-11-23 13:23:23 -05:00
bunnei 1c991441c2 Merge pull request #3112 from lioncash/skip 
service/am: Remove unnecessary Skip calls
 2019-11-21 15:30:01 -05:00
bunnei b96fcfc160 Merge pull request #3111 from lioncash/query 
am: Stub QueryApplicationPlayStatistics
 2019-11-21 15:29:34 -05:00
Fernando Sahmkow eb03767206 Kernel: Optimize condition variable threads management. 2019-11-21 11:13:29 -04:00
Fernando Sahmkow eef3236ecd Kernel: Correct SignalProcessWideKey 
When the target is 0, all threads must be processed.
 2019-11-21 10:46:55 -04:00
Fernando Sahmkow b021fa33b9 Kernel: Correct behavior of Condition Variables to be more similar to real hardware. 
This commit ensures cond var threads act exactly as they do in the real
console. The original implementation uses an RBTree and the behavior of
cond var threads is that at the same priority level they act like a
FIFO.
 2019-11-21 10:46:55 -04:00
Fernando Sahmkow 323a0e17e7 Kernel: Correct Cancel Synchronization. 
This commit corrects the behavior of cancel synchronization when the
thread is running/ready and ensures the next wait is cancelled as it's
suppose to.
 2019-11-16 12:41:51 -04:00
bunnei 5897348571 Merge pull request #3091 from lioncash/core-conversion 
core: Make most implicit type conversion warnings errors on MSVC
 2019-11-15 12:08:50 -05:00
Lioncash 869878ac8d service/am: Remove unnecessary Skip calls 
We can simplify these by wrapping the necessary members in structs and
then simply reading out the whole struct.
 2019-11-14 16:31:52 -05:00
Lioncash 27611874d6 am: Stub QueryApplicationPlayStatistics 
Maintains implementation parity between QueryApplicationPlayStatistics
and QueryApplicationPlayStatisticsByUid.

These function the same behaviorally underneath the hood, with the only
difference being that one allows specifying a UID.
 2019-11-14 16:02:39 -05:00
bunnei eacdeca1b0 Merge pull request #3089 from SciresM/play_statistics 
Implement stub for IApplicationFunctions::QueryApplicationPlayStatisticsByUid
 2019-11-14 13:54:29 -05:00
bunnei 9364f4d30c Merge pull request #3093 from lioncash/mbedtls 
core: Migrate off deprecated mbedtls functions
 2019-11-14 13:47:23 -05:00
bunnei 08ad78fa7e Merge pull request #3092 from lioncash/util 
key_manager: Make use of IOFile in WriteKeyToFile()
 2019-11-14 13:46:55 -05:00
Lioncash fd6e676326 xts_archive: Remove redundant std::string constructor 
We can just call the .data() member of path instead of constructing a
completely new string.
 2019-11-13 10:02:10 -05:00
Lioncash 0ab5dd8c7f service: Update function tables 
Keeps the function tables up to date.

Updated based off information from Switchbrew.
 2019-11-12 10:32:56 -05:00
Lioncash c6b2fd7415 key_manager: Make use of IOFile in WriteKeyToFile() 
This properly handles unicode-based paths on Windows, while opening a
raw stream doesn't out-of-the-box.

Prevents file creation from potentially failing on Windows PCs that make
use of unicode characters in their save paths (e.g. writing to a user's
AppData folder, where the user has a name with non-ASCII characters).
 2019-11-12 08:52:18 -05:00
Lioncash 4c6cd8b9e8 core: Migrate off deprecated mbedtls functions 
These functions are marked for deprecation and it's recommended that the
*_ret variants be used instead.
 2019-11-12 08:45:56 -05:00
Lioncash 0092723959 externals: Update httplib 
Since the introduction of this library, numerous improvements have been
made. Notably, many of the warnings we would get by simply including the
library header have now been fixed. This makes it much easier to make
conversion warning an error.
 2019-11-12 08:31:27 -05:00
Lioncash 20d6637c03 service: Resolve sign conversion errors 
These are fairly trivial to resolve and most of the changes entail
using RESULT_UNKNOWN over ResultCode(-1).
 2019-11-12 07:55:39 -05:00
Lioncash 6fb1953e6c perf_stats: Resolve implicit int to double conversion error 
We simply need to turn the literal argument to std::accumulate into a
double, rather than an int.
 2019-11-12 07:55:39 -05:00
Lioncash 93dd86b390 loader; Resolve sign conversion/truncation errors 2019-11-12 07:55:39 -05:00
Lioncash f1d916de5e gdbstub: Resolve sign conversion errors 2019-11-12 07:55:39 -05:00
Lioncash 63a3b54c1f kernel: Resolve sign conversion warnings 
Uncovered a bug within Thread's SetCoreAndAffinityMask() where an
unsigned variable (ideal_core) was being compared against "< 0", which
would always be a false condition.

We can also get rid of an unused function (GetNextProcessorId) which contained a sign
mismatch warning.
 2019-11-12 07:55:39 -05:00
Lioncash e7f1a6b096 file_sys: Resolve sign conversion warnings 
Resolves a few trivial sign conversion/mismatch errors.
 2019-11-12 07:55:39 -05:00
Lioncash 34bb09d7be result: Add default error code for the ResultCode(-1) case 
Will be used to reduce the overall duplication of the same magic value
all over the codebase in following changes.
 2019-11-12 07:55:38 -05:00
Lioncash 5a0d4d4234 crypto: Resolve sign-conversion warnings 2019-11-12 07:55:22 -05:00
Lioncash 53b3dea718 result: Resolve sign-coversion warnings 
The constructor was implicitly using signed->unsigned conversions to
produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX.
 2019-11-12 07:06:48 -05:00
Lioncash 7b79c025c2 arm_unicorn: Resolve sign conversion warnings 
While we're at it, this also resolves a type truncation warning as well,
given the code was truncating from a 64-bit value to a 32-bit one.
 2019-11-12 07:06:48 -05:00
Lioncash 63be9f7f60 CMakeLists: Make most implicit type conversion warnings errors on MSVC 
Quite frequently there have been cases where code has been merged into
the core that produces warning. In order to prevent this from occurring,
we can make the compiler flag these cases and allow our CI to flag down
any code that would generate these warnings.

This is beneficial given silent conversions from signed/unsigned can
result in logic bugs. This forces one writing changes to be explicit
about when signedness conversions are desirable, rather than leaving it
up to readers' interpretation.

Currently the codebase isn't in a state where it will build successfully
with this change applied, but this will be addressed in subsequent
follow-up changes. This set of changes will focus on making it build
properly with these changes for MSVC as a starting point for basic
coverage.
 2019-11-12 07:06:25 -05:00
Michael Scire f0cea0cb13 Implement stub for QueryApplicationPlayStatisticsByUid 2019-11-11 07:32:47 -08:00
Fernando Sahmkow 28b227fe12 nifm: Only return that there's an internet connection when there's a BCATServer 
This helps games that need internet for other purposes boot as the rest
of our internet infrastructure is incomplete.
 2019-11-06 23:10:32 -05:00
bunnei 629cecbad6 Merge pull request #3062 from bunnei/event-improve 
kernel: Improve events
 2019-11-06 10:05:50 -05:00
David 692023754d Merge pull request #2859 from Morph1984/hid 
hid: Stub SetNpadJoyAssignmentModeSingle and GetNpadHandheldActivationMode
 2019-11-06 12:48:07 +11:00
bunnei fe02b9f968 common_func: Use std::array for INSERT_PADDING_* macros. 
- Zero initialization here is useful for determinism.
 2019-11-03 22:22:41 -05:00
bunnei cff4a946ab kernel: readable_event: Signal only once. 2019-11-03 04:25:41 -05:00
bunnei eeef564c02 kernel: events: Remove ResetType::Automatic. 
- This does not actually seem to exist in the real kernel - games reset these automatically.

# Conflicts:
#	src/core/hle/service/am/applets/applets.cpp
#	src/core/hle/service/filesystem/fsp_srv.cpp
 2019-11-03 04:22:45 -05:00
bunnei 02a4c4c481 kernel: readable_event: Initialize members. 2019-11-03 04:18:39 -05:00
FearlessTobi f60d43ef45 core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibility 
These commands require Screenshots to be implemented anyway, so they are safe to stub for now.
 2019-11-03 07:37:38 +01:00
Rodrigo Locatti 1d717369d1 Merge pull request #3038 from lioncash/docs 
kernel/scheduler: Minor changes
 2019-10-30 03:47:28 +00:00
bunnei 43540a622f Merge pull request #3007 from DarkLordZach/fsc-regress 
savedata_factory: Automatically create certain savedata
 2019-10-29 22:05:09 -04:00
Lioncash 33df906815 scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as const 
This is only compared against, so it can be made const.
 2019-10-27 23:35:50 -04:00
Lioncash 0ae1dedad7 scheduler: Silence sign conversion warnings 2019-10-27 22:44:52 -04:00
Lioncash 3dbc651296 scheduler: Initialize class members directly where applicable 
Reduces the overall amount of code.
 2019-10-27 22:13:55 -04:00
Lioncash 34e9a6ea64 scheduler: Amend documentation comments 
Adjusts the formatting of a few of the comments an ensures they get
recognized as proper Doxygen comments.
 2019-10-27 22:12:32 -04:00
David 86521bca3b Merge pull request #2971 from FernandoS27/new-scheduler-v2 
Kernel: Implement a New Thread Scheduler V2
 2019-10-28 10:53:27 +11:00
bunnei 7939e69b9b Merge pull request #2991 from lioncash/npad 
hid/npad: Minor cleanup
 2019-10-22 19:51:24 -04:00
Zach Hilman d5f1f99d99 savedata_factory: Automatically create certain savedata 
After further hardware investigation, it appears that some games, perhaps those more lazily coded, will not call EnsureSaveData, meaning that they expect the normal (current) save to be automatically made. Additionally, some games do not create a cache or temporary save before use.
In these 3 specific instances, the save is created automatically for the game if it doesn't exist.
 2019-10-22 15:47:38 -04:00
bunnei 2b9c7a7dfe core: Fix clang-format errors. 2019-10-19 14:47:18 -04:00
Nicolae-Andrei Cociorba 47765b4d61 Fix null pointer deref. 2019-10-18 14:12:12 +00:00
bunnei 09de1362b5 Merge pull request #2992 from lioncash/dmnt 
dmnt_cheat_vm: Correct register Restore and ClearRegs behavior
 2019-10-17 19:52:24 -04:00
Lioncash 4a7d680a7f dmnt_cheat_vm: Correct register Restore and ClearRegs behavior 
Previously these were performing the same behavior as the Save and
ClearSaved opcode types.
 2019-10-17 18:49:39 -04:00
Rodrigo Locatti 1e1aa4ad21 Merge pull request #2989 from lioncash/apm 
service/apm/controller: Minor interface changes
 2019-10-17 19:20:14 -03:00
Lioncash 1733d2604c hid/npad: Fix incorrect connection boolean value in ConnectAllDisconnectedControllers() 
We should be setting the connection state to true, otherwise we aren't
actually making the controllers connected like the function name
indicates.
 2019-10-17 18:19:47 -04:00
Lioncash 29fddba52e hid/npad: Add missing break in default case 
While not an issue, it does prevent fallthrough from occurring if
anything is ever added after this case (unlikely to occur, but this
turns a trivial "should not cause issues" into a definite "won't cause
issues).
 2019-10-17 18:17:42 -04:00
Lioncash 060b33cfbe hid/npad: Replace std::for_each with ranged for loops 
Performs the same behavior, but is built into the core language itself.

No functional change.
 2019-10-17 18:16:36 -04:00
Lioncash 22e917cd8e hid/npad: Remove redundant non-const variant of IsControllerSupported() 
The const qualified variant can also be called in non-const contexts, so
we can remove the non-const variant to eliminate a bit of code
duplication.
 2019-10-17 18:11:41 -04:00
Lioncash 98b277dfae hid/npad: Move function declarations 
Clearly separate these from the variable declarations to make them more
visible.
 2019-10-17 18:09:08 -04:00
Lioncash 7c4a4b4fc1 core/core: Resolve -Wreorder warnings 
Amends the initializer lists to be ordered in the same manner that
they're declared within the class.
 2019-10-17 17:51:06 -04:00
Lioncash 2b7f82e089 core/memory/cheat_engine: Resolve -Wreorder warnings 
Amends the initializer lists to be ordered in the same manner that
they're declared within the class.
 2019-10-17 16:21:47 -04:00
Lioncash 76157b0b04 apm/controller: Make SetPerformanceConfiguration() use an array of pairs over a map 
While a map is an OK way to do lookups (and usually recommended in most
cases), this is a map that lives for the entire duration of the program
and only deallocates its contents when the program terminates.

Given the total size of the map is quite small, we can simply use a
std::array of pairs and utilize std::find_if to perform the same
behavior without loss of performance.

This eliminates a static constructor and places the data into the
read-only segment.

While we're at it, we can also handle malformed inputs instead of
directly dereferencing the resulting iterator.
 2019-10-17 16:13:14 -04:00
Lioncash 756203599e apm/controller: Make GetCurrentPerformanceMode() a const member function 
This doesn't modify instance state, so it can be made const qualified.
 2019-10-17 15:58:25 -04:00
bunnei 9e3c8681ce Merge pull request #2912 from FernandoS27/async-fixes 
General fixes to Async GPU
 2019-10-16 10:34:48 -04:00
bunnei 7f9086c4c6 Merge pull request #2972 from lioncash/system 
{bcat, gpu, nvflinger}: Remove trivial usages of the global system accessor
 2019-10-15 17:49:12 -04:00
Lioncash 3d91f45a30 bcat: Remove use of global system accessors 
Removes all uses of the global system accessor within the BCAT
interface.
 2019-10-15 16:39:27 -04:00
Fernando Sahmkow 4f8fa2dd29 Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE. 2019-10-15 11:55:30 -04:00
Fernando Sahmkow 3300a7631d Kernel: Address Feedback 2 2019-10-15 11:55:28 -04:00
Fernando Sahmkow 5acd086b18 Kernel: Clang Format 2019-10-15 11:55:27 -04:00
Fernando Sahmkow ac9dd91f1e Kernel: Reverse global accessor removal. 2019-10-15 11:55:26 -04:00
Fernando Sahmkow a88238d68d Kernel: Address Feedback. 2019-10-15 11:55:25 -04:00
Fernando Sahmkow 17b53b4a54 Kernel Scheduler: Make sure the global scheduler shutdowns correctly. 2019-10-15 11:55:24 -04:00
Fernando Sahmkow 0d57b899dd Kernel_Thread: Eliminate most global accessors. 2019-10-15 11:55:23 -04:00
Fernando Sahmkow 59b89b1dd5 KernelSVC: Assert that condition variable address is aligned to 4 bytes. 2019-10-15 11:55:22 -04:00
Fernando Sahmkow 8363d07df8 Kernel: Correct Paused scheduling 2019-10-15 11:55:21 -04:00
Fernando Sahmkow 3da21e4b4f Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel. 2019-10-15 11:55:20 -04:00
Fernando Sahmkow 248795db6e Kernel: Correct redundant yields to only advance time forward. 2019-10-15 11:55:20 -04:00
Fernando Sahmkow a24c331b84 Kernel: Corrections to ModifyByWaitingCountAndSignalToAddressIfEqual 2019-10-15 11:55:19 -04:00
Fernando Sahmkow 598203b5cf Kernel: Correct Results in Condition Variables and Mutexes 2019-10-15 11:55:18 -04:00
Fernando Sahmkow 3c9e26a003 Kernel: Clang Format 2019-10-15 11:55:17 -04:00
Fernando Sahmkow abc8856e2c Kernel: Remove global system accessor from WaitObject 2019-10-15 11:55:16 -04:00
Fernando Sahmkow 7d04b271a6 Scheduler: Implement Yield Count and Core migration on Thread Preemption. 2019-10-15 11:55:16 -04:00
Fernando Sahmkow f2989c81d9 Scheduler: Corrections to YieldAndBalanceLoad and Yield bombing protection. 2019-10-15 11:55:15 -04:00
Fernando Sahmkow 68325300ae Kernel: Initial implementation of thread preemption. 2019-10-15 11:55:14 -04:00
Fernando Sahmkow acdce3b4df Scheduler: Add protections for Yield bombing 
In case of redundant yields, the scheduler will now idle the core for 
it's timeslice, in order to avoid continuously yielding the same thing 
over and over.
 2019-10-15 11:55:13 -04:00
Fernando Sahmkow 5130168171 Kernel: Style and Corrections 2019-10-15 11:55:12 -04:00
Fernando Sahmkow 87334f0f16 Correct PrepareReschedule 2019-10-15 11:55:12 -04:00
Fernando Sahmkow 655ed87f53 Comment and reorganize the scheduler 2019-10-15 11:55:11 -04:00
Fernando Sahmkow 891babbe20 Add PrepareReschedule where required. 2019-10-15 11:55:10 -04:00
Fernando Sahmkow 4760c27922 Correct compiling errors and addapt to the new interface. 2019-10-15 11:55:09 -04:00
Fernando Sahmkow bddf90701b Correct Supervisor Calls to work with the new scheduler, 2019-10-15 11:55:08 -04:00
Fernando Sahmkow 3905bb3e7b Redesign CPU Cores to work with the new scheduler 2019-10-15 11:55:07 -04:00
Fernando Sahmkow 07524b63e8 Add interfacing to the Global Scheduler 2019-10-15 11:55:07 -04:00
Fernando Sahmkow 18c796ab58 Addapt thread class to the new Scheduler 2019-10-15 11:55:06 -04:00
Fernando Sahmkow 7a10ae0128 Implement a new Core Scheduler 2019-10-15 11:55:04 -04:00
bunnei e3d6f4e087 Merge pull request #2965 from FernandoS27/fair-core-timing 
Core Timing: Rework Core Timing to run all cores evenly.
 2019-10-15 11:48:30 -04:00
bunnei 09223fe372 Merge pull request #2897 from DarkLordZach/oss-ext-fonts-1 
pl_u: Move open source font archives and fix NAND error
 2019-10-14 15:13:41 -04:00
bunnei d3f4d79642 Merge pull request #2930 from DarkLordZach/gamecard-partitions 
file_sys: Add code to access raw gamecard partitions and lazily load them
 2019-10-14 10:29:10 -04:00
Zach Hilman fd66788be4 card_image: Implement system update commands in XCI 2019-10-13 14:18:45 -04:00
Zach Hilman 8d904c20be pl_u: Fix mismatched rebase size error in font encryption 2019-10-13 13:46:27 -04:00
Zach Hilman 1dcc71fc9c pl_u: Use kernel physical memory 2019-10-13 13:46:27 -04:00
Zach Hilman 45cdc92252 pl_u: Remove excess static qualifier 2019-10-13 13:46:27 -04:00
Zach Hilman d37be63099 pl_u: Use OSS system archives if real archives don't exist 2019-10-13 13:46:27 -04:00
Zach Hilman 612b086bd4 system_archive: Synthesize shared fonts system archives 2019-10-13 13:46:10 -04:00
Zach Hilman cd8c6a4afd externals: Move OSS font data to file_sys in core 2019-10-13 13:46:10 -04:00
Lioncash b546e106d1 nvflinger/buffer_queue: Remove use of a global system accessor 2019-10-12 09:17:56 -04:00
Fernando Sahmkow b7d07d5a73 Core_Timing: Address Remaining feedback. 2019-10-12 07:26:38 -04:00
Fernando Sahmkow 97669469d0 Core_Timing: Address Feedback and suppress warnings. 2019-10-11 14:44:14 -04:00
Fernando Sahmkow f2f4a797ee Core Timing: Correct Idle and remove lefting pragma 2019-10-09 12:30:33 -04:00
Fernando Sahmkow e96ac0e2a3 Core Timing: General corrections and added tests. 2019-10-09 12:30:33 -04:00
Fernando Sahmkow 93a18da674 Core Timing: Rework Core Timing to run all cores evenly. 2019-10-09 12:30:31 -04:00
bunnei f9b784f1a6 Merge pull request #2921 from FreddyFunk/compiler-warnings-core 
Services::ES fix casting warnings
 2019-10-09 10:34:48 -04:00
bunnei 9680991009 Merge pull request #2654 from DarkLordZach/lm-log-rewrite 
lm: Rewrite logger to use core reporting services
 2019-10-08 20:23:13 -04:00
Morph bebe0ff470 hid: Implement DeactivateNpad 
Makes use of the already existing DeactivateController function.
 2019-10-07 04:44:09 -07:00
Morph 33b8716668 hid: Stub SetNpadJoyAssignmentModeSingle and reorganize service commands 2019-10-07 04:43:34 -07:00
Zach Hilman fa828a828f Merge pull request #2951 from lioncash/global 
core: Remove Core::CurrentProcess()
 2019-10-06 20:47:48 -04:00
Lioncash 3685b588d0 bcat/module: Silence truncation warnings 
We need to perform explicit casts here, otherwise we're implicitly
truncating a 64-bit type to a 32-bit one.
 2019-10-06 15:38:12 -04:00
Lioncash bf17041e33 bcat: Take std::function instance by value in NullBackend's constructor 
Without this, the std::move within the constructor initializer list
won't be able to actually perform a move.
 2019-10-06 15:38:12 -04:00
Lioncash ca16eb6b49 bcat: In-class initialize ProgressServiceBackend's impl member 
Allows us to remove a constructor initializer list.
 2019-10-06 15:38:12 -04:00
Lioncash 8d1a3e2fab bcat: Make ProgressServiceBackend's constructor take a std::string_view 
Given the string is appended to another, we can make it a view so a
redundant full copy of the string isn't made.
 2019-10-06 15:38:09 -04:00
Lioncash 2269566f26 bcat: Make ProgressServiceBackend's GetEvent() const 
This member function doesn't modify internal member state, so it can be
marked const.
 2019-10-06 14:03:18 -04:00
Lioncash 0cab8c117d boxcat: Silence an unused variable warning 
On parse errors, we can log out the explanatory string indicating what
the parsing error was, rather than just ignoring the variable and
returning an overly broad error code.
 2019-10-06 14:00:32 -04:00
Lioncash 8e9649b547 core/core: Remove unused header 
This isn't used anywhere in either the cpp or header file.
 2019-10-06 13:54:27 -04:00
Lioncash 922799f1d5 core: Remove Core::CurrentProcess() 
This only encourages the use of the global system instance (which will
be phased out long-term). Instead, we use the direct system function
call directly to remove the appealing but discouraged short-hand.
 2019-10-06 13:53:12 -04:00
Lioncash e4e4af80e8 hle/service: Replace global system instance calls with instance-based ones 
Migrates the HLE service code off the use of directly accessing the
global system instance where trivially able to do so.

This removes all usages of Core::CurrentProcess from the service code,
only 8 occurrences of this function exist elsewhere. There's still quite
a bit of "System::GetInstance()" being used, however this was able to
replace a few instances.
 2019-10-06 13:42:23 -04:00
Fernando Sahmkow 5a98b5a19f NvFlinger: Remove leftover from corrections and clang format. 2019-10-04 19:59:54 -04:00
Fernando Sahmkow ded3d555e1 Core: Wait for GPU to be idle before shutting down. 2019-10-04 19:59:53 -04:00
Fernando Sahmkow 87f41384a8 Nvdrv: Correct Event setup in Nvdrv 
Events are supposed to be cleared on quering. This fixes that issue.
 2019-10-04 19:59:52 -04:00
Fernando Sahmkow 3897935493 NVFlinger: Reverse the change that only signaled events on buffer acquire. 
This has been hardware tested and it seems that NVFlinger will still 
signal even if there are no buffers to present.
 2019-10-04 19:59:51 -04:00
Fernando Sahmkow d9b035cc31 Nvdrv: Do framelimiting only in the CPU Thread 2019-10-04 19:59:50 -04:00
Fernando Sahmkow 13d4774389 NvFlinger: Don't swap buffers if a frame is missing and always trigger event in sync gpu. 2019-10-04 19:59:49 -04:00
Fernando Sahmkow 1df31e4b65 GPU_Async: Correct fences, display events and more. 
This commit uses guest fences on vSync event instead of an articial fake 
fence we had.
It also corrects to keep signaling display events while loading the game 
as the OS is suppose to send buffers to vSync during that time.
 2019-10-04 19:59:48 -04:00
Fernando Sahmkow a248bd1c3e Nvdrv: Correct Async regression and avoid signaling empty buffer vsyncs 2019-10-04 19:59:47 -04:00
ReinUsesLisp 20c476154f audio/audout_u: Change formatting for old clang-format versions 2019-10-04 23:51:56 +00:00
ReinUsesLisp ac7d5ab87f service/nvdrv: Silence -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp 88f3837483 service/nfp: Silence -Wunused and -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp 271d159f41 service/hid: Silence -Wunused and -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp 6fcae076c6 service/am: Silence -Wreorder 2019-10-04 23:41:21 +00:00
ReinUsesLisp d6d8c7a19b service/hid: Remove unused system reference 2019-10-04 23:41:21 +00:00
ReinUsesLisp a0856d1280 service/friend: Remove unused field 2019-10-04 23:41:21 +00:00
ReinUsesLisp bd6ddbd3db service/filesystem: Silence -Wunused-variable 2019-10-04 23:41:21 +00:00
ReinUsesLisp deb7a968f6 service/bcat: Silence -Wreorder and -Wunused 2019-10-04 23:41:21 +00:00
ReinUsesLisp 55ef6342ab service/audio: Silence -Wunused 2019-10-04 23:28:34 +00:00
ReinUsesLisp e259e123da service/apm: Silence -Wunused and -Wreorder 2019-10-04 23:28:34 +00:00
bunnei f36ff3bea2 Merge pull request #2936 from VPeruS/use-isallzeroarray 
[crypto] Use IsAllZeroArray helper function
 2019-10-04 15:44:35 -04:00
David e2547d51c6 Merge pull request #2539 from DarkLordZach/bcat 
bcat: Implement BCAT service and connect to yuzu Boxcat server
 2019-10-03 19:06:13 +10:00
vperus 1625fd5a18 [crypto] Use IsAllZeroArray helper function 2019-10-02 19:20:45 +03:00
Zach Hilman a012cf713d qt: Add service dialog 2019-10-02 08:35:43 -04:00
Zach Hilman fc31d50e65 boxcat: Use updated game-asset API URL and tags 2019-10-01 09:13:31 -04:00
Zach Hilman d4de82fcdb bcat: Add FSC accessors for BCAT data 
Ports BCAT to use FSC interface
 2019-10-01 09:13:09 -04:00
Zach Hilman 361dcf2d3a boxcat: Implement events global field 2019-09-30 17:28:23 -04:00
Zach Hilman 098f7e89fd bcat: Implement DeliveryCacheProgressImpl structure 
Huge thanks to lioncash for re-ing this for me.
 2019-09-30 17:27:23 -04:00
Zach Hilman 9f3dfba950 boxcat: Use Etag header names for file digest 2019-09-30 17:27:23 -04:00
Zach Hilman 4071f8fe3b boxcat: Add downloading and client for launch parameter data 2019-09-30 17:27:23 -04:00
Zach Hilman d8affbc96c bcat: Add backend function for BCAT Indirect (launch parameter) 
Returns the data that should be returned by PopLaunchParameter kind=ApplicationSpecific.
 2019-09-30 17:27:23 -04:00
Zach Hilman 54ad90526d bcat: Expose CreateBackendFromSettings helper function 2019-09-30 17:27:23 -04:00
Zach Hilman e67610eb7e am: Unstub PopLaunchParameter and add bcat connection for app-specific data 
Previously we were simply returning the account-preselect structure all times but if passed with a different mode the game expects application-specific data. This also adds a hook for BCAT into this allowing us to send the launch parameter through bcat,
 2019-09-30 17:27:23 -04:00
Zach Hilman 2ea93ee695 bcat: Implement cmd 90201 ClearDeliveryCacheStorage 
Takes a title ID and simply deletes all the data for that title ID's bcat. Invokes the respective backend command.
 2019-09-30 17:23:26 -04:00
Zach Hilman efb7e044f3 bcat: Implement cmd 30100 SetPassphrase 
Takes a title ID and passphrase (0x40 byte string) and passes it to the backend.
 2019-09-30 17:23:26 -04:00
Zach Hilman cb6a1f58e7 bcat: Implement cmd RequestSyncDeliveryCache and variant 
Variant also supports only updating a single directory. These just both invoke backend commands.
 2019-09-30 17:23:26 -04:00
Zach Hilman 861f53b2b2 bcat: Implement IDeliveryCacheProgressService commands 
Used to query completion status and events for the current delivery task.
 2019-09-30 17:23:26 -04:00
Zach Hilman dc000f27bc bcat: Implement IDeliveryCacheFileService commands 
Used to read the contents of files and access their metadata.
 2019-09-30 17:23:26 -04:00
Zach Hilman dc3f624408 bcat: Implement IDeliveryCacheDirectoryService commands 
Used to list and get directories at the root level.
 2019-09-30 17:23:26 -04:00
Zach Hilman ee01e3163a bcat: Implement IDeliveryCacheStorageService commands 
Used to create subclasses to manage files and directories and to list directories.
 2019-09-30 17:23:26 -04:00
Zach Hilman 0030e8072a bcat: Add commands to create IDeliveryCacheStorageService 
Used to access contents of download.
 2019-09-30 17:23:26 -04:00
Zach Hilman 72bf9ba666 module: Create BCAT backend based upon Settings value on construction 2019-09-30 17:23:26 -04:00
Zach Hilman 225abdea57 bcat: Add BCAT backend for Boxcat service 
Downloads content from yuzu servers and unpacks it into the temporary directory provided. Fully supports all Backend features except passphrase.
 2019-09-30 17:21:53 -04:00
Zach Hilman 392ab2afe6 bcat: Add backend class to generify the functions of BCAT 
Provides the most abstract simplified functions of BCAT as functions. Also includes a NullBackend class which is just a no-op.
 2019-09-30 17:21:53 -04:00
Zach Hilman 094de9331f settings: Add option to set BCAT backend 2019-09-30 17:21:53 -04:00
Zach Hilman e058b9b3b9 nifm: Signal to applications that internet access is available 2019-09-30 17:21:53 -04:00
Zach Hilman d2d7eacee7 core/loader: Track the NSO build ID of the current process 2019-09-30 17:21:53 -04:00
Zach Hilman c3cb81acac applets: Add accessor for AppletFrontendSet 
Allows other services to call applets without using LLE.
 2019-09-30 17:20:49 -04:00
Zach Hilman 010cc6e4f4 filesystem: Add getter for BCAT temporary directory 2019-09-30 17:20:49 -04:00
Zach Hilman 82f636f1ed vfs: Add function to extract ZIP file into virtual filesystem 2019-09-30 17:18:38 -04:00
bunnei 0b44cab667 Revert "arm_dynarmic: Check if jit is nullptr when preparing reschedule" 2019-09-29 21:54:19 -04:00
bunnei 1b79644b4a Merge pull request #2574 from DarkLordZach/dynarmic-jit-nullptr 
arm_dynarmic: Check if jit is nullptr when preparing reschedule
 2019-09-29 21:44:10 -04:00
FreddyFunk c1a8d250a4 Services::ES fix casting warnings 2019-09-29 22:45:09 +02:00
David Marcec aea3724212 Signal styleset changes at a better time 
We should signal when a net controller is added and our event should be manual, not automatic.
 2019-09-24 17:24:37 +10:00
Zach Hilman 30eb8fa105 card_image: Add accessors for raw partitions in XCI 2019-09-22 21:51:46 -04:00
Zach Hilman 2e7ba9d78f card_image: Lazily load partitions in XCI 2019-09-22 21:50:29 -04:00
Zach Hilman 7e56536d35 pfs: Provide accessors for file sizes and offsets 2019-09-22 21:44:36 -04:00
Zach Hilman 13933f0af3 lm: Flush manager output on core shutdown 2019-09-22 12:34:55 -04:00
Zach Hilman 7b5b8db19c lm: Rename Initialize to Log and implement with manager/reporter 
Allows saving and clearer output of data.
 2019-09-22 12:34:55 -04:00
Zach Hilman f416d32f96 lm: Implement manager class to output to reporter 2019-09-22 12:34:55 -04:00
Zach Hilman 2fa697bb7c core: Add LM::Manager to system 
Allows centralized control over logging mechanisms.
 2019-09-22 12:34:55 -04:00
Zach Hilman ad5328136a reporter: Add log output for packaged lm log data 
Takes the vector from head to tail of log data and saves it.
 2019-09-22 12:34:33 -04:00
David 16104f4eae Merge pull request #2683 from DarkLordZach/lock-exit 
am: Implement exit locking and self exit commands
 2019-09-23 00:37:12 +10:00
Zach Hilman 60c5c60dfd Merge pull request #2876 from ogniK5377/AcquireNpadStyleSetUpdateEventHandle-fix 
AcquireNpadStyleSetUpdateEventHandle should have a separate event for each controller type
 2019-09-22 10:06:48 -04:00
David d4f53ba212 Merge pull request #2895 from FearlessTobi/debug-logs 
service/acc: Lower log severity from INFO to DEBUG
 2019-09-22 23:50:49 +10:00
Fernando Sahmkow 25054fdd42 Merge pull request #2873 from ogniK5377/new-ioctls 
Initial implementation of Ioctl2 & Ioctl3
 2019-09-22 09:45:29 -04:00
David Marcec 82d43a3554 removed comment 2019-09-22 23:42:52 +10:00
David Marcec b0eaa9934b Rebased 2019-09-22 23:42:41 +10:00
Fernando Sahmkow d88b81611e Merge pull request #2884 from ogniK5377/deglobal-sys-services 
Remove usage of System::CurrentInterface() from most services
 2019-09-22 09:38:13 -04:00
FearlessTobi 469f4764a0 service/acc: Lower log severity from INFO to DEBUG 
According to ogniK, this should have always been Debug and not Info.
 2019-09-22 15:15:07 +02:00
David Marcec db1079abd3 removed unneeded semicolon 2019-09-22 18:50:34 +10:00
David Marcec f35665aa28 Revert "Merge pull request #2709 from DarkLordZach/oss-ext-fonts-1" 
This reverts commit 66d80be727, reversing
changes made to 43decd1681.
 2019-09-22 17:47:25 +10:00
David Marcec 827c35bac0 Removed reference to core timing to nvflinger and used system instead 2019-09-22 16:55:15 +10:00
David Marcec 761b54f58c marked controller constructors as explicit 2019-09-22 16:41:38 +10:00
David Marcec 4b13f6cfcb Rebase 2019-09-22 16:41:34 +10:00
David Marcec f18f3f6b8e Rebase 2019-09-22 16:40:58 +10:00
David Marcec b48f1cbbb5 Deglobalize System: Vi 2019-09-22 16:38:03 +10:00
David Marcec 7675b98419 Deglobalize System: Time 2019-09-22 16:38:02 +10:00
David Marcec 2936be3ae1 Rebase 2019-09-22 16:37:59 +10:00
David Marcec d927a700da Deglobalize System: NvFlinger 2019-09-22 16:35:51 +10:00
David Marcec a8d2fd4a00 Rebase 2019-09-22 16:35:43 +10:00
David Marcec 45a6da4016 Deglobalize System: Nim 2019-09-22 16:30:34 +10:00
David Marcec bd8c949992 Deglobalize System: Nifm 2019-09-22 16:30:33 +10:00
David Marcec 37b2a234a2 Deglobalize System: NFP 2019-09-22 16:30:32 +10:00
David Marcec a2b9ed6d16 Deglobalize System: LDR 2019-09-22 16:30:31 +10:00
David Marcec 9196c150d6 Deglobalize System: IRS 2019-09-22 16:30:30 +10:00
David Marcec a43d56f18c Deglobalize System: Hid 2019-09-22 16:30:29 +10:00
David Marcec f0a8366ce3 Deglobalize System: Friend 2019-09-22 16:30:27 +10:00
David Marcec 1e8b0dcc2d Deglobalize System: Fatal 2019-09-22 16:30:25 +10:00
David Marcec 7b7e57693c Deglobalize System: Btm 2019-09-22 16:30:24 +10:00
David Marcec d50f79f6ed Deglobalize System: Btdrv 2019-09-22 16:30:20 +10:00
David Marcec 180dd576a7 Deglobalize System: Aoc 2019-09-22 16:30:17 +10:00
David Marcec 533e7e451f Deglobalize System: Am 2019-09-22 16:30:14 +10:00
David b890029175 Merge pull request #2535 from DarkLordZach/cheat-v2 
cheat_engine: Use Atmosphere's Cheat VM and fix cheat crash
 2019-09-22 16:24:42 +10:00
David 66d80be727 Merge pull request #2709 from DarkLordZach/oss-ext-fonts-1 
system_archive: Move shared font data to system_archive and fix extended font data
 2019-09-22 16:09:22 +10:00
Zach Hilman 949a913356 pl_u: Use kernel physical memory 2019-09-21 23:00:22 -04:00
Zach Hilman 68add35d52 qt: Prompt user for confirmation if exit lock is active 2019-09-21 22:46:57 -04:00
Zach Hilman bcac1b8ff5 dmnt_cheat_vm: Default initialize structure values 2019-09-21 22:43:49 -04:00
David Marcec 19b98e20d1 server side clang format fix2 2019-09-22 12:26:03 +10:00
Zach Hilman 6072d5146b am: Implement ISelfController ExitLock commands 2019-09-21 22:25:18 -04:00
Zach Hilman 0182812fa4 am: Implement ISelfController Exit 
Closes the current application.
 2019-09-21 22:25:18 -04:00
Zach Hilman 2a8fb5c6b3 am: Add RequestExit event to AppletMessageQueue 
Tested against libnx, signals to games to begin cleanup.
 2019-09-21 22:24:10 -04:00
Zach Hilman dd7a489e5c core: Track system exit lock status 
Used to determine if yuzu should confirm before pausing or stopping a game.
 2019-09-21 22:23:44 -04:00
David Marcec 3b1ae022c4 Use clang-format provided by build server 2019-09-22 12:21:07 +10:00
Zach Hilman 8cc2eccca2 pl_u: Remove excess static qualifier 2019-09-21 22:17:30 -04:00
Zach Hilman 977d27ed15 pl_u: Use OSS system archives if real archives don't exist 2019-09-21 21:50:41 -04:00
David 83ee5f63d6 Merge pull request #2612 from DarkLordZach/prepo-new 
prepo: Implement New, System, and Non-User variants of SaveReport
 2019-09-22 11:49:36 +10:00
Zach Hilman 0c7d9704c8 dmnt_cheat_vm: Make Cheat VM compliant to code style 2019-09-21 21:45:05 -04:00
Zach Hilman 0d2e645cb2 core: Initialize cheats after load to avoid VMManager crash 
This used to occur due to the VMManager being nullptr at the time cheats were registered (during load, but before it was done). This is bypassed by not accessing the VMManager for offset data until load is complete,
 2019-09-21 21:45:05 -04:00
Zach Hilman 3ad3191d56 core: Update RegisterCheatList for new VM 2019-09-21 21:45:05 -04:00
Zach Hilman 2b944e0d70 patch_manager: Update cheat parsing for new VM 2019-09-21 21:45:05 -04:00
Zach Hilman 0084098c9b nso: Pass build ID directly 
As opposed to converting to string and then back to hex array
 2019-09-21 21:44:22 -04:00
Zach Hilman deacc2bb25 cheat_engine: Move to memory and strip VM 
This is to go with the Atmosphere VM port, now it just contains the callbacks needed for the interface between DmntCheatVm and yuzu, along with the cheat parsers.
 2019-09-21 21:44:22 -04:00
Zach Hilman 4cd262e0b0 memory: Port Atmosphere's DmntCheatVm 
This was done because the current VM contained many inaccuracies and this also allows cheats to have identical behavior between hardware and yuzu.
 2019-09-21 21:44:22 -04:00
Zach Hilman f005898fb4 system_archive: Synthesize shared fonts system archives 2019-09-21 19:21:58 -04:00
Zach Hilman 110075b2fa pl_u: Expose method to encrypt TTF to BFTTF 2019-09-21 19:21:58 -04:00
Zach Hilman 896045aa4f externals: Move OSS font data to file_sys in core 2019-09-21 19:21:22 -04:00
Zach Hilman 447ada6c0a prepo: Remove system global accessors 2019-09-21 19:17:45 -04:00
Zach Hilman e975bf2349 prepo: Implement SaveReport New and System variants 2019-09-21 19:17:08 -04:00
Zach Hilman 234dee670e reporter: Differentiate between Old, New, and System play reports 2019-09-21 19:17:08 -04:00
Zach Hilman 04078a2139 configure_debug: Move reporting option to logging 2019-09-21 18:43:20 -04:00
Zach Hilman 541bf1b996 filesystem: Add const qualification to various accessors 2019-09-21 16:50:39 -04:00
Zach Hilman 89239c8647 core: Store FileSystemController in core 2019-09-21 16:50:39 -04:00
Zach Hilman a4d056eddf settings: Add options for managing gamecard emulation 2019-09-21 16:43:10 -04:00
Zach Hilman 6241a30a10 settings: Add options for setting storage sizes 2019-09-21 16:43:10 -04:00
Zach Hilman c3ad37b707 yuzu: Port old usages of Filesystem namespace to FilesystemController 2019-09-21 16:43:10 -04:00
Zach Hilman 688d14436f settings: Update LogSettings to show NAND/SDMC paths from FileUtil 2019-09-21 16:43:10 -04:00
Zach Hilman c094f75276 card_image: Add accessors for gamecard certificate 
Used by fsp-srv/IDeviceOperator
 2019-09-21 16:43:10 -04:00
Zach Hilman 58dba10b63 card_image: Add functions to query gamecard update partition 
Includes version and meta title ID, used by fsp-srv/IDeviceOperator
 2019-09-21 16:43:10 -04:00
Zach Hilman 8dcda218d8 content_archive: Add accessors for Rights ID and SDK Version 2019-09-21 16:43:10 -04:00
Zach Hilman 42252d9796 partition_data_manager: Add accessor for decrypted PRODINFO partition 2019-09-21 16:43:10 -04:00
Zach Hilman e443d76a29 services: Pass FileSystemController as reference to services that need it 2019-09-21 16:43:10 -04:00
Zach Hilman b854fb7e1a am: Unstub IApplicationFunctions EnsureSaveData (20) 
Creates a default save data for the application given a user ID.
 2019-09-21 16:43:10 -04:00
Zach Hilman 94ddc2ebdb filesystem: Pass Size Getter functions to IFileSystem for sizes 2019-09-21 16:43:10 -04:00
Zach Hilman a4b2e1c5ce sdmc_factory: Add SD Card size getters 2019-09-21 16:43:10 -04:00
Zach Hilman 4a2e1c6ae6 bis_factory: Add getters for NAND partition sizes 2019-09-21 16:43:10 -04:00
Zach Hilman 49440d51b1 filesystem: Add FileSystemController to deglobalize FS services 2019-09-21 16:43:10 -04:00
Zach Hilman 91d032d433 submisson_package: Fix edge case with improperly sized filenames 
Prevents a crash if the filename is less than 9 characters long.
 2019-09-21 16:43:10 -04:00
Zach Hilman 915ea374f8 sdmc_factory: Add accessor for SDMC Album directory 2019-09-21 16:43:10 -04:00
Zach Hilman 3c2e2156e0 sdmc_factory: Add accessor for SDMC PlaceholderCache 2019-09-21 16:43:10 -04:00
Zach Hilman 147fa325d9 sdmc_factory: Add accessor for content directory 2019-09-21 16:43:10 -04:00
Zach Hilman 85ae125737 savedata_factory: Implement savedata creation and don't create dir on open 
Matches hardware behavior and eliminates some nasty behavior we were doing that wasn't hw-accurate at all.
 2019-09-21 16:43:10 -04:00
Zach Hilman 1d342149cd patch_manager: Add short-circuit edge-case to GetPatchVersionNames 
If title ID is 0, there are no add ons, prevents wasting time looking for them.
 2019-09-21 16:43:10 -04:00
Zach Hilman e4336e33d6 patch_manager: Add error checking to load dir to prevent crashes 
Prevents a crash if the load dir would be nullptr, instead logs an error and returns appropriately.
 2019-09-21 16:43:10 -04:00
Zach Hilman ae762910b1 registered_cache: Process *.cnmt.nca files 
Needed to use the RegisteredCache/PlaceholderCache on gamecards.
 2019-09-21 16:43:10 -04:00
Zach Hilman 24ae0aacbc registered_cache: Implement PlaceholderCache to manage placeholder and installing content 2019-09-21 16:43:10 -04:00
Zach Hilman 9cef1068c5 bis_factory: Fix mod loader edge-case with homebrew title IDs 
Fixes a bug where homebrew that has a title ID with the update bit set can cause issues with the PatchManager
 2019-09-21 16:43:10 -04:00
Zach Hilman 8660185e63 bis_factory: Add accessors for BIS placeholder caches 2019-09-21 16:43:10 -04:00
Zach Hilman af109c066e bis_factory: Add accessor for NAND Image Directory 2019-09-21 16:43:10 -04:00
Zach Hilman 2146600c38 bis_factory: Add accessors for BIS content directories 2019-09-21 16:43:10 -04:00
Zach Hilman 17c5f05179 bis_factory: Add accessors for BIS partitions 2019-09-21 16:43:10 -04:00
David b23eb9eb5b Merge pull request #2806 from FearlessTobi/port-4882 
Port citra-emu/citra#4882: "Add frametime logging for tracking performance over time"
 2019-09-21 20:09:55 +10:00
David 6a0425d049 Merge pull request #2872 from FernandoS27/mem-gpu-opt 
Core/Memory: Only FlushAndInvalidate GPU if the page is marked as RasterizerCachedMemory
 2019-09-21 20:07:25 +10:00
David 95f4d78e87 Merge pull request #2576 from DarkLordZach/nsp-fix-1 
nsp: Fix various errors with loading and processing of extracted NSPs
 2019-09-21 20:05:24 +10:00
David Marcec 318288f0be Mark KickOffPb & SubmitGPFIFO as trace 
These functions are not stubbed and are called fairly often. Due to the nature of how often they're called, we should keep them marked as LOG_TRACE instead of LOG_DEBUG or LOG_WARNING
 2019-09-21 15:41:11 +10:00
David Marcec 7c1dd9debf disable clang-format temp 2019-09-20 10:25:12 +10:00
David Marcec 87e01ad919 Initial implementation of Ioctl2 & Ioctl3 
Purpose of Ioctl2 and Ioctl3 is to prevent the passing of raw pointers through ioctls
 2019-09-19 15:37:25 +10:00
Fernando Sahmkow 22928abc70 Core/Memory: Only FlushAndInvalidate GPU if the page is marked as RasterizerCachedMemory 
This commit avoids Invalidating and Flushing the GPU if the page is not
marked as a RasterizerCache Page.
 2019-09-18 22:47:22 -04:00
bunnei 5edd2960f7 Merge pull request #2667 from DarkLordZach/profile-editor 
acc: Implement IProfileEditor interface and 'Store'/'StoreWithImage' commands
 2019-09-14 00:46:18 -04:00
FearlessTobi 82f6c628e7 Address review comments 2019-09-10 12:57:45 +02:00
fearlessTobi 32c6e238fd Add frametime logging for tracking performance over time 
Co-Authored-By: jroweboy <jroweboy@gmail.com>
 2019-09-10 12:44:19 +02:00
David 6fb1c8d1f5 Merge pull request #2847 from VelocityRa/nro-nacp-fix 
nro/ui: Show "Developer" field in Properties
 2019-09-09 16:45:28 +10:00
David 19474db491 Merge pull request #2716 from lioncash/hle-global 
service/am: Remove usages of global system accessors
 2019-09-09 16:44:41 +10:00
David 04ee9a3bcb Merge pull request #2763 from lioncash/map-phys 
kernel/vm_manager: Minor cleanup
 2019-09-09 16:43:54 +10:00
Nick Renieris 1017fa7b1d nro: Implement ReadControlData 
With this, the "Developer" field in the Properties for homebrew is now populated.

Signed-off-by: Nick Renieris <velocityra@gmail.com>
 2019-09-08 00:40:21 +03:00
David b7bf445a16 Merge pull request #2418 from DarkLordZach/srv-es 
es: Implement various ticket accessor commands from IEticketService
 2019-09-05 12:13:14 +10:00
David ea025af713 Merge pull request #2707 from DarkLordZach/oss-miimodel 
system_archive: Add open-source reimplementation of MiiModel data
 2019-09-05 10:56:32 +10:00
Lioncash 6952478449 service/am: Remove usages of global system accessors 
Avoids the use of global accessors, removing the reliance on global
state. This also makes dependencies explicit in the interface, as
opposed to being hidden
 2019-09-04 20:38:43 -04:00
Lioncash c4cdbfdbff kernel/vm_manager: Correct doxygen comment parameter tags for MapPhysicalMemory/UnmapPhysicalMemory 
Corrects the parameter names within the doxygen comments so that they
resolve properly.
 2019-09-04 19:58:55 -04:00
Lioncash 4ca5db278f kernel/vm_manager: Move variables closer to usage spots in MapPhysicalMemory/UnmapPhysicalMemory 
Narrows the scope of variables down to where they're only necessary.
 2019-09-04 19:58:52 -04:00
David d1eeb95946 Merge pull request #2834 from Morph1984/audrenu_QueryAudioDeviceInputEvent 
audren_u: Stub IAudioDevice::QueryAudioDeviceInputEvent
 2019-09-05 09:51:50 +10:00
David 6fba18806a Merge pull request #2836 from Morph1984/hid_vibration 
hid: Implement PermitVibration and IsVibrationPermitted
 2019-09-05 09:50:38 +10:00
David 7d4cb86b60 Merge pull request #2818 from MysticExile/fmt 
externals: update fmt to 6.0.0
 2019-09-05 09:50:17 +10:00
mailwl 2e2c350032 AM: Stub IApplicationFunctions::GetGpuErrorDetectedSystemEvent (#2827) 
* AM: Implement IApplicationFunctions::GetGpuErrorDetectedSystemEvent

* Remove unneeded event clear

* Fix event name
 2019-09-04 11:43:04 -04:00
bunnei 29cbcb694f Merge pull request #2829 from Morph1984/audio 
service/audio/audren_u: Stub IAudioDevice::GetAudioDeviceOutputVolume
 2019-09-04 11:42:23 -04:00
Ethan 94ed7e8de1 Fix clang-format 2019-09-04 16:53:29 +02:00
Morph1984 fe122507f1 ditto 
Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
 2019-09-04 10:16:22 -04:00
Morph1984 dec5cac1c1 IsVibrationEnabled() as a const member func 2019-09-04 10:15:49 -04:00
Morph1984 32f74d8a88 clang-format 2019-09-04 10:06:38 -04:00
Morph1984 bad4a8a199 Update npad.h 2019-09-04 02:43:17 -04:00
Morph1984 8e070a3c14 Update npad.cpp 2019-09-04 02:42:58 -04:00
Morph1984 d8368a564d Update hid.h 2019-09-04 02:42:42 -04:00
Morph1984 460e77c935 Update hid.cpp 2019-09-04 02:42:22 -04:00
Morph1984 add4f972c4 Add Kernel::EventPair audio_input_device_switch_event; 2019-09-03 23:50:56 -04:00
Morph1984 a8ba3efc3f remove <f32> 
We can remove this since its already a f32 value
 2019-09-03 23:20:19 -04:00
Morph1984 9415310b14 audren_u: Stub IAudioDevice::QueryAudioDeviceInputEvent 2019-09-03 23:13:32 -04:00
David 4d3a8b193f Merge pull request #2708 from DarkLordZach/mii-db-source-crash 
mii: Handle logging of unknown database source
 2019-09-04 13:07:10 +10:00
Morph1984 d543e28fe8 explicitly represent 1 as a float (1.0f instead of 1) 2019-09-03 23:06:32 -04:00
bunnei 0d49a1d9cd Merge pull request #2793 from ReinUsesLisp/bgr565 
renderer_opengl: Implement RGB565 framebuffer format
 2019-09-03 22:36:32 -04:00
Morph1984 cadaf5aadb Change u32 -> f32 
Volume is a f32 value. (SwIPC describes it as a u32, but it is actually f32 as corroborated by switchbrew docs and SetAudioDeviceOutputVolume)

 ```cpp
const f32 volume = rp.Pop<f32>();
```
 2019-09-03 22:30:20 -04:00
Morph1984 37076c7419 service/audio/audren_u: Stub IAudioDevice::GetAudioDeviceOutputVolume 2019-09-03 16:05:33 -04:00
Lioncash ff201725ed kernel/vm_manager: Correct behavior in failure case of UnmapPhysicalMemory() 
If an unmapping operation fails, we shouldn't be decrementing the amount
of memory mapped and returning that the operation was successful. We
should actually be returning the error code in this case.
 2019-08-29 19:29:43 -04:00
Lioncash aed2815ba6 kernel/vm_manager: Reserve memory ahead of time for slow path in MergeAdjacentVMA 
Avoids potentially expensive (depending on the size of the memory block)
allocations by reserving the necessary memory before performing both
insertions. This avoids scenarios where the second insert may cause a
reallocation to occur.
 2019-08-29 19:29:43 -04:00
Lioncash eb1f6e7cdd kernel/vm_manager: std::move shared_ptr instance in MergeAdjacentVMA 
Avoids an unnecessary atomic reference count increment and decrement.
 2019-08-29 19:28:58 -04:00
Lioncash 1249e837ba kernel/vm_manager: Deduplicate iterator creation in MergeAdjacentVMA 
Avoids needing to read the same long sequence of code in both code
paths. Also makes it slightly nicer to read and debug, as the locals
will be able to be shown in the debugger.
 2019-08-29 19:28:57 -04:00
Lioncash bd55b99120 kernel/vm_manager: Simplify some std::vector constructor calls 
Same behavior, one less magic constant to read.
 2019-08-29 19:28:04 -04:00
Lioncash c4fde2713d kernel/vm_manager: Simplify some assertion messages 
Assertions already log out the function name, so there's no need to
manually include the function name in the assertion strings.
 2019-08-29 19:26:42 -04:00
Ethan e250a95348 accommodate for fmt update 2019-08-29 21:34:51 +02:00
bunnei 46fb3bfd15 Merge pull request #2748 from FernandoS27/align-memory 
VM_Manager: Align allocated host physical memory to 256bytes
 2019-08-21 12:10:10 -04:00
ReinUsesLisp d762e37a18 gpu: Change optional<reference_wrapper<T>> to T* for FramebufferConfig 2019-08-21 01:55:25 -03:00
bunnei 79992d99d3 Merge pull request #2747 from lioncash/audio 
service/audren_u: Unstub ListAudioDeviceName
 2019-08-18 09:08:25 -04:00
bunnei 6b8b59ee75 Merge pull request #2592 from FernandoS27/sync1 
Implement GPU Synchronization Mechanisms & Correct NVFlinger
 2019-07-26 14:26:44 -04:00
Fernando Sahmkow 5581a0d296 Kernel: Address Feedback 2019-07-19 11:28:57 -04:00
Fernando Sahmkow 5bce8f62ac VM_Manager: Align allocated memory to 256bytes 
This commit ensures that all backing memory allocated for the Guest CPU
is aligned to 256 bytes. This due to how gpu memory works and the heavy
constraints it has in the alignment of physical memory.
 2019-07-19 10:06:08 -04:00
Lioncash 873a3e1144 service/audren_u: Handle audio USB output revision queries in ListAudioDeviceName() 
Audio devices use the supplied revision information in order to
determine if USB audio output is able to be supported. In this case, we
can only really handle using this revision information in
ListAudioDeviceName(), where it checks if USB audio output is supported
before supplying it as a device name.

A few other scenarios exist where the revision info is checked, such as:

- Early exiting from SetAudioDeviceOutputVolume if USB audio is
  attempted to be set when that device is unsupported.

- Early exiting and returning 0.0f in GetAudioDeviceOutputVolume when
  USB output volume is queried and it's an unsupported device.

- Falling back to AHUB headphones in GetActiveAudioDeviceName when the
  device type is USB output, but is unsupported based off the revision
  info.

In order for these changes to also be implemented, a few other changes
to the interface need to be made.

Given we now properly handle everything about ListAudioDeviceName(), we
no longer need to describe it as a stubbed function.
 2019-07-19 07:55:27 -04:00
Lioncash cb8212d8b5 service/audren_u: Move revision testing code out of AudRenU 
The revision querying facilities are used by more than just audren. e.g.
audio devices can use this to test whether or not USB audio output is
supported.

This will be used within the following change.
 2019-07-19 07:55:23 -04:00
Lioncash b8c8916ab8 service/audio: Remove global system accessors 
Trims out the lingering reliance on global state out of the audio code.
 2019-07-19 07:29:36 -04:00
Lioncash b5db7b0100 service/audren_u: Remove unnecessary return value from GetActiveAudioDeviceName() 
This service function only ever returns a result and nothing more.
 2019-07-19 06:57:31 -04:00
Lioncash 9532e5e262 service/audren_u: Report proper device names 
AudioDevice and AudioInterface aren't valid device names on the Switch.
We should also be returning consistent names in
GetActiveAudioDeviceName().

While we're at it, we can also handle proper name output in
ListAudioDeviceName, by returning all the available devices on the
Switch.
 2019-07-19 06:57:30 -04:00
bunnei a0571bcccd Merge pull request #2687 from lioncash/tls-process 
kernel/process: Allocate the process' TLS region during initialization
 2019-07-18 13:53:04 -04:00
Fernando Sahmkow 27caf7f25f Kernel: Downgrade WaitForAddress and SignalToAddress messages to Trace. 
This messages were originally set as warnning since few games used these
svcs and it was needed for debugging. This is no longer the case.
 2019-07-17 22:05:47 -04:00
Rodrigo Locatti d877208914 Merge pull request #2726 from lioncash/access 
core: Remove CurrentArmInterface() global accessor
 2019-07-17 03:42:16 -03:00
Fernando Sahmkow 474c698422 Merge pull request #2690 from SciresM/physmem_fixes 
Implement MapPhysicalMemory/UnmapPhysicalMemory
 2019-07-14 09:16:46 -04:00
Lioncash 102801e196 core: Remove CurrentArmInterface() global accessor 
Replaces the final usage of the global accessor function and removes it.
Removes one more enabler of global state.
 2019-07-12 21:48:49 -04:00
David Marcec 88565f46b6 Clang format 2019-07-13 01:49:32 +10:00
David Marcec 00c7dc08de "AudioRenderer" thread should have a unique name 
Creating multiple "AudioRenderer" threads cause the previous thread to be overwritten. The thread will name be renamed to AudioRenderer-InstanceX, where X is the current instance number.
 2019-07-13 01:22:08 +10:00
Michael Scire 5ff046b9c6 Remove unicorn mappings/unmappings 2019-07-11 15:12:33 -07:00
bunnei 4679f23b21 Merge pull request #2717 from SciresM/unmirror_memory 
Restore memory perms on svcUnmapMemory/UnloadNro
 2019-07-11 14:57:20 -04:00
bunnei 60108f87a3 Merge pull request #2723 from lioncash/mem 
core/arm: Remove obsolete Unicorn memory mapping
 2019-07-11 14:56:26 -04:00
Lioncash 96e1a55219 service/am: Implement IsAutoSleepDisabled 
This simply queries whether or not auto-sleep facilities are disabled
and has no special handling. It's a basic getter function.
 2019-07-11 13:34:55 -04:00
Lioncash 89e1a5848a service/am: Implement SetAutoSleepDisabled 
Provides a basic implementation of SetAutoSleepDisabled. Until idle
handling is implemented, this is about the best we can do.

In the meantime, provide a rough documenting of specifics that occur
when this function is called on actual hardware.
 2019-07-11 13:09:03 -04:00
Lioncash 66cfba50ed yuzu: Remove setting for using Unicorn 
The JIT is mature enough that this setting can be removed, falling back
to Unicorn only on unsupported architectures. Any missing features from
Unicorn (of which there are extremely few), are mostly
developer-oriented, which most users don't care about.

Features should be coordinated with the JIT, not the interpreter,
anyhow.
 2019-07-11 05:59:13 -04:00
Lioncash 6b4fd5ccad core/arm: Remove obsolete Unicorn memory mapping 
This was initially necessary when AArch64 JIT emulation was in its
infancy and all memory-related instructions weren't implemented.

Given the JIT now has all of these facilities implemented, we can remove
these functions from the CPU interface.
 2019-07-11 05:35:46 -04:00
Michael Scire 902cad78ee Restore memory perms on svcUnmapMemory/UnloadNro 
Prior to PR, Yuzu did not restore memory to RW-
on unmap of mirrored memory or unloading of NRO.

(In fact, in the NRO case, the memory was unmapped
instead of reprotected to --- on Load, so it was
actually lost entirely...)

This PR addresses that, and restores memory to RW-
as it should.

This fixes a crash in Super Smash Bros when creating
a World of Light save for the first time, and possibly
other games/circumstances.
 2019-07-11 01:38:28 -07:00
bunnei 552d647663 Merge pull request #2700 from ogniK5377/GetFriendList 
IFriendService::GetFriendList
 2019-07-10 16:29:48 -04:00
bunnei 08a4eb9ef3 Merge pull request #2611 from DarkLordZach/pm-info-cmd 
pm: Implement various pm commands for finding process and title IDs
 2019-07-10 16:28:29 -04:00
bunnei ee2acf4240 Merge pull request #2650 from DarkLordZach/mii-iface-ver 
mii: Implement IDatabaseService SetInterfaceVersion
 2019-07-10 16:26:23 -04:00
Zach Hilman f458590c85 system_archive: Add open-source reimplementation of MiiModel data 2019-07-10 07:21:36 -04:00
Zach Hilman e88efc046f mii: Handle logging of unknown database source 2019-07-10 07:07:24 -04:00
David Marcec 127b0dfc77 IFriendService::GetFriendList 
We don't have any friends implemented in Yuzu yet so it doesn't make sense to return any friends. For now we'll be returning 0 friends however the information provided will allow a proper implementation of this cmd when needed.
 2019-07-09 18:20:58 +10:00
Michael Scire 4e57de9e0b Prevent merging of device mapped memory blocks. 
This sets the DeviceMapped attribute for GPU-mapped memory blocks,
and prevents merging device mapped blocks. This prevents memory
mapped from the gpu from having its backing address changed by
block coalesce.
 2019-07-08 22:52:05 -07:00
Zach Hilman 4a0439e97a Merge pull request #2657 from ogniK5377/npad-assignments 
hid:StartLrAssignmentMode, hid:StopLrAssignmentMode, hid:SwapNpadAssignment
 2019-07-08 09:35:19 -04:00
David Marcec cdd7c41b36 addressed issues 2019-07-08 14:51:40 +10:00
bunnei c8db8fa033 Merge pull request #2651 from DarkLordZach/apm-boost-mode-1 
apm: Initial implementation of performance config and boost mode
 2019-07-07 21:40:30 -04:00
bunnei 28c3099b5e Merge pull request #2642 from DarkLordZach/fsp-log-2 
fsp-srv: Implement Access Logging Functionality
 2019-07-07 21:39:40 -04:00
Zach Hilman fe150ae0a4 key_manager: Convert Ticket union to std::variant 2019-07-07 21:38:33 -04:00
Zach Hilman 51374d2489 es: Populate/synthesize tickets on construction 2019-07-07 21:38:33 -04:00
Zach Hilman 7b86f1b7f8 key_manager: Add structure for Ticket parsing 2019-07-07 21:38:33 -04:00
Zach Hilman f48746b485 es: Implement ETicket GetPersonalizedTicketData (17) 
Copies the raw personal ticket data into the buffer provided.
 2019-07-07 21:38:33 -04:00
Zach Hilman 1558181ac8 es: Implement ETicket GetCommonTicketData (16) 
Copies the raw common ticket data for the specified rights ID into the buffer provided.
 2019-07-07 21:38:33 -04:00
Zach Hilman b5863d70bb es: Implement ETicket GetPersonalizedTicketSize (15) 
Returns the size of the buffer needed to hold the personal ticket associated with the rights ID.
 2019-07-07 21:38:33 -04:00
Zach Hilman 40e9ecb944 es: Implement ETicket GetCommonTicketSize (14) 
Returns the size of the buffer needed to hold the common ticket associated with the rights ID.
 2019-07-07 21:38:33 -04:00
Zach Hilman b7bc1ca0a4 es: Implement ETicket ListPersonalizedTicket (12) 
Returns an application-specific number of entries of personal tickets, starting at offset 0.
 2019-07-07 21:38:33 -04:00
Zach Hilman d096722c60 es: Implement ETicket ListCommonTicket (11) 
Returns an application specified count of entries of common tickets, starting at offset 0.
 2019-07-07 21:38:33 -04:00
Zach Hilman df8800b719 es: Implement ETicket CountPersonalizedTicket (10) 
Returns the number of personalized (console/user-unique) tickets in the KeyManager.
 2019-07-07 21:38:33 -04:00
Zach Hilman 59df34708d es: Implement ETicket CountCommonTicket (9) 
Returns the number of common (non-console-unique) tickets in the KeyManager.
 2019-07-07 21:38:33 -04:00
Zach Hilman 0ec000ec39 es: Implement ETicket GetTitleKey (8) 
Takes a rights ID as input and returns the associated title key, if it exists.
 2019-07-07 21:38:33 -04:00
Zach Hilman 73ceeea0e4 es: Implement ETicket ImportTicket (1) 
Takes a ticket and certificate and installs it to the KeyManager.
 2019-07-07 21:38:33 -04:00
Zach Hilman 2092bde879 key_manager: Add accessors/helpers for ticket management 2019-07-07 21:38:33 -04:00
Zach Hilman a315a7d8ed key_manager: Add equality operator for RSAKeyPair 2019-07-07 21:38:33 -04:00
Michael Scire 0e2ec7457a Remove unused member function declaration 2019-07-07 13:02:41 -07:00
Michael Scire 4ce2cda054 physmem: add helpers, cleanup logic. 2019-07-07 12:55:30 -07:00
Michael Scire 1a0bbd14e7 clang-format fixes 2019-07-07 12:08:29 -07:00
Michael Scire e0659e3793 address review commentary 2019-07-07 11:48:11 -07:00
Michael Scire 6a33b060b7 Implement MapPhysicalMemory/UnmapPhysicalMemory 
This implements svcMapPhysicalMemory/svcUnmapPhysicalMemory for Yuzu,
which can be used to map memory at a desired address by games since
3.0.0.

It also properly parses SystemResourceSize from NPDM, and makes
information available via svcGetInfo.

This is needed for games like Super Smash Bros. and Diablo 3 -- this
PR's implementation does not run into the "ASCII reads" issue mentioned
in the comments of #2626, which was caused by the following bugs in
Yuzu's memory management that this PR also addresses:
* Yuzu's memory coalescing does not properly merge blocks. This results
  in a polluted address space/svcQueryMemory results that would be
  impossible to replicate on hardware, which can lead to game code making
  the wrong assumptions about memory layout.
  * This implements better merging for AllocatedMemoryBlocks.
* Yuzu's implementation of svcMirrorMemory unprotected the entire
  virtual memory range containing the range being mirrored. This could
  lead to games attempting to map data at that unprotected
  range/attempting to access that range after yuzu improperly unmapped
  it.
  * This PR fixes it by simply calling ReprotectRange instead of
    Reprotect.
 2019-07-07 11:45:53 -07:00
Lioncash 5e5e939ef2 kernel/process: Allocate the process' TLS region during initialization 
Prior to execution within a process beginning, the process establishes
its own TLS region for uses (as far as I can tell) related to exception
handling.

Now that TLS creation was decoupled from threads themselves, we can add
this behavior to our Process class. This is also good, as it allows us
to remove a stub within svcGetInfo, namely querying the address of that
region.
 2019-07-07 14:08:28 -04:00
Lioncash edd1ab0311 kernel/process: Move main thread stack allocation to its own function 
Keeps this particular set of behavior isolated to its own function.
 2019-07-07 14:08:25 -04:00
Zach Hilman 67e5cb8b21 mii: Implement IDatabaseService SetInterfaceVersion 
Appears to set a member variable used to affect the API that games access, and the method used to store data.
 2019-07-06 21:39:12 -04:00
Zach Hilman fcf404c244 Merge pull request #2674 from lioncash/reporter 
core/reporter: Minor changes
 2019-07-06 21:26:40 -04:00
Zach Hilman 1d1a584a6b Merge pull request #2677 from lioncash/assert 
kernel/vm_manager: Handle stack/TLS IO region placement a little better
 2019-07-06 21:25:27 -04:00
Michael Scire ce79a125cc clang-format fixes 2019-07-06 13:52:05 -07:00
Michael Scire 597e3aadf0 am: Implement GetAccumulatedSuspendedTickValue 2019-07-06 12:13:34 -07:00
Lioncash 47070b5fb4 memory: Remove unused includes 
These aren't used within the central memory management code, so they can
be removed.
 2019-07-06 02:24:34 -04:00
Lioncash 38c9502a30 memory: Remove unused PageTable forward declaration 
This isn't used by anything in the header file, so it can be removed.
 2019-07-06 02:24:34 -04:00
Lioncash fa5791150c kernel/vm_manager: Rename 'new map' to 'stack' 
Provides a more accurate name for the memory region and also
disambiguates between the map and new map regions of memory, making it
easier to understand.
 2019-07-06 02:24:30 -04:00
Lioncash c208d57f96 kernel/vm_manager: Handle stack/TLS IO region placement better 
Handles the placement of the stack a little nicer compared to the
previous code, which was off in a few ways. e.g.

The stack (new map) region, shouldn't be the width of the entire address
space if the size of the region calculation ends up being zero. It
should be placed at the same location as the TLS IO region and also have
the same size.

In the event the TLS IO region contains a size of zero, we should also
be doing the same thing. This fixes our memory layout a little bit and
also resolves some cases where assertions can trigger due to the memory
layout being incorrect.
 2019-07-05 21:57:31 -04:00
Lioncash d360b7465f core/reporter: Allow moves into SaveToFile() 
Taking the json instance as a constant reference, makes all moves into
the parameter non-functional, resulting in copies. Taking it by value
allows moves to function.
 2019-07-05 17:45:34 -04:00
Lioncash 770387fadb core/reporter: Add missing includes and forward declarations 
Adds missing inclusions to prevent potential compilation issues.
 2019-07-05 17:45:24 -04:00
Lioncash 0756025102 core/reporter: Remove unnecessary namespace qualifiers 
The Reporter class is part of the Core namespace, so the System class
doesn't need to be qualified.
 2019-07-05 17:09:26 -04:00
Lioncash 6e9c716272 core/reporter: Remove pessimizing move in GetHLERequestContextData() 
This can inhibit copy-elision, so we can remove this redundant move.
 2019-07-05 17:08:13 -04:00
Lioncash 174e596d56 core/reporter: Make bracing consistent 
Makes all control statements braced, regardless of their size, making
code more uniform.
 2019-07-05 17:05:27 -04:00
Lioncash 5db1fdfa4a core/reporter: Return in error case in SaveToFile() 
If the path couldn't be created, then we shouldn't be attempting to save
the file.
 2019-07-05 17:02:32 -04:00
Fernando Sahmkow 658934de85 NVServices: Correct delayed responses. 2019-07-05 15:49:35 -04:00
Fernando Sahmkow cbb5d814bc Nv_Host_Ctrl: Correct difference calculation 2019-07-05 15:49:34 -04:00
Fernando Sahmkow 94a7beb8b9 NVServices: Address Feedback 2019-07-05 15:49:33 -04:00
Fernando Sahmkow b8b874005f NVServices: Styling, define constructors as explicit and corrections 2019-07-05 15:49:32 -04:00
Fernando Sahmkow a156731a9c NVFlinger: Correct GCC compile error 2019-07-05 15:49:31 -04:00
Fernando Sahmkow 9db53b51b6 NVServices: Make NVEvents Automatic according to documentation. 2019-07-05 15:49:29 -04:00
Fernando Sahmkow 1238b13642 NVServices: Correct CtrlEventWaitSync to block the ipc until timeout. 2019-07-05 15:49:28 -04:00
Fernando Sahmkow 604dc3f59b GPU: Correct Interrupts to interrupt on syncpt/value instead of event, mirroring hardware 2019-07-05 15:49:26 -04:00
Fernando Sahmkow bd05d92c26 nvflinger: Make the force 30 fps still force 30 fps 2019-07-05 15:49:25 -04:00
Fernando Sahmkow 575bf9d7fb nv_services: Fixes to event liberation. 2019-07-05 15:49:24 -04:00
Fernando Sahmkow 4aa0a8add2 nvflinger: Acquire buffers in the same order as they were queued. 2019-07-05 15:49:23 -04:00
Fernando Sahmkow 531e3431fb nv_services: Deglobalize NvServices 2019-07-05 15:49:22 -04:00
Fernando Sahmkow 772d205e8f nv_host_ctrl: Make Sync GPU variant always return synced result. 2019-07-05 15:49:20 -04:00
Fernando Sahmkow 58f62368b3 nvhost_ctrl: Corrections to event handling 2019-07-05 15:49:17 -04:00
Fernando Sahmkow 095e6b1cd9 Gpu: Mark areas as protected. 2019-07-05 15:49:16 -04:00
Fernando Sahmkow 8c8e96b87c nv_services: Stub CtrlEventSignal 2019-07-05 15:49:15 -04:00
Fernando Sahmkow 1fb8727a9a Gpu: Implement Hardware Interrupt Manager and manage GPU interrupts 2019-07-05 15:49:14 -04:00
Fernando Sahmkow 9a3dea2bdc nv_services: Implement NvQueryEvent, NvCtrlEventWait, NvEventRegister, NvEventUnregister 2019-07-05 15:49:13 -04:00
Fernando Sahmkow 5ff576460e nv_services: Create GPU channels correctly 2019-07-05 15:49:12 -04:00
Fernando Sahmkow 779c115dbb video_core: Implement GPU side Syncpoints 2019-07-05 15:49:11 -04:00
Fernando Sahmkow 6fd625d497 nv_services: Correct buffer queue fencing and GPFifo fencing 2019-07-05 15:49:10 -04:00
Fernando Sahmkow feac2e189e nvflinger: Implement swap intervals 2019-07-05 15:49:08 -04:00
Zach Hilman 04ae4a56e1 Merge pull request #2669 from FearlessTobi/move-cpujit-setting 
yuzu: Move CPU Jit setting to Debug tab
 2019-07-04 15:33:59 -04:00
Zach Hilman df8e0e1b33 Merge pull request #2555 from lioncash/tls 
kernel/process: Decouple TLS handling from threads
 2019-07-04 15:32:32 -04:00
fearlessTobi 662ff325bf yuzu: Remove CPU Jit setting from the UI 
A normal user shouldn't change this, as it will slow down the emulation and can lead to bugs or crashes. The renaming is done in order to prevent users from leaving this on without a way to turn it off from the UI.
 2019-07-04 14:48:08 +02:00
bunnei 89a4d5342c Merge pull request #2658 from ogniK5377/QueryAudioDeviceOutputEvent 
IAudioDevice::QueryAudioDeviceOutputEvent
 2019-07-04 01:42:22 -04:00
bunnei cfe89534e2 Merge pull request #2638 from DarkLordZach/quest-flag 
set: Implement GetQuestFlag with config option
 2019-07-04 01:40:41 -04:00
Lioncash 63b8ef17d5 kernel/process: Default initialize all member variables 
Ensures a Process instance is always created with a deterministic
initial state.
 2019-07-03 20:31:40 -04:00
Lioncash 89a030a376 kernel/process: Decouple TLS handling from threads 
Extracts out all of the thread local storage management from thread
instances themselves and makes the owning process handle the management
of the memory. This brings the memory management slightly more in line
with how the kernel handles these allocations.

Furthermore, this also makes the TLS page management a little more
readable compared to the lingering implementation that was carried over
from Citra.
 2019-07-03 20:31:40 -04:00
Lioncash 30d4abdd7a kernel/vm_manager: Add overload of FindFreeRegion() that operates on a boundary 
This will be necessary for making our TLS slot management slightly more
straightforward. This can also be utilized for other purposes in the
future.

We can implement the existing simpler overload in terms of this one
anyways, we just pass the beginning and end of the ASLR region as the
boundaries.
 2019-07-03 20:29:49 -04:00
Zach Hilman c77f1a9743 Merge pull request #2613 from ogniK5377/InitalizeApplicationInfo 
Implemented InitializeApplicationInfo & InitializeApplicationInfoRestricted
 2019-07-03 20:23:56 -04:00
Zach Hilman 53d4cc417f Merge pull request #2608 from ogniK5377/Time_GetSharedMemoryNativeHandle 
Implement Time::GetSharedMemoryNativeHandle
 2019-07-03 20:22:23 -04:00
Zach Hilman 0bcf3756a8 acc_su: Implement GetProfileEditor (205) 
Takes a UUID of a user and provides and interface that allows RW access to user data/settings.
 2019-07-03 07:57:41 -05:00
Zach Hilman 9cb38c327a acc: Implement IProfileEditor-specific commands 'Store' and 'StoreWithImage' 
Verified with IDA
 2019-07-03 07:57:03 -05:00
Zach Hilman d25b6dae26 profile_manager: Add setter for ProfileBase and ProfileData 
Needed by IProfileEditor 'Store' and 'StoreWithImage'
 2019-07-03 07:56:28 -05:00
Zach Hilman 151feaf21b acc: Add IProfileCommon for IProfile and IProfileEditor 
Since 2/3 of the commands are shared, this is likely how its done on HW.
 2019-07-03 07:55:54 -05:00
bunnei ab85f9a7fe Merge pull request #2604 from ogniK5377/INotificationService 
Implemented INotificationService
 2019-07-02 23:32:57 -04:00
Bakugo 81c1c139fe file_sys: Rename other ContentRecordType members 2019-07-02 00:57:23 +01:00
David Marcec f7d0320b84 IAudioDevice::QueryAudioDeviceOutputEvent 
The event should only be signaled when an output audio device gets changed. Example, Speaker to USB headset. We don't identify different devices internally yet so there's no need to signal the event yet.
 2019-07-01 18:05:44 +10:00
Bakugo e377bcd699 file_sys/registered_cache: Improve missing metadata error 
This can happen when installing NSPs too, not just XCIs.
 2019-07-01 07:31:32 +01:00
Bakugo d046ef7112 file_sys/submission_package: Don't warn about missing DeltaFragment NCAs 
DeltaFragments are not useful to us and are often not included in patch NSPs.
 2019-07-01 06:46:05 +01:00
Bakugo 88a70b40ba file_sys/registered_cache: Ignore DeltaFragment NCAs during installation 
DeltaFragments are only used to download and apply partial patches on a real console, and are not useful to us at all. Most patch NSPs do not include them, and when they do, it's a waste of space to install them.
 2019-07-01 06:37:22 +01:00
Bakugo 29f1d01c06 file_sys: Rename ContentRecordType::Patch to DeltaFragment 
Avoids potential confusion, since patches and DeltaFragments are not the same thing. Actual full patches are listed under the Program type.
 2019-07-01 06:32:13 +01:00
David Marcec f9eeba983f hid:StartLrAssignmentMode, hid:StopLrAssignmentMode, hid:SwapNpadAssignment 
StartLrAssignmentMode and StopLrAssignmentMode don't require any implementation as it's just used for showing the screen of changing the controller orientation if the user wishes to do so.  Ever since #1634 this has not been needed as users can specify the controller orientation from the config and swap at any time. We store a private member just in case this gets used for anything extra in the future
 2019-07-01 15:12:57 +10:00
bunnei 35c44f37f2 Merge pull request #2583 from FernandoS27/core-timing-safe 
Core_Timing: Make core_timing threadsafe by default.
 2019-06-30 12:54:00 -04:00
Zach Hilman a6f0026b75 am: Implement SetCpuBoostMode in terms of APM 2019-06-28 22:46:51 -04:00
Zach Hilman f7ed383a84 core: Keep instance of APM Controller 2019-06-28 22:46:31 -04:00
Zach Hilman 1564a8835c apm: Implement SetCpuBoostMode 2019-06-28 22:46:00 -04:00
Zach Hilman b4838ee850 apm: Add getters for performance config and mode 2019-06-28 22:45:31 -04:00
Zach Hilman 5870cce7e1 apm: Add apm:am service 
8.0.0+ identical version of apm
 2019-06-28 22:44:30 -04:00
Zach Hilman 80c4d6eaf8 apm: Add Controller class to manage speed data and application 2019-06-28 22:43:51 -04:00
Zach Hilman ac6474a66f fsp-srv: Implement GetAccessLogVersionInfo 
Returns some misc. data about logging to help the game determine if it should log.
 2019-06-28 21:05:42 -04:00
Zach Hilman 0add7f4ccb reporter: Add report class for filesystem access logs 2019-06-28 21:02:50 -04:00
Zach Hilman 512a47c184 fsp-srv: Implement OutputAccessLogToSdCard 
Allows games to log data to the SD.
 2019-06-28 21:02:34 -04:00
Zach Hilman 03191c612a set: Implement GetQuestFlag 
Simply returns a true/false value indicating if the system is a kiosk system. This has been mapped to a config option for the purposes of yuzu.
 2019-06-28 18:38:47 -04:00
Zach Hilman 5def076ff4 settings: Add config option for kiosk (quest) mode 2019-06-28 18:37:33 -04:00
bunnei e82d461580 Merge pull request #2533 from DarkLordZach/memory-frozen 
memory: Add class to manage and enforce memory freezing
 2019-06-28 14:03:38 -04:00
David Marcec d81178e7e6 Attemp clang format fix? 
Seems to be an issue with clang format
 2019-06-28 22:08:50 +10:00
David Marcec 0a5474ed7c Added errors.h to cmakelist 2019-06-28 15:31:29 +10:00
David Marcec 4ec3475acc Addressed issues 2019-06-28 15:29:38 +10:00
David Marcec e2e69ef605 Addressed issues 2019-06-28 15:19:51 +10:00
David Marcec a08b4d77c8 Implemented InitializeApplicationInfo & InitializeApplicationInfoRestricted 
InitializeApplicationInfoRestricted will need further implementation as it's checking for other user requirements about the game. As we're emulating, we're assuming the user owns the game so we skip these checks currently, implementation will need to be added further on
 2019-06-27 16:44:42 +10:00
Zach Hilman a37e318a69 pm: Implement pm:shell and pm:dmnt GetApplicationPid 
Returns the process ID of the current application or 0 if no app is running.
 2019-06-26 19:07:34 -04:00
Zach Hilman 0bc1fc3fcf pm: Implement pm:dmnt GetTitlePid 
Takes a title ID and searches for a matching process, returning error if it doesn't exist, otherwise the process ID.
 2019-06-26 19:06:51 -04:00
Zach Hilman afcab374d1 pm: Implement pm:info GetTitleId 
Searches the process list for a process with the specified ID, returning the title ID if it exists.
 2019-06-26 19:05:04 -04:00
bunnei 20c34dea2e Merge pull request #2548 from DarkLordZach/applet-shopn 
applets: Implement backend and default frontend for Parental Controls and EShop (ShopN) applets
 2019-06-26 15:55:24 -04:00
David Marcec 3c8723cb74 Addressed issues 2019-06-26 16:52:34 +10:00
Zach Hilman 12105d8909 glue: Correct missing bytes in ApplicationLaunchParameter 2019-06-25 22:25:10 -04:00
David Marcec dac62b07bf Implement Time::GetSharedMemoryNativeHandle 
This PR attempts to implement the shared memory provided by GetSharedMemoryNativeHandle. There is still more work to be done however that requires a rehaul of the current time module to handle clock contexts. This PR is mainly to get the basic functionality of the SharedMemory working and allow the use of addition to it whilst things get improved on.

Things to note:
Memory Barriers are used in the SharedMemory and a better solution would need to be done to implement this. Currently in this PR I’m faking the memory barriers as everything is sync and single threaded. They work by incrementing the counter and just populate the two data slots. On data reading, it will read the last added data.

Specific values in the shared memory would need to be updated periodically. This isn't included in this PR since we don't actively do this yet. In a later PR when time is refactored this should be done.

Finally, as we don't handle clock contexts. When time is refactored, we will need to update the shared memory for specific contexts. This PR does this already however since the contexts are all identical and not separated. We're just updating the same values for each context which in this case is empty.

Tiime:SetStandardUserSystemClockAutomaticCorrectionEnabled, Time:IsStandardUserSystemClockAutomaticCorrectionEnabled are also partially implemented in this PR. The reason the implementation is partial is because once again, a lack of clock contexts. This will be improved on in a future PR.

This PR closes issue #2556
 2019-06-26 00:45:53 +10:00
David Marcec 9a4d35fd46 SizedNotificationInfo should be 0x10 bytes, user_uuid is incorrect, this should be the users account id 2019-06-25 15:19:37 +10:00
David Marcec c557b50022 fixed spelling errors and fixed issue with Pop not returning the SizedNotificationInfo 2019-06-25 11:23:23 +10:00
Zach Hilman 2f49b0e0b1 applets: Pass current process title ID to applets 
Avoids using system accessor to get current process in applet code.
 2019-06-24 20:07:10 -04:00
Zach Hilman 7de7e83df0 general_frontend: Add documentation for parental controls and ecommerce applets 2019-06-24 20:05:11 -04:00
Zach Hilman d2ba9e2f09 web_browser: Only delete temporary directory if it was created 
Prevents crashes with ShopN applet occasionally.
 2019-06-24 20:05:11 -04:00
Zach Hilman 9425e3c388 web_browser: Take ECommerce applet frontend optionally in constructor 
If it is needed but wasn't passed (or passed nullptr), the Shop handling code will alert and throw an error.
 2019-06-24 20:05:11 -04:00
Zach Hilman a2a6d68083 frontend: Add base class and default impl for ECommerce applet frontend 2019-06-24 20:05:11 -04:00
Zach Hilman 7bcf8e8305 web_browser: Use function tables for execute and initialize 
Allows easy handling of multiple shim types, as they have enough in common to be the same backend but not enough to share init/exec.
 2019-06-24 20:05:11 -04:00
Zach Hilman 1322c2ff7a web_browser: Correct structures and properly parse TLVs/ShimKind 
Much, much more HW-accurate and allows us to easily support all of the different web 'shim' types.
 2019-06-24 20:05:11 -04:00
Zach Hilman 30735156ff applets: Track ECommerce and Parental Control applet frontends 2019-06-24 20:05:11 -04:00
Zach Hilman 76bf6c6ea9 web_browser: Rename OpenPage to OpenPageLocal 
This is more representative of what actually occurs, as web does support remote URLs which wouldn't need a romfs callback. This paves for easy future support of this with a call like 'OpenPageRemote' or similar.
 2019-06-24 20:05:11 -04:00
Zach Hilman cff3014921 frontend: Add base class and default impl of parent controls applet frontend 2019-06-24 20:05:11 -04:00
Zach Hilman 9f43c3de05 applets: Implement Auth applet backend 
This is responsible for parental controls and supports verifying, changing, and registering PIN codes.
 2019-06-24 20:05:11 -04:00
Zach Hilman 22bea84c51 core: Keep track of ARPManager and register current application on boot 2019-06-24 19:27:35 -04:00
Zach Hilman 430a52ecb3 glue: Implement arp:w and arp:r services 
These keep track of running process' launch properties and control properties and allows for issuing and reading them by process and title ID.
 2019-06-24 19:26:16 -04:00
Zach Hilman 837cc28dae glue: Add errors for glue/arp services 2019-06-24 19:20:28 -04:00
Zach Hilman 5a9560cb33 glue: Add scaffolding for bgtc:t and bgtc:sc services 2019-06-24 19:20:06 -04:00
Zach Hilman 72306a95da arp: Move to glue services 
Glue is the name of the sysmodule that contains both arp and bgtc.
 2019-06-24 19:17:48 -04:00
Zach Hilman 37a7c17014 glue: Add manager to keep track of application registry 
Manages mapping between title IDs and application launch and control properties.
 2019-06-24 19:17:13 -04:00
Zach Hilman fb8b87dbaf registered_cache: Add getter to determine source slot in content provider union 
Used to determine StorageId source for application data.
 2019-06-24 19:10:17 -04:00
Zach Hilman 7891b418d4 patch_manager: Add getter for title version 2019-06-24 19:05:50 -04:00
David Marcec 0a47457838 Implemented INotificationService 2019-06-24 12:26:45 +10:00
Thomas May 3fc5127a9f Update reporter.cpp 2019-06-22 14:39:52 +01:00
bunnei 726dea6e3d Merge pull request #2602 from lioncash/cast 
service/acc: Silence truncation warnings
 2019-06-21 15:27:25 -04:00
bunnei 9ee4e61659 Merge pull request #2575 from DarkLordZach/process-id-types 
kernel: Differentiate kernel and user processes when picking ID
 2019-06-21 15:25:50 -04:00
bunnei a43061206c Merge pull request #2546 from DarkLordZach/kips 
loader, file_sys: Add support for parsing and loading KIP (Kernel Internal Process) files
 2019-06-21 14:28:18 -04:00
bunnei 36090e6a67 Merge pull request #2482 from DarkLordZach/prepo 
core: Add detailed local reporting feature for development
 2019-06-21 14:05:18 -04:00
Lioncash ee7b682ee0 service/acc: Silence truncation warnings 
The sanitizing function ensures that the returned type is always the
correct type. This eliminates warnings without extra casts.
 2019-06-21 10:04:31 -04:00
Zach Hilman 6aa4b7b369 freezer: Update documentation 2019-06-20 19:22:53 -04:00
Zach Hilman c0126e6779 core: Move Freezer class to tools namespace 2019-06-20 19:22:53 -04:00
Zach Hilman 89cb67c76e freezer: Add documentation for methods 2019-06-20 19:22:04 -04:00
Zach Hilman 9ab4d3de50 memory: Add class to manage and enforce memory freezing 2019-06-20 19:22:04 -04:00
bunnei 71ec79857a Merge pull request #2596 from FernandoS27/revert-2590 
Revert PR 2590.
 2019-06-20 13:04:06 -04:00
Hexagon12 9d0137b23e Merge pull request #2595 from jonsn0w/patch-1 
Update content_archive.cpp
 2019-06-20 10:03:24 +03:00
Fernando Sahmkow 1b11723253 Revert PR 2590. 
Even though it has been proven that IAudioRenderer:SystemEvent is 
actually an automatic event. The current implementation of such event is 
all thought to be manual. Thus it's implementation needs to be corrected 
when doing such change. As it is right now this PR introduced a series 
of regressions on softlocks on multiple games. Therefore, this pr 
reverts such change until a correct implementation is made.
 2019-06-19 23:19:19 -04:00
bunnei 8516ab7e90 Merge pull request #2591 from lioncash/record 
core: Remove unused CiTrace source files
 2019-06-19 22:28:26 -04:00
bunnei 6a7d4946da Merge pull request #2590 from lioncash/event 
service/audio/audren_u: Correct event reset type for the system event
 2019-06-19 22:27:52 -04:00
jonsn0w cbb3371437 Update content_archive.cpp 
log clutter in debug logs when theres really no need
 2019-06-19 22:01:41 -04:00
Lioncash 0b24f6f253 core: Remove unused CiTrace source files 
These source files have been unused for the entire lifecycle of the
project. They're a hold-over from Citra and only add to the build time
of the project, so they can be removed.

There's also likely no way this would ever work in yuzu in its current
form without revamping quite a bit of it, given how different the GPU on
the Switch is compared to the 3DS.
 2019-06-18 16:57:59 -04:00
Lioncash cedbb6ee41 service/audio/audren_u: Correct event reset type for the system event 
This is actually an auto-reset event in the audio service itself, not a
manual one.
 2019-06-18 09:23:20 -04:00
David Marcec 7b451419b4 Addressed issues 2019-06-17 08:17:26 +10:00
Fernando Sahmkow 16ee1b7006 Core_Timing: Make core_timing threadsafe by default. 
The old implementation had faulty Threadsafe methods where events could
be missing. This implementation unifies unsafe/safe methods and makes
core timing thread safe overall.
 2019-06-16 14:14:35 -04:00
David Marcec 622b25db6e Signalled accumulated_suspended_tick_changed_event on creation based on RE 2019-06-16 22:18:54 +10:00
David Marcec 9578a9a72d Cleanup 2019-06-16 20:18:35 +10:00
David Marcec 5f5f8c6341 Impl'd IsUserAccountSwitchLocked, SetAudioOutVolume, GetAudioOutVolume & Partial impl of GetAccumulatedSuspendedTickChangedEvent 
IPC-100 was changed to InitializeApplicationInfoOld instead of InitializeApplicationInfo. IPC-150 makes an indentical call to IPC-100 however does extra processing. They should not have the same name as it's quite confusing to debug.
 2019-06-16 19:06:33 +10:00
Zach Hilman aca05af798 Merge pull request #2581 from lioncash/hex 
common/hex_util: Combine HexVectorToString() and HexArrayToString()
 2019-06-15 16:47:13 -04:00
bunnei 6507034f95 Merge pull request #2582 from lioncash/reserved 
file_sys/ips_layer: Remove unnecessary reserve() call
 2019-06-14 11:24:18 -04:00
Zach Hilman 4c48b437f8 Merge pull request #2580 from lioncash/redundant 
kernel/vm_manager: Remove redundant Reset call in destructor
 2019-06-12 19:26:07 -04:00
Zach Hilman 3cf9150679 Merge pull request #2577 from lioncash/fs 
file_sys/card_image: Minor cleanup
 2019-06-12 19:23:33 -04:00
Lioncash af914546f2 file_sys/ips_layer: Remove unnecessary reserve() call 
Given 'replace' is assigned to on the following line, this isn't
necessary, given the underlying data is going to be overwritten
entirely.
 2019-06-12 18:12:45 -04:00
Lioncash 59d55c8137 common/hex_util: Combine HexVectorToString() and HexArrayToString() 
These can be generified together by using a concept type to designate
them. This also has the benefit of not making copies of potentially very
large arrays.
 2019-06-12 17:54:05 -04:00
Lioncash 14aca37172 file_sys/card_image: Remove obsolete TODO 
We already support Rev 1+.
 2019-06-12 16:52:19 -04:00
Lioncash b0fc1ae7bf kernel/vm_manager: Remove redundant Reset call in destructor 
This is performing more work than would otherwise be necessary during
VMManager's destruction. All we actually want to occur in this scenario
is for any allocated memory to be freed, which will happen automatically
as the VMManager instance goes out of scope.

Anything else being done is simply unnecessary work.
 2019-06-12 16:10:00 -04:00
Lioncash 348c03b1bd file_sys/nca_metadata: Update CNMT structures 
Names a few more entries in relevant structures. Information based off
SwitchBrew and my own RE.
 2019-06-10 23:51:06 -04:00
Lioncash c45be86d6e file_sys/card_image: Deduplicate casts within AddNCAFromPartition() 
Makes for nicer reading.
 2019-06-10 23:27:14 -04:00
Lioncash f5f9c52900 file_sys/card_image: Make bracing consistent 
Makes for more consistent reading.
 2019-06-10 23:27:13 -04:00
Lioncash 8bfb8e3dce file_sys/card_image: Assign collapsed NCA contents directly to ncas member 
Same thing, significantly less noisy.
 2019-06-10 23:27:13 -04:00
Lioncash 907c499608 file_sys/card_image: Deduplicate type cast 
Same thing, less duplication. We can also std::move raw into the
PartitionFilesystem constructor.
 2019-06-10 23:27:05 -04:00
Lioncash c305601f9b file_sys/card_image: Get rid of a magic number 
We can just use the size of the array to dehardcode it.
 2019-06-10 22:58:08 -04:00
Lioncash bfafb5f7d1 file_sys/card_image: Use std::array deduction guides 
Same thing, less code.
 2019-06-10 22:57:53 -04:00
Zach Hilman 3f221f8e3f kernel: Differentiate kernel and user processes when picking ID 
This allows kernel internal type processes to be assigned IDs in the KIP range while userland processes are assigned in the user range.
 2019-06-10 00:28:33 -04:00
Zach Hilman e62e715ac2 nsp: Correct status codes for extracted NSPs 
Avoids all extracted NSPs being marked as error file type because they don't have program NCAs.
 2019-06-10 00:21:41 -04:00
Zach Hilman 5231fb95e6 nsp: Use title ID from NPDM metadata for extracted type NSPs 
Avoids 0 being used as title ID for all extracted NSPs.
 2019-06-10 00:19:23 -04:00
Zach Hilman 0a624581b2 arm_dynarmic: Check if jit is nullptr when preparing reschedule 
Prevents crash with multiprocess loading.
 2019-06-10 00:14:25 -04:00
Zach Hilman 58c127c1d8 Merge pull request #2571 from lioncash/ref 
kernel/process: Make Create()'s name parameter be taken by value
 2019-06-09 20:43:57 -04:00
Lioncash 9f6aa8af4a kernel/process: Make Create()'s name parameter be taken by value 
Makes the interface more flexible in terms of how Create() may be
called, while still allowing the parameter itself to be moved into.
 2019-06-09 18:47:37 -04:00
Lioncash 3a22c12704 kernel/svc: Implement TotalMemoryUsedWithoutMmHeap/TotalMemoryAvailableWithoutMmHeap 
Given we don't currently implement the personal heap yet, the existing
memory querying functions are essentially doing what the memory querying
types introduced in 6.0.0 do.

So, we can build the necessary machinery over the top of those and just
use them as part of info types.
 2019-06-09 18:22:30 -04:00
Lioncash a331973720 kernel/svc: Amend naming for TotalMemoryUsage in svcGetInfo() 
Disambiguates and makes the name a little more consistent with
TotalPhysicalMemoryUsed.
 2019-06-09 18:12:05 -04:00
Lioncash 9f62c69fca kernel/svc: Remove duplicate enum entry in svcGetInfo() 2019-06-09 18:08:37 -04:00
Zach Hilman bf2e779efb constants: Extract backup JPEG used by account services 2019-06-07 17:46:57 -04:00
Zach Hilman 3c639f5ff1 Merge pull request #2514 from ReinUsesLisp/opengl-compat 
video_core: Drop OpenGL core in favor of OpenGL compatibility
 2019-06-07 17:23:25 -04:00
Zach Hilman ae00309771 kernel_executable: Optimize BLZ decompression 2019-06-06 19:20:15 -04:00
Zach Hilman 9a5dcd6e0f Merge pull request #2549 from lioncash/header 
kernel/process: Remove unused boost header include
 2019-06-06 14:31:46 -04:00
bunnei 69d0f742d8 Merge pull request #2551 from lioncash/dtor 
service/ns: Add missing override specifiers
 2019-06-06 10:37:28 -04:00
bunnei 958729a303 Merge pull request #2419 from DarkLordZach/srv-lr-iface 
lr: Add command handler skeletons for Open*LocationResolver
 2019-06-05 18:05:50 -04:00
Lioncash 783b996dcd service/ns: Add missing override specifiers 2019-06-05 16:20:24 -04:00
Zach Hilman 70c78f611b Merge pull request #2526 from lioncash/global 
core/telemetry_session: Remove usages of the global system accessor
 2019-06-05 15:57:48 -04:00
Zach Hilman 4facf2a3ee Merge pull request #2545 from lioncash/timing 
core/core_timing_util: Use std::chrono types for specifying time units
 2019-06-05 15:52:37 -04:00
Zach Hilman 28ca105671 Merge pull request #2510 from SciresM/desired_language 
Implement/Fix IApplicationFunctions::GetDesiredLanguage
 2019-06-05 15:39:33 -04:00
Lioncash c23f162111 kernel/process: Remove unused boost header include 
Boost headers typically include a lot of other headers, so removing this
can prevent a bit of unnecessary compiler churn when building.
 2019-06-05 14:03:29 -04:00
Zach Hilman 5f6dba8ece game_list: Accept *.kip as a file extension of executables 2019-06-05 00:33:05 -04:00
Zach Hilman fd67e22b25 loader: Add recognition for KIP file type 2019-06-05 00:22:07 -04:00
Zach Hilman ef42e591df loader: Add KIP and INI file parser-specific errors 2019-06-05 00:21:44 -04:00
Zach Hilman 6fb2fa51eb loader: Add AppLoader_KIP for KIP files 2019-06-05 00:21:17 -04:00
Zach Hilman 04a69eb6c7 program_metadata: Add function to load meta from raw parameters 
Needed for KIP loading as KIPs do not have an NPDM but do have the essential parts of the data within.
 2019-06-05 00:20:26 -04:00
Zach Hilman 8662c6d579 partition_data_manager: Remove KIP processing and use FileSys 
Previously, this TU contained the necessary headers to parse KIP/INI but now it should just use the FileSys class.
 2019-06-05 00:19:29 -04:00
Zach Hilman 48bb330ad1 file_sys: Add classes to parse KIP1 and INI1 files 2019-06-05 00:18:25 -04:00
Lioncash debd00b300 core/core_timing_util: Amend casing of cyclesTo* functions 
Makes the casing consistent with all of our general function naming
conventions.
 2019-06-04 20:31:46 -04:00
Lioncash 97882b84a8 core/core_timing_util: Use std::chrono types for specifying time units 
Makes the interface more type-safe and consistent in terms of return
values.
 2019-06-04 20:31:24 -04:00
Lioncash c5d6bd7f15 core/core_timing_utils: Simplify overload set 
Removes unused overloads, simplifying the overall interface,
deduplicating some code.
 2019-06-04 19:44:05 -04:00
Lioncash 564f80d4fd yuzu/bootmanager: Treat the resolution factor as a u32 
Treating it as a u16 can result in a sign-conversion warning when
performing arithmetic with it, as u16 promotes to an int when aritmetic
is performed on it, not unsigned int.

This also makes the interface more uniform, as the layout interface now
operates on u32 across the board.
 2019-06-03 15:34:31 -04:00
bunnei a42ca86140 Merge pull request #1931 from DarkLordZach/mii-database-1 
mii: Implement MiiManager backend and several mii service commands
 2019-05-30 13:26:40 -04:00
ReinUsesLisp b70a0ec46d rasterizer_opengl: Remove OpenGL core profile 2019-05-30 13:21:00 -03:00
bunnei cd85ef05c2 Merge pull request #2518 from ReinUsesLisp/sdl2-window 
yuzu_cmd: Split emu_window OpenGL implementation into its own file
 2019-05-29 11:01:12 -04:00
Lioncash 9ac89fde57 core/core: Remove unnecessary includes 
The contents of these includes aren't used anywhere in this translation
unit.
 2019-05-29 00:00:27 -04:00
Lioncash 7dd4fbf551 core/loader: Remove LoadKernelSystemMode 
This is a hold-over from Citra and doesn't apply to yuzu.
 2019-05-28 22:28:44 -04:00
Lioncash 5a776e5dc9 core/telemetry_session: Remove unnecessary web service nulling out in destructor 
This will automatically occur when the backend instance goes out of
scope at the end of the destructor's execution.
 2019-05-28 22:28:18 -04:00
Lioncash 5fe132ec98 core/telemetry_session: Remove usages of the global system accessor 
Makes the dependency explicit in the TelemetrySession's interface
instead of making it a hidden dependency.

This also revealed a hidden issue with the way the telemetry session was
being initialized. It was attempting to retrieve the app loader and log
out title-specific information. However, this isn't always guaranteed to
be possible.

During the initialization phase, everything is being constructed. It
doesn't mean an actual title has been selected. This is what the Load()
function is for. This potentially results in dead code paths involving
the app loader. Instead, we explicitly add this information when we know
the app loader instance is available.
 2019-05-28 22:28:15 -04:00
Lioncash 8174fa5f9d core/telemetry_session: Explicitly delete copy and move constructors 
NonCopyable is misleading here. It also makes the class non-moveable as
well, so we can be explicit about this.
 2019-05-28 21:07:38 -04:00
Lioncash f7180e3422 core/telemetry_session: Remove unused include 2019-05-28 20:56:22 -04:00
bunnei cf1d3d3e5f Merge pull request #2519 from lioncash/sign 
loader/nso, core/core_timing_util: Silence sign-comparison warning
 2019-05-27 12:26:17 -04:00
Zach Hilman 7b531ebaae ncm: Implement LR OpenAddOnContentLocationResolver (2) 
Returns an object of type IAddOnContentLocationResolver for the provided StorageId.
 2019-05-26 20:37:13 -04:00
Zach Hilman 2630a22608 ncm: Implement LR OpenRegisteredLocationResolver (1) 
Returns an object of type IRegisteredLocationResolver for the StorageId.
 2019-05-26 18:24:48 -04:00
Zach Hilman feeda71211 ncm: Implement LR OpenLocationResolver (0) 
Returns an object of type ILocationResolver with the provided StorageId.
 2019-05-26 18:24:48 -04:00
Zach Hilman 227430a157 loader: Move NSO module tracking to AppLoader 
Also cleanup of general stuff
 2019-05-26 11:40:46 -04:00
ReinUsesLisp 2410482b11 emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy 
There's no performance improvement in passing an unsigned pair by
reference.
 2019-05-26 00:54:13 -03:00
bunnei 4b08b2d0aa Merge pull request #2509 from lioncash/aoc 
service/aoc_u: Minor cleanup
 2019-05-25 23:00:12 -04:00
Lioncash e55ce09875 core_timing_util: Silence sign-comparison warnings 
We can just make the conversion explicit instead of implicit here to
silence -Wsign-compare warnings.
 2019-05-25 17:01:18 -04:00
Lioncash fc1d10d33a loader/nso: Silence sign-comparison warning 
This was previously performing a size_t == int comparison. Silences a
-Wsign-compare warning.
 2019-05-25 16:53:33 -04:00
Zach Hilman bdfb6260d5 prepo: Save reports from PlayReport service 
Logs a lot of seemingly innocuous telemetry games generate.
 2019-05-25 16:09:20 -04:00
Zach Hilman 1509f4921d fatal: Save report on fatal:u call 
Matches offical behavior with creport and replaces old log/text based report system.
 2019-05-25 16:09:20 -04:00
Zach Hilman 30368b0571 service: Save report on unimplemented function call 2019-05-25 16:09:20 -04:00
Zach Hilman f5659d962c applets/error: Save report on error applet 
This matches official behavior with the erpt/eclct/eupld service chain.
 2019-05-25 16:09:20 -04:00
Zach Hilman 0ab58dcc13 applets: Save report on stubbed applet 
This also reworks the applet data storage to be peekable.
 2019-05-25 16:09:20 -04:00
Zach Hilman 7c698b4f31 svc: Save report on call to svcBreak 2019-05-25 16:09:20 -04:00
Zach Hilman 8d16f91049 core: Add Reporter class to take/save reports 2019-05-25 16:09:20 -04:00
Zach Hilman a3c66e920b settings: Add 'Reporting Services' config option 
Full enable/disable for all reports.
 2019-05-25 16:09:20 -04:00
Zach Hilman a102ace3c5 arm_interface: Expand backtrace generation 
Returns results as a vector of entries for further processing. Logs addresses, offsets, and mangled name.
 2019-05-25 16:06:53 -04:00
Zach Hilman c1475193ba core: Track load offsets of NSO modules 
Needed for backtrace decomposition
 2019-05-25 16:06:53 -04:00
bunnei 3de4f9f305 Merge pull request #2489 from FearlessTobi/port-4716 
Port citra-emu/citra#4716: "HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread"
 2019-05-24 18:23:15 -04:00
Michael Scire 33290c231a Fix bitmask logic inversion 2019-05-23 02:37:13 -07:00
Michael Scire 6c068e4636 fix introduced clang-format errors 2019-05-23 01:39:22 -07:00
Michael Scire 35293a8285 Address review comments 2019-05-23 01:28:27 -07:00
Michael Scire 8fa667eab8 clang-format fixes 2019-05-23 01:14:11 -07:00
Michael Scire e417da5070 Implement IApplicationFunctions::GetDesiredLanguage 2019-05-23 00:55:56 -07:00
Lioncash 36df21b48e service/aoc: Avoid allocating and discarding data 
Previously, the code was accumulating data into a std::vector and then
tossing all of it away if a setting was disabled.

Instead, we can just check if it's disabled and do no work at all if
possible. If it's enabled, then we can append to the vector and
allocate.

Unlikely to impact usage much, but it is slightly less sloppy with
resources.
 2019-05-23 00:26:21 -04:00
Lioncash 77443d3e04 service/aoc: Remove unnecessary includes 
Removes two header dependencies related to file handling that aren't
actually used within the source file.
 2019-05-22 23:26:12 -04:00
Lioncash 73661cb309 service/aoc: Pop all passed values where applicable 
A few of the aoc service stubs/implementations weren't fully popping all
of the parameters passed to them. This ensures that all parameters are
popped and, at minimum, logged out.
 2019-05-22 23:24:27 -04:00
bunnei a72ef964b4 Merge pull request #2410 from lioncash/affinity 
kernel/svc: Reorganize and fix up the initial handling of svcSetThreadCoreMask()
 2019-05-19 13:59:52 -04:00
Hexagon12 5e517df3c7 Merge pull request #2439 from lioncash/audren 
service/audren_u: Get rid of magic values within GetAudioRendererWorkBufferSize
 2019-05-19 15:23:04 +01:00
Hexagon12 824fa78da3 Merge pull request #2463 from lioncash/set 
service/set: Correct and simplify behavior related to copying language codes
 2019-05-19 15:17:39 +01:00
Hexagon12 91bb4a62e1 Merge pull request #2487 from lioncash/service-return 
service/am: Add missing return in error case for IStorageAccessor's Read/Write()
 2019-05-19 14:59:40 +01:00
Hexagon12 48adf39929 Merge pull request #2490 from lioncash/float 
ipc_helpers: Amend floating-point type in Pop<double> specialization
 2019-05-19 14:50:30 +01:00
Sebastian Valle b42d727646 Merge pull request #2486 from lioncash/resetname 
core/kernel/object: Rename ResetType enum members for clarity
 2019-05-19 08:47:59 -05:00
Lioncash f768365cd5 ipc_helpers: Amend floating-point type in Pop<double> specialization 
Currently, this overload isn't used, so this wasn't actually hit in any
code, only the float overload is used.
 2019-05-18 22:05:33 -04:00
Tobias 24a4888514 Address review comment 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2019-05-19 02:14:30 +02:00
Lioncash 41ddec92eb kernel/svc: Mark GetThreadList() and UnmapProcessCodeMemory() as internally linked 
These are only used from within this translation unit, so they don't
need to have external linkage. They were intended to be marked with this
anyways to be consistent with the other service functions.
 2019-05-18 19:10:34 -04:00
Lioncash c7bf8c677c service/am: Add missing return in error case for IStorageAccessor's Read()/Write(). 
Previously this would fall through and return successfully, despite
being an out of bounds read or write.
 2019-05-18 18:50:04 -04:00
Lioncash 45d71eed4f core/kernel/object: Rename ResetType enum members 
Renames the members to more accurately indicate what they signify.
"OneShot" and "Sticky" are kind of ambiguous identifiers for the reset
types, and can be kind of misleading. Automatic and Manual communicate
the kind of reset type in a clearer manner. Either the event is
automatically reset, or it isn't and must be manually cleared.

The "OneShot" and "Sticky" terminology is just a hold-over from Citra
where the kernel had a third type of event reset type known as "Pulse".
Given the Switch kernel only has two forms of event reset types, we
don't need to keep the old terminology around anymore.
 2019-05-18 15:52:51 -04:00
Weiyi Wang 9d47890fce HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread 
This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)
 2019-05-18 19:53:39 +02:00
Lioncash 7593c20034 service/set: Correct and simplify behavior related to copying language codes 
This corrects cases where it was possible to write more entries into the
write buffer than were requested. Now, we check the size of the buffer
before actually writing into them.

We were also returning the wrong value for
GetAvailableLanguageCodeCount2(). This was previously returning 64, but
only 17 should have been returned. 64 entries is the size of the static
array used in MakeLanguageCode() within the service binary itself, but
isn't the actual total number of language codes present.
 2019-05-09 21:28:36 -04:00
bunnei 991e6a74fd Merge pull request #2437 from lioncash/audctl 
service/audctl: Update documentation comments to be relative to 8.0.0
 2019-05-09 13:24:13 -04:00
bunnei 64126891e0 Merge pull request #2445 from FearlessTobi/port-4749 
Port citra-emu/citra#4749: "web_service: Misc fixes"
 2019-05-09 13:22:00 -04:00
bunnei f34e0d232b Merge pull request #2453 from lioncash/enum 
core/memory: Remove unused FlushMode enum
 2019-05-09 13:19:49 -04:00
Lioncash 644ee565ff core/memory: Remove unused FlushMode enum 
Recent changes to memory-related code resulted in this being unused, so
we can remove it.
 2019-05-07 13:55:17 -04:00
zhupengfei 19dec95663 core/telemetry_session: Only create the backend when we really need it 
The backend is not used until we decide to submit the testcase/telemetry, and creating it early prevents users from updating the credentials properly while the games are running.
 2019-05-04 19:45:48 +02:00
Lioncash 6f1d39e2e5 core/frontend/emu_window: Make GraphicsContext's destructor virtual 
This class is used in a polymorphic context, so destruction of the
context will lead to undefined behavior if the destructor isn't virtual.
 2019-05-04 01:47:38 -04:00
Lioncash f3a7682e43 service/audren_u: Handle variadic command buffers in GetWorkBufferSize() 
Also introduced in REV5 was a variable-size audio command buffer. This
also affects how the size of the work buffer should be determined, so we
can add handling for this as well.

Thankfully, no other alterations were made to how the work buffer size
is calculated in 7.0.0-8.0.0. There were indeed changes made to to how
some of the actual audio commands are generated though (particularly in
REV7), however they don't apply here.
 2019-04-30 23:52:28 -04:00
Lioncash f3f9929f02 service/audren_u: Handle version 2 of performance frame info in GetWorkBufferSize() 
Introduced in REV5. This is trivial to add support for, now that
everything isn't a mess of random magic constant values.

All this is, is a change in data type sizes as far as this function
cares.
 2019-04-30 23:52:28 -04:00
Lioncash 6904141f18 service/audren_u: Clean up work buffer calculations 
"Unmagics" quite a few magic constants within this code, making it much
easier to understand. Particularly given this factors out specific
sections into their own self-contained lambda functions.
 2019-04-30 23:51:59 -04:00
Lioncash 32b833632b loader/nso: Remove left-in debug pragma 
Unintentionally introduced in d6744d9b06
 2019-04-30 22:55:53 -04:00
Lioncash 762b6e4006 kernel/svc: Make svcCreateThread/svcStartThread/svcSleepThread/svcExitThread calls show up in the debug log 
These are actually quite important indicators of thread lifetimes, so
they should be going into the debug log, rather than being treated as
misc info and delegated to the trace log.
 2019-04-29 01:38:27 -04:00
Lioncash 6112c4da0a kernel/svc: Reorganize svcSetThreadCoreMask() 
Makes the code much nicer to follow in terms of behavior and control
flow. It also fixes a few bugs in the implementation.

Notably, the thread's owner process shouldn't be accessed in order to
retrieve the core mask or ideal core. This should be done through the
current running process. The only reason this bug wasn't encountered yet
is because we currently only support running one process, and thus every
owner process will be the current process.

We also weren't checking against the process' CPU core mask to see if an
allowed core is specified or not.

With this out of the way, it'll be less noisy to implement proper
handling of the affinity flags internally within the kernel thread
instances.
 2019-04-29 01:38:27 -04:00
Lioncash 9f8d31a803 kernel/thread: Update thread processor ID flags 
Adds the missing flags to the enum and documents them.
 2019-04-29 01:37:51 -04:00
bunnei ea7ba8c6fe Merge pull request #2412 from lioncash/system 
kernel/vm_manager: Remove usages of global system accessors
 2019-04-28 22:27:14 -04:00
Lioncash 73c7c9cb21 service/audctl: Update documentation comments to be relative to 8.0.0 
The state of these service calls are still the same in version 8.0.0.
 2019-04-27 23:17:58 -04:00
Zach Hilman 6fca6e20c9 mii_manager: Fix incorrect loop condition in mii UUID generation code 2019-04-25 08:57:23 -04:00
Zach Hilman ad5e497bff profile_select: Port Service::Account::UUID to Common::UUID 2019-04-25 08:13:11 -04:00
Zach Hilman 9572ff6c55 mii: Implement Delete and Destroy file 2019-04-25 08:07:57 -04:00
Zach Hilman 42c3c73acc mii: Implement IsUpdated command (IPC 0) 2019-04-25 08:07:57 -04:00
Zach Hilman b4759039c0 mii_manager: Cleanup and optimization 2019-04-25 08:07:57 -04:00
Zach Hilman 27878d7520 mii: Implement IDatabaseService commands using MiiManager 
Since the MiiManager was designed around the IPC interface, this is quite easy. Only functions that were clearly defined were implemented.
 2019-04-25 08:07:57 -04:00
Zach Hilman 1ea64ba727 mii: Add MiiManager class to manage Mii database 
Provides serialization/deserialization to the database in system save files, accessors for database state and proper handling of both major Mii formats (MiiInfo and MiiStoreData)
 2019-04-25 08:07:57 -04:00
Zach Hilman c02cb054b7 common: Extract UUID to its own class 
Since the Mii database uses UUIDs very similar to the Accounts database, it makes no sense to not share code between them.
 2019-04-25 08:07:57 -04:00
bunnei 5d81402331 Merge pull request #2416 from lioncash/wait 
kernel/svc: Clean up wait synchronization related functionality
 2019-04-24 22:56:08 -04:00
bunnei 7deb029743 Merge pull request #2424 from FernandoS27/compat 
Allow picking a Compatibility Profile for OpenGL.
 2019-04-24 22:54:27 -04:00
bunnei 39d7115730 Merge pull request #2228 from DarkLordZach/applet-manager-p1 
applets: Add AppletManager and implement PhotoViewer and Error applets
 2019-04-24 22:53:21 -04:00
bunnei 00bfde8af6 Merge pull request #2420 from lioncash/audctl 
service/audctl: Implement GetTargetVolumeMin() and GetTargetVolumeMax()
 2019-04-22 22:12:48 -04:00
Fernando Sahmkow b437d4abd7 Allow picking a Compatibility Profile for OpenGL. 
This option allows picking the compatibility profile since a lot of bugs
are fixed in it. We devs will use this option to easierly debug current
problems in our Core implementation.:wq
 2019-04-20 00:05:24 -04:00
bunnei df2b3d224e Merge pull request #2415 from lioncash/const 
kernel/wait_object: Make GetHighestPriorityReadyThread() a const member function
 2019-04-19 19:12:02 -04:00
bunnei 0e5bbfcfb3 Merge pull request #2421 from lioncash/svc-call 
kernel/svc: Name supervisor call 0x36
 2019-04-19 19:10:20 -04:00
bunnei 986bff9c74 Merge pull request #2374 from lioncash/pagetable 
core: Reorganize boot order
 2019-04-19 19:09:20 -04:00
Lioncash 154995bbe6 kernel/svc: Name supervisor call 0x36 
This call was added to the SVC handlers in the 8.0.0 kernel, so we can
finally give it a name.
 2019-04-19 14:34:56 -04:00
Lioncash f408606b79 service/audctl: Implement GetTargetVolumeMin() and GetTargetVolumeMax() 
These two service functions are literally hardcoded to always return
these values without any other error checking.
 2019-04-18 16:39:54 -04:00
bunnei 26cbd2fc3d Merge pull request #2397 from lioncash/thread-unused 
kernel/thread: Remove unused guest_handle member variable
 2019-04-17 21:46:46 -04:00
Zach Hilman 107d725af8 web_browser: Make OpenPage non-const 2019-04-17 11:35:24 -04:00
Zach Hilman 25f33928fc main: Add GMainWindow hooks for Error display 2019-04-17 11:35:24 -04:00
Zach Hilman 44eb5c65e8 general_backend: Move StubApplet and add backend PhotoViewer 2019-04-17 11:35:24 -04:00
Zach Hilman a8dbc0e299 general_frontend: Add frontend scaffold for PhotoViewer applet 2019-04-17 11:35:24 -04:00
Zach Hilman 93cbd91f56 frontend: Add frontend receiver for Error applet 2019-04-17 11:35:24 -04:00
Zach Hilman 252ac62306 applets: Add Error applet 
Responsible for displaying error codes and messages
 2019-04-17 11:35:24 -04:00
Zach Hilman fdd0152436 applets: Port current applets to take frontend in constructor 
As opposed to using Core::System::GetInstance()
 2019-04-17 11:35:24 -04:00
Zach Hilman 663b24e0d2 web_browser: Make OpenPage const 2019-04-17 11:35:24 -04:00
Zach Hilman 4399df50e3 core: Remove specific applets in favor of AppletManager 2019-04-17 11:35:24 -04:00
Zach Hilman a9a140d583 am: Delegate applet creation to AppletManager 2019-04-17 11:35:24 -04:00
Zach Hilman 4803c64bab applets: Add AppletManager class to control lifetime 2019-04-17 11:35:24 -04:00
Lioncash b12ed4aba9 kernel/thread: Unify wait synchronization types 
This is a holdover from Citra, where the 3DS has both
WaitSynchronization1 and WaitSynchronizationN. The switch only has one
form of wait synchronizing (literally WaitSynchonization). This allows
us to throw out code that doesn't apply at all to the Switch kernel.

Because of this unnecessary dichotomy within the wait synchronization
utilities, we were also neglecting to properly handle waiting on
multiple objects.

While we're at it, we can also scrub out any lingering references to
WaitSynchronization1/WaitSynchronizationN in comments, and change them
to WaitSynchronization (or remove them if the mention no longer
applies).
 2019-04-17 09:30:56 -04:00
Lioncash 4be897daa0 kernel/svc: Migrate svcCancelSynchronization behavior to a thread function 
The actual behavior of this function is slightly more complex than what
we're currently doing within the supervisor call. To avoid dumping most
of this behavior in the supervisor call itself, we can migrate this to
another function.
 2019-04-17 09:30:56 -04:00
Lioncash 4be40a434b kernel/wait_object: Make GetHighestPriorityReadyThread() a const member function 
This doesn't actually modify internal state of a wait object, so it can
be const qualified.
 2019-04-17 06:44:34 -04:00
Lioncash 6a42862a16 kernel/vm_manager: Remove usages of global system accessors 
Makes the dependency on the system instance explicit within VMManager's
interface.
 2019-04-16 20:02:50 -04:00
bunnei d41d65dd10 Merge pull request #2382 from lioncash/table 
service: Update service function tables
 2019-04-15 21:46:15 -04:00
bunnei 3c817b0304 Merge pull request #2393 from lioncash/svc 
kernel/svc: Implement svcMapProcessCodeMemory/svcUnmapProcessCodeMemory
 2019-04-15 21:43:56 -04:00
Lioncash 4902eb4d01 svc: Specify handle value in thread's name 
Allows the handle to be seen alongside the entry point.
 2019-04-15 15:56:18 -04:00
Lioncash 78571c84b3 kernel/thread: Remove BoostPriority() 
This is a holdover from Citra that currently remains unused, so it can
be removed from the Thread interface.
 2019-04-15 06:59:19 -04:00
Lioncash 6baebc3d41 kernel/thread: Remove unused guest_handle member variable 
This member variable is entirely unused. It was only set but never
actually utilized. Given that, we can remove it to get rid of noise in
the thread interface.
 2019-04-14 06:06:06 -04:00
bunnei c6fff9d12c Merge pull request #2378 from lioncash/ro 
ldr: Minor amendments to IPC-related parameters
 2019-04-13 22:16:10 -04:00
bunnei 7b12d8d511 Merge pull request #2357 from zarroboogs/force-30fps-mode 
Add a toggle to force 30FPS mode
 2019-04-13 22:14:04 -04:00
bunnei d75fb5713f Merge pull request #2381 from lioncash/fs 
fsp_srv: Minor cleanup related changes
 2019-04-13 22:09:58 -04:00
bunnei 116f65a527 Merge pull request #2017 from jroweboy/glwidget 
Frontend: Migrate to QOpenGLWindow and support shared contexts
 2019-04-13 22:08:40 -04:00
Lioncash 97ccd45bb4 kernel/svc: Implement svcUnmapProcessCodeMemory 
Essentially performs the inverse of svcMapProcessCodeMemory. This unmaps
the aliasing region first, then restores the general traits of the
aliased memory.

What this entails, is:

- Restoring Read/Write permissions to the VMA.
- Restoring its memory state to reflect it as a general heap memory region.
- Clearing the memory attributes on the region.
 2019-04-12 21:56:03 -04:00
Lioncash 0b1ffc40a7 kernel/svc: Implement svcMapProcessCodeMemory 
This is utilized for mapping code modules into memory. Notably, the
ldr service would call this in order to map objects into memory.
 2019-04-12 21:55:50 -04:00
Lioncash e49ee38660 core/core: Move process execution start to System's Load() 
This gives us significantly more control over where in the
initialization process we start execution of the main process.

Previously we were running the main process before the CPU or GPU
threads were initialized (not good). This amends execution to start
after all of our threads are properly set up.
 2019-04-11 22:11:41 -04:00
Lioncash 67744e08c9 core/process: Remove unideal page table setting from LoadFromMetadata() 
Initially required due to the split codepath with how the initial main
process instance was initialized. We used to initialize the process
like:

Init() {
    main_process = Process::Create(...);
    kernel.MakeCurrentProcess(main_process.get());
}

Load() {
    const auto load_result = loader.Load(*kernel.GetCurrentProcess());
    if (load_result != Loader::ResultStatus::Success) {
        // Handle error here.
    }
    ...
}

which presented a problem.

Setting a created process as the main process would set the page table
for that process as the main page table. This is fine... until we get to
the part that the page table can have its size changed in the Load()
function via NPDM metadata, which can dictate either a 32-bit, 36-bit,
or 39-bit usable address space.

Now that we have full control over the process' creation in load, we can
simply set the initial process as the main process after all the loading
is done, reflecting the potential page table changes without any
special-casing behavior.

We can also remove the cache flushing within LoadModule(), as execution
wouldn't have even begun yet during all usages of this function, now
that we have the initialization order cleaned up.
 2019-04-11 22:11:41 -04:00
Lioncash 3cfaddba85 core/core: Move main process creation into Load() 
Now that we have dependencies on the initialization order, we can move
the creation of the main process to a more sensible area: where we
actually load in the executable data.

This allows localizing the creation and loading of the process in one
location, making the initialization of the process much nicer to trace.
 2019-04-11 22:11:40 -04:00
Lioncash e0962940a2 video_core/gpu: Create threads separately from initialization 
Like with CPU emulation, we generally don't want to fire off the threads
immediately after the relevant classes are initialized, we want to do
this after all necessary data is done loading first.

This splits the thread creation into its own interface member function
to allow controlling when these threads in particular get created.
 2019-04-11 22:11:40 -04:00
Lioncash 567b7de124 core/cpu_core_manager: Create threads separately from initialization. 
Our initialization process is a little wonky than one would expect when
it comes to code flow. We initialize the CPU last, as opposed to
hardware, where the CPU obviously needs to be first, otherwise nothing
else would work, and we have code that adds checks to get around this.

For example, in the page table setting code, we check to see if the
system is turned on before we even notify the CPU instances of a page
table switch. This results in dead code (at the moment), because the
only time a page table switch will occur is when the system is *not*
running, preventing the emulated CPU instances from being notified of a
page table switch in a convenient manner (technically the code path
could be taken, but we don't emulate the process creation svc handlers
yet).

This moves the threads creation into its own member function of the core
manager and restores a little order (and predictability) to our
initialization process.

Previously, in the multi-threaded cases, we'd kick off several threads
before even the main kernel process was created and ready to execute (gross!).
Now the initialization process is like so:

Initialization:
  1. Timers

  2. CPU

  3. Kernel

  4. Filesystem stuff (kind of gross, but can be amended trivially)

  5. Applet stuff (ditto in terms of being kind of gross)

  6. Main process (will be moved into the loading step in a following
                   change)

  7. Telemetry (this should be initialized last in the future).

  8. Services (4 and 5 should ideally be alongside this).

  9. GDB (gross. Uses namespace scope state. Needs to be refactored into a
          class or booted altogether).

  10. Renderer

  11. GPU (will also have its threads created in a separate step in a
           following change).

Which... isn't *ideal* per-se, however getting rid of the wonky
intertwining of CPU state initialization out of this mix gets rid of
most of the footguns when it comes to our initialization process.
 2019-04-11 22:11:40 -04:00
bunnei 7cd9b3b805 Merge pull request #2360 from lioncash/svc-global 
kernel/svc: Deglobalize the supervisor call handlers
 2019-04-11 21:50:05 -04:00
bunnei 64bd271e7c Merge pull request #2388 from lioncash/constexpr 
kernel: Make handle type declarations constexpr
 2019-04-11 21:49:45 -04:00
Lioncash 255a6c6f4b kernel: Make handle type declarations constexpr 
Some objects declare their handle type as const, while others declare it
as constexpr. This makes the const ones constexpr for consistency, and
prevent unexpected compilation errors if these happen to be attempted to be
used within a constexpr context.
 2019-04-11 16:34:53 -04:00
Lioncash 14ead4ceb0 service: Update service function tables 
Updates function tables based off information from SwitchBrew.
 2019-04-11 02:47:00 -04:00
Lioncash d0484bc83d ldr: Mark IsValidNROHash() as a const member function 
This doesn't modify instance state, so it can be made const.
 2019-04-10 15:57:02 -04:00
Lioncash 5e0b8ed169 ldr: Amend parameters for LoadNro/UnloadNro LoadNrr/UnloadNrr 
The initial two words indicate a process ID. Also UnloadNro only
specifies one address, not two.
 2019-04-10 15:56:43 -04:00
Lioncash 591d12d34b fsp_srv: Remove unnecessary parameter popping in IDirectory's Read() 
IDirectory's Read() function doesn't take any input parameters. It only
uses the output parameters that we already provide.
 2019-04-10 13:04:08 -04:00
Lioncash 630d841435 fsp_srv: Log out option values in IFile's Read and Write functions 
These indicate options that alter how a read/write is performed.

Currently we don't need to handle these, as the only one that seems to
be used is for writes, but all the custom options ever seem to do is
immediate flushing, which we already do by default.
 2019-04-10 13:01:52 -04:00
Lioncash c7d85ae11e kernel/server_session: Remove obsolete TODOs 
These are holdovers from Citra.
 2019-04-09 23:34:49 -04:00
bunnei 53c9e7aab2 Merge pull request #1957 from DarkLordZach/title-provider 
file_sys: Provide generic interface for accessing game data
 2019-04-09 19:16:37 -04:00
Lioncash 9e3d4595b7 kernel/process: Set page table when page table resizes occur. 
We need to ensure dynarmic gets a valid pointer if the page table is
resized (the relevant pointers would be invalidated in this scenario).

In this scenario, the page table can be resized depending on what kind
of address space is specified within the NPDM metadata (if it's
present).
 2019-04-09 13:00:56 -04:00
zarroboogs 77bc4d1bd9 added a toggle to force 30fps mode 2019-04-09 02:14:03 +03:00
Lioncash 43e9b334af kernel/svc: Deglobalize the supervisor call handlers 
Adjusts the interface of the wrappers to take a system reference, which
allows accessing a system instance without using the global accessors.

This also allows getting rid of all global accessors within the
supervisor call handling code. While this does make the wrappers
themselves slightly more noisy, this will be further cleaned up in a
follow-up. This eliminates the global system accessors in the current
code while preserving the existing interface.
 2019-04-07 20:30:05 -04:00
bunnei d0146b9856 Merge pull request #2361 from lioncash/pagetable 
core/memory: Minor simplifications to page table management
 2019-04-07 17:50:31 -04:00
bunnei be75b51381 Merge pull request #2356 from lioncash/pair 
kernel/{server_port, server_session}: Return pairs instead of tuples from pair creation functions
 2019-04-07 17:48:00 -04:00
Lioncash 024bdfdc08 core/memory: Remove unused enum constants 
These are holdovers from Citra and can be removed.
 2019-04-07 03:04:55 -04:00
Lioncash 08424ab57f core/memory: Remove GetCurrentPageTable() 
Now that nothing actually touches the internal page table aside from the
memory subsystem itself, we can remove the accessor to it.
 2019-04-07 02:47:37 -04:00
Lioncash c1a788780d arm/arm_dynarmic: Remove unnecessary current_page_table member 
Given the page table will always be guaranteed to be that of whatever
the current process is, we no longer need to keep this around.
 2019-04-07 02:43:51 -04:00
Lioncash 6a929c3a2c kernel: Handle page table switching within MakeCurrentProcess() 
Centralizes the page table switching to one spot, rather than making
calling code deal with it everywhere.
 2019-04-07 01:12:54 -04:00
Lioncash bfbadb38be kernel/server_session: Return a std::pair from CreateSessionPair() 
Keeps the return type consistent with the function name. While we're at
it, we can also reduce the amount of boilerplate involved with handling
these by using structured bindings.
 2019-04-06 01:42:03 -04:00
Lioncash 05243b3041 kernel/server_port: Return a std::pair from CreatePortPair() 
Returns the same type that the function name describes.
 2019-04-06 01:36:53 -04:00
bunnei eccdc91fe0 Merge pull request #2325 from lioncash/name 
kernel/server_session: Provide a GetName() override
 2019-04-05 23:48:13 -04:00
bunnei 851f7f9e85 Merge pull request #2240 from FearlessTobi/port-4651 
Port citra-emu/citra#4651: "gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB."
 2019-04-05 23:46:37 -04:00
bunnei 2ad085e283 Merge pull request #2340 from lioncash/view 
file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash
 2019-04-05 23:40:16 -04:00
bunnei 21b4a904f4 Merge pull request #2334 from lioncash/override 
core: Add missing override specifiers where applicable
 2019-04-05 23:39:52 -04:00
bunnei 980c16b58f Merge pull request #2341 from lioncash/compare 
file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType
 2019-04-05 23:38:37 -04:00
bunnei 41cc5be7b8 Merge pull request #2339 from lioncash/rank 
service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs
 2019-04-05 23:36:46 -04:00
bunnei f8e61f4754 Merge pull request #2343 from lioncash/todo 
file_sys/program_metadata: Remove obsolete TODOs
 2019-04-05 23:35:54 -04:00
bunnei 7d633809d6 Merge pull request #2329 from lioncash/sanitize 
kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic
 2019-04-05 23:35:06 -04:00
bunnei 4d0f125786 Merge pull request #2344 from lioncash/result 
hle/result: Remove unnecessary bitfield entry for ResultCode
 2019-04-05 23:34:42 -04:00
Lioncash 3910871dd8 hle/result: Remove unnecessary bitfield entry for ResultCode 
This is a hold over from the 3DS error codes in Citra.
 2019-04-05 16:34:34 -04:00
Lioncash 633d55d503 file_sys/program_metadata: Remove obsolete TODOs 
BitField has been trivially copyable since
b20657a36f, so we can eliminate these
TODO comments and use ReadObject() directly instead of memcpying the
data.
 2019-04-05 15:57:47 -04:00
Lioncash 0359cba0f3 file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType 
enum class elements from the same enum can already be compared against
one another without the need for explicitly defined comparison
operators.
 2019-04-05 15:20:07 -04:00
Lioncash d7f670204b file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash() 
The given string instance doesn't need to be copied entirely, we can
just use a view instead.
 2019-04-05 15:12:20 -04:00
Lioncash 7d93ed3f70 service/fsp_srv: Don't pass SaveDataDescriptor instances by value. 
Passing around a 64 byte data struct by value is kind of wasteful,
instead pass a reference to the struct.
 2019-04-05 11:04:01 -04:00
Lioncash 7192c8703b service/fsp_srv: Remove unnecessary unknown member in OpenSaveDataFileSystem 
The unknown member here is actually padding due to being passed as a
struct. We can do the same, and remove the need to pop a padding word.
 2019-04-05 11:04:01 -04:00
Lioncash 90abd76bd9 service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs 
I realized that I updated the documentation on SwitchBrew a while ago,
but never actually updated the structs within yuzu.
 2019-04-05 11:03:53 -04:00
bunnei 5c0f43b29b Merge pull request #2338 from lioncash/fs 
filesystem: Use a std::string_view in OpenFile()
 2019-04-05 10:52:54 -04:00
bunnei d85b454fdd Merge pull request #2292 from lioncash/nacp 
file_sys/control_metadata: Amend naming of members
 2019-04-04 22:37:42 -04:00
Lioncash f1694034e8 filesystem: Use a std::string_view in OpenFile() 
Rather than make a full copy of the path, we can just use a string view
and truncate the viewed portion of the string instead of creating a totally
new truncated string.
 2019-04-04 20:59:00 -04:00
Lioncash 9ae176d921 hle/service: Resolve unused variable warnings 
In several places, we have request parsers where there's nothing to
really parse, simply because the HLE function in question operates on
buffers. In these cases we can just remove these instances altogether.

In the other cases, we can retrieve the relevant members from the parser
and at least log them out, giving them some use.
 2019-04-04 13:18:09 -04:00
Lioncash e1391a8268 core: Add missing override specifiers where applicable 
Applies the override specifier where applicable. In the case of
destructors that are  defaulted in their definition, they can
simply be removed.

This also removes the unnecessary inclusions being done in audin_u and
audrec_u, given their close proximity.
 2019-04-04 12:19:44 -04:00
bunnei 2e4cd9a9d9 Merge pull request #2328 from lioncash/transfer 
service/am: Correct behavior of CreateTransferMemoryStorage()
 2019-04-03 21:54:32 -04:00
bunnei c92c6f2d5b Merge pull request #2093 from FreddyFunk/disk-cache-better-compression 
Better LZ4 compression utilization for the disk based shader cache and the yuzu build system
 2019-04-03 21:50:29 -04:00
bunnei ce37b4cd69 Merge pull request #2324 from lioncash/enum-unused 
kernel/object: Remove unused handle type entry
 2019-04-03 21:47:09 -04:00
Lioncash 74c41c4095 file_sys/control_metadata: Amend naming of members 
Quite a bit of these were out of sync with Switchbrew (and in some cases
entirely wrong). While we're at it, also expand the section of named
members. A segment within the control metadata is used to specify
maximum values for the user, device, and cache storage max sizes and
journal sizes.

These appear to be generally used by the am service (e.g. in
CreateCacheStorage, etc).
 2019-04-03 21:18:12 -04:00
Lioncash e521d9b2f8 kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic 
We need to be checking whether or not the given address is within the
kernel address space or if the given address isn't word-aligned and bail
in these scenarios instead of trashing any kernel state.
 2019-04-03 20:25:41 -04:00
Lioncash e9aed6df26 service/am: Correct behavior of CreateTransferMemoryStorage() 
For whatever reason, shared memory was being used here instead of
transfer memory, which (quite clearly) will not work based off the name
of the function.

This corrects this wonky usage of shared memory.
 2019-04-03 17:49:21 -04:00
Lioncash 7f00a5406c kernel/transfer_memory: Add accessors to data and sizes 
Also amend erroneous use of size_t. We should be using u64 here.
 2019-04-03 17:49:16 -04:00
bunnei ed6b273c83 Merge pull request #2294 from lioncash/fatal 
service/am: Implement EnterFatalSection/LeaveFatalSection
 2019-04-03 12:12:07 -04:00