null/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden synced 2026-05-06 14:18:16 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
8045 commits 166 branches 24 tags 189 MiB
Commit graph

6797 commits

Author SHA1 Message Date
Lioncash 0170c296f2 renderer_base: Remove unused kFramebuffer enumeration 
This is entirely unused and can be removed.
 2018-08-10 18:31:13 -04:00
Lioncash 6e352a55d5 video_core: Remove unused Renderer enumeration 
Currently we only have an OpenGL renderer, so this is unused in code
(and occupies the Renderer identifier in the VideoCore namespace).
 2018-08-10 18:27:40 -04:00
Lioncash bc6245290b qt/game_list: Resolve truncation warning within GameListItemPath's constructor 
Silences a warning about truncating from size_t to u32
 2018-08-10 18:19:44 -04:00
Lioncash 89aed5c0a2 gt/game_list: Use std::array in GameListItemPath's data() function 
We don't need to use a heap-allocated std::vector here, given we
explicitly know the bounds.
 2018-08-10 18:19:40 -04:00
Lioncash 1eaa022169 qt/game_list: Remove redundant base class constructor from initializer list 
This is called automatically anyways.
 2018-08-10 18:17:39 -04:00
bunnei e210c31bb9 maxwell_to_gl: Implement VertexAttribute::Size::Size_8_8. 
- Used by Super Mario Odyssey.
 2018-08-10 12:47:00 -04:00
bunnei 9502d85a2d maxwell_to_gl: Implement VertexAttribute::Size::Size_32_32_32. 
- Used by Super Mario Odyssey.
 2018-08-10 12:46:49 -04:00
bunnei f87b1c73f4 Merge pull request #1004 from lioncash/unused 
gl_rasterizer_cache: Remove unused viewport parameter of GetFramebufferSurfaces()
 2018-08-10 12:13:32 -04:00
bunnei ca79bac393 Merge pull request #1008 from yuzu-emu/revert-697-disable-depth-cull 
Revert "gl_state: Temporarily disable culling and depth test."
 2018-08-10 12:13:09 -04:00
bunnei 32be28cc04 Revert "gl_state: Temporarily disable culling and depth test." 2018-08-10 10:39:46 -04:00
Zach Hilman 9946a70305 game_list: Reorder error checks 
clang-format fix
 2018-08-09 21:37:35 -04:00
Zach Hilman da921ac3f3 loader: Add more descriptive errors 
Full list of new errors and descriptions in core/loader/loader.h
 2018-08-09 21:06:59 -04:00
Lioncash 37d4b37ec4 gl_rasterizer_cache: Remove unused viewport parameter of GetFramebufferSurfaces() 2018-08-09 20:55:41 -04:00
Lioncash b206ee3957 video_core: Use variable template variants of type_traits interfaces where applicable 2018-08-09 20:45:48 -04:00
bunnei 1a9b133715 textures: Refactor out for Texture/Depth FormatFromPixelFormat. 2018-08-09 20:36:03 -04:00
bunnei e6dfe2f2ce Merge pull request #995 from bunnei/gl-buff-bounds 
gl_rasterizer_cache: Add bounds checking for gl_buffer copies.
 2018-08-09 20:23:30 -04:00
bunnei d8d75f37c6 Merge pull request #997 from lioncash/const-func 
core: Make function reference parameters const where applicable
 2018-08-09 19:30:51 -04:00
bunnei 78503bab9d Merge pull request #989 from lioncash/log 
common/logging: Add missing service log categories
 2018-08-09 19:30:14 -04:00
bunnei 922cd52f4b Merge pull request #990 from lioncash/entry 
fsp_srv: Emplace entries first when building index instead of emplacing last
 2018-08-09 19:29:36 -04:00
bunnei 1887739a29 Merge pull request #1001 from lioncash/reserve 
gl_shader_decompiler: Reserve element memory beforehand in BuildRegisterList()
 2018-08-09 19:27:35 -04:00
bunnei ba6e31c624 Merge pull request #897 from DarkLordZach/vfs-accuracy-2 
vfs: Add VfsFilesystem and fix RealVfs* implementations
 2018-08-09 19:22:06 -04:00
bunnei 9509b68082 gl_rasterizer_cache: Add bounds checking for gl_buffer copies. 2018-08-09 19:20:17 -04:00
bunnei 24d1b4653a Merge pull request #991 from bunnei/ignore-mac 
maxwell_3d: Ignore macros that have not been uploaded yet.
 2018-08-09 19:16:28 -04:00
Khangaroo 0dc1f660e5 Implement SNORM for BC5/DXN2 (#998) 
* Implement BC5/DXN2 (#996)

- Used by Kirby Star Allies.

* Implement BC5/DXN2 SNORM

UNORM for Kirby Star Allies
SNORM for Super Mario Odyssey
 2018-08-09 19:15:32 -04:00
Lioncash f52fb79b19 gl_shader_decompiler: Reserve element memory beforehand in BuildRegisterList() 
Avoids potentially perfoming multiple reallocations when we know the
total amount of memory we need beforehand.
 2018-08-09 17:29:11 -04:00
Lioncash 0280e22679 gl_rasterizer_cache: Avoid iterator invalidation issues within InvalidateRegion() 
A range-based for loop can't be used when the container being iterated
is also being erased from.
 2018-08-09 15:30:20 -04:00
bunnei c984e79040 Merge pull request #992 from bunnei/declr-pred 
gl_shader_decompiler: Declare predicates on use.
 2018-08-09 14:36:52 -04:00
bunnei 346767d393 Merge pull request #994 from lioncash/const 
gl_rasterizer_cache: Use std::vector::assign vs resize() then copy for the non-tiled case
 2018-08-09 14:36:06 -04:00
bunnei af45d92e4b Merge pull request #993 from bunnei/smo-vtx-pts 
Implement VertexAttribute::Size::Size_16_16_16_16 and PrimitiveTopology::Points.
 2018-08-09 13:28:14 -04:00
bunnei 64fb5846e7 Merge pull request #984 from bunnei/rt-none 
gl_rasterizer: Do not render when no render target is configured.
 2018-08-09 13:12:28 -04:00
Khangaroo b534e67f64 Implement BC5/DXN2 (#996) 
- Used by Kirby Star Allies.
 2018-08-09 12:57:13 -04:00
Lioncash ff9e0e9727 buffer_queue: Make reference parameter of SetPreallocatedBuffer const 
This is simply copied by value, so there's no need to make it a
modifiable reference.

While we're at it, make the names of the parameters match its
definition.
 2018-08-09 03:08:14 -04:00
Lioncash b9ec5ec5b4 hle_ipc: Make WriteToOutgoingCommandBuffer()'s reference parameter const 
This function doesn't modify anything within the reference Thread
instance.
 2018-08-09 02:51:38 -04:00
bunnei c1fd5ddba8 Merge pull request #988 from lioncash/color 
common/color: Minor cleanup
 2018-08-09 00:37:32 -04:00
bunnei 67a17d36f0 Merge pull request #977 from bunnei/bgr565 
gl_rasterizer_cached: Implement RenderTargetFormat::B5G6R5_UNORM.
 2018-08-08 23:43:04 -04:00
Lioncash 544265b613 gl_rasterizer_cache: Invert conditional in LoadGLBuffer() 
It's generally easier to follow code using conditionals that operate in
terms of the true case followed by the false case (no chance of
overlooking the exclamation mark).
 2018-08-08 23:34:57 -04:00
Lioncash 824e3ae7f8 gl_rasterizer_cache: Use std::vector::assign in LoadGLBuffer() for the non-tiled case 
resize() causes the vector to expand and zero out the added members to
the vector, however we can avoid this zeroing by using assign().

Given we have the pointer to the data we want to copy, we can calculate
the end pointer and directly copy the range of data without the
need to perform the resize() beforehand.
 2018-08-08 23:34:58 -04:00
bunnei 3983e0da89 Merge pull request #987 from lioncash/vec 
vector_math: Use variable template version of is_signed in Vec classes
 2018-08-08 23:30:40 -04:00
bunnei b0b7437b9f maxwell_to_gl: Implement VertexAttribute::Size::Size_16_16_16_16. 
- Used by Super Mario Odyssey (in game).
 2018-08-08 23:28:17 -04:00
bunnei 29198d26ec maxwell_to_gl: Implement PrimitiveTopology::Points. 
- Used by Super Mario Odyssey (in game).
 2018-08-08 23:28:00 -04:00
bunnei 13dec2d87b gl_shader_decompiler: Declare predicates on use. 
- Used by Super Mario Odyssey (when going in game).
 2018-08-08 23:26:31 -04:00
bunnei cfb59dbe1b maxwell_3d: Ignore macros that have not been uploaded yet. 
- Used by Super Mario Odyssey (in game).
 2018-08-08 23:25:37 -04:00
Lioncash 4be471509c gl_rasterizer_cache: Make pointer const in LoadGLBuffer() 
This is only ever read from, so we can make the data it's pointing to
const.
 2018-08-08 23:14:57 -04:00
bunnei 1e4e0b653a Merge pull request #982 from bunnei/stub-unk-63 
gl_shader_decompiler: Stub input attribute Unknown_63.
 2018-08-08 22:28:18 -04:00
Zach Hilman e883f6faa8 vfs: Fix documentation 2018-08-08 21:45:04 -04:00
bunnei 2145a127bb Merge pull request #986 from mailwl/acc-loadimage 
Service/Account: stub LoadImage function
 2018-08-08 21:21:06 -04:00
Zach Hilman 1e2232797a vfs: Fix typo in VfsFilesystem docs 2018-08-08 21:18:45 -04:00
Zach Hilman b43d01f09b file_util: Use enum instead of bool for specifing path behavior 2018-08-08 21:18:45 -04:00
Zach Hilman 55190386b4 loader: Remove unused IdentifyFile overload 2018-08-08 21:18:45 -04:00
Zach Hilman a92960a5d6 vfs: Use RealVfsFilesystem for fs-operations in RealVfsDirectory 2018-08-08 21:18:45 -04:00
Zach Hilman d4ca68f3c5 file_sys: Add missing include in savedata_factory 2018-08-08 21:18:45 -04:00
Zach Hilman 4cbef33915 core: Port core to VfsFilesystem for file access 2018-08-08 21:18:45 -04:00
Zach Hilman 4f44293e63 vfs: Add unreachable assert to file permissions converter 2018-08-08 21:18:45 -04:00
Zach Hilman 6b97b22716 vfs: Add RealVfsFilesystem implementation 2018-08-08 21:18:45 -04:00
Zach Hilman 944f8b80d8 file_util: Add platform-specific slash option to SanitizePath 2018-08-08 21:18:45 -04:00
Zach Hilman 325a55bb1e vfs: Add VfsFilesystem interface and default implementation 2018-08-08 21:18:45 -04:00
Zach Hilman 653257de93 filesystem: Remove unnecessary if conditions 2018-08-08 21:18:45 -04:00
bunnei 6978915f4e gl_rasterizer: Do not render when no render target is configured. 
- Used by Super Mario Odyssey.
 2018-08-08 19:29:45 -04:00
bunnei e56c6add05 Merge pull request #976 from bunnei/shader-imm 
gl_shader_decompiler: Let OpenGL interpret floats.
 2018-08-08 19:17:01 -04:00
bunnei 98ac2fa5c3 Merge pull request #981 from bunnei/cbuf-corrupt 
maxwell_3d: Use correct const buffer size and check bounds.
 2018-08-08 19:16:34 -04:00
bunnei ba10208eb2 Merge pull request #978 from bunnei/fixioctl 
nvhost_gpu: Don't over copy IoctlSubmitGpfifo.
 2018-08-08 19:16:14 -04:00
Lioncash 4cfe9fad75 fsp_srv: Use std::string_view's copy() function instead of strncpy() 
Given elements inserted into a vector are zeroed out, we can just copy
MAX_LEN - 1 elements and the data will already be properly null
terminated.
 2018-08-08 18:51:52 -04:00
Lioncash a1320c53af fsp_srv: Emplace entries first when building index instead of emplacing last 
The current way were doing it would require copying a 768 character
buffer (part of the Entry struct) to the new element in the vector.
Given it's a plain array, std::move won't eliminate that.

Instead, we can emplace an instance directly into the destination buffer
and then fill it out, avoiding the need to perform any unnecessary
copies.

Given this is done in a loop, we can request the destination to allocate
all of the necessary memory ahead of time, avoiding the need to
potentially keep reallocating over and over on every few insertions into
the vector.
 2018-08-08 18:51:41 -04:00
bunnei 28e3b98c6b Merge pull request #985 from bunnei/rt-r11g11b10 
gpu: Add R11G11B10_FLOAT to RenderTargetBytesPerPixel.
 2018-08-08 18:21:34 -04:00
bunnei 47a25d7cd7 Merge pull request #979 from bunnei/vtx88 
maxwell_to_gl: Implement VertexAttribute::Size::Size_8_8.
 2018-08-08 18:18:50 -04:00
bunnei 9e94b8f830 Merge pull request #975 from bunnei/am-stub 
am: Stub SetScreenShotImageOrientation.
 2018-08-08 16:46:45 -04:00
Lioncash 5415ccb7da common/logging: Add missing service log categories 
These weren't added when the services were introduced.
 2018-08-08 16:46:28 -04:00
bunnei 123518a321 Merge pull request #980 from bunnei/fix-logs 
renderer_opengl: Use trace log in a few places.
 2018-08-08 16:45:42 -04:00
Lioncash 18cd5b3930 common/color: Remove unnecessary const qualifiers on return types 
These are just superfluous and not necessesary
 2018-08-08 16:17:41 -04:00
Lioncash 2fe76428c5 common/color: Get rid of undefined behavior 
Gets rid of type punning via reinterpret_cast within functions. Instead,
we use memcpy to transfer the contents across types.
 2018-08-08 16:14:37 -04:00
Lioncash e3444cb2a6 vector_math: Use variable template version of is_signed in Vec classes 
Same behavior, less code
 2018-08-08 15:53:42 -04:00
bunnei 5ae5657421 Merge pull request #966 from lioncash/modernize 
common: Convert type traits templates over to variable template versions where applicable
 2018-08-08 15:28:34 -04:00
bunnei 0eeda98acf Merge pull request #850 from DarkLordZach/icon-meta 
Add Icons and Metadata Support
 2018-08-08 12:27:19 -04:00
bunnei a26923ef44 Merge pull request #968 from lioncash/vec 
vector_math: Minor cleanups
 2018-08-08 12:00:13 -04:00
bunnei e74d6dd0d1 Merge pull request #958 from lioncash/nv-global 
nvdrv: Get rid of global std::weak_ptr
 2018-08-08 11:58:45 -04:00
mailwl 89cc070fcf Service/Account: stub LoadImage function 2018-08-08 14:42:54 +03:00
bunnei 2a28031596 Merge pull request #972 from lioncash/catch 
externals: Update catch to 2.3.0
 2018-08-08 03:00:57 -04:00
bunnei fd89c5a7d4 Merge pull request #965 from lioncash/unused-files 
hle: Remove unused romfs.cpp/.h
 2018-08-08 03:00:38 -04:00
bunnei 3485776e57 Merge pull request #974 from lioncash/acc 
acc: Add missing function table entries for GetUserCount
 2018-08-08 02:56:00 -04:00
bunnei 1e66ac1103 gpu: Add R11G11B10_FLOAT to RenderTargetBytesPerPixel. 
- Used by Super Mario Odyssey.
 2018-08-08 02:42:14 -04:00
mailwl 219c0dabe1 hid: fix IsSixAxisSensorAtRest() response 2018-08-08 09:36:23 +03:00
bunnei 37e2165d82 gl_shader_decompiler: Stub input attribute Unknown_63. 2018-08-08 02:35:59 -04:00
bunnei 89b9893d28 maxwell_3d: Use correct const buffer size and check bounds. 
- Fixes mem corruption with Super Mario Odyssey and Pokkén Tournament DX.
 2018-08-08 02:10:25 -04:00
bunnei a23331808d renderer_opengl: Use trace log in a few places. 2018-08-08 01:53:23 -04:00
bunnei be0642cb94 maxwell_to_gl: Implement VertexAttribute::Size::Size_8_8. 2018-08-08 01:50:53 -04:00
bunnei e0f48e4daf nvhost_gpu: Don't over copy IoctlSubmitGpfifo. 2018-08-08 01:49:47 -04:00
bunnei 5381a038ca gl_rasterizer_cached: Implement RenderTargetFormat::B5G6R5_UNORM. 
- Used by Super Mario Odyssey.
 2018-08-08 01:48:27 -04:00
bunnei 3ee2d948a2 gl_shader_decompiler: Let OpenGL interpret floats. 
- Accuracy is lost in translation to string, e.g. with NaN.
- Needed for Super Mario Odyssey.
 2018-08-08 01:45:23 -04:00
bunnei 5851753d2a am: Stub SetScreenShotImageOrientation. 
- Used by Super Mario Odyssey.
 2018-08-08 00:41:35 -04:00
Lioncash 3266d0989f acc: Add missing function table entries for GetUserCount 
Given this is stubbed within the common module in
5ac7b84, it should be added to the other relevant tables as well.
 2018-08-07 22:50:45 -04:00
bunnei a0c94e433d acc: Stub GetUserCount. (#973) 
- Used by Pokken Tournament DX.
 2018-08-07 22:39:12 -04:00
bunnei cda973349a Merge pull request #967 from lioncash/sign 
file_util: Avoid sign-conversions in WriteArray() and ReadArray()
 2018-08-07 22:37:00 -04:00
Lioncash e8824d065b nvdrv: Get rid of global std::weak_ptr 
Rather than use global state, we can simply pass the instance into the
NVFlinger instance directly.
 2018-08-07 21:53:05 -04:00
Lioncash 9e90145916 vector_math: Remove unimplemented function prototypes 2018-08-07 21:33:48 -04:00
Lioncash 3868198de6 vector_math: Make functions constexpr where applicable 2018-08-07 21:32:05 -04:00
Lioncash 1393309653 vector_math: Convert typedefs to type aliases 2018-08-07 21:15:10 -04:00
Lioncash 6b1e9244c0 common: Convert type traits templates over to variable template versions where applicable 
Uses the C++17 inline variable variants
 2018-08-07 19:34:47 -04:00
Lioncash fdde0c66db hle: Remove unused romfs.cpp/.h 
These files are no longer used, so we can get rid of them.
 2018-08-07 19:34:12 -04:00
Lioncash a7798e834a externals: Update catch to 2.3.0 
Updates the library from 2.2.3 to 2.3.0
 2018-08-07 19:26:13 -04:00
bunnei 06254058b4 Merge pull request #964 from Hexagon12/lower-logs 
Lowered down the logging for command processor methods
 2018-08-07 19:00:19 -04:00
Hexagon12 81fdfc4192 Fixed the sRGB pixel format (#963) 
* Changed the sRGB pixel format return

* Add a message about SRGBA -> RGBA conversion
 2018-08-07 18:59:50 -04:00
Zach Hilman 0ddf082be2 configure_gamelist: Use explicit QVariant constructor 2018-08-07 17:10:10 -04:00
bunnei a12c19e1c3 Merge pull request #920 from DarkLordZach/titlekey 
content_archive: Add support for titlekey cryptography
 2018-08-07 17:01:25 -04:00
bunnei cd41c647f1 Merge pull request #957 from lioncash/event 
nvflinger: Correct typo in name of composition event
 2018-08-07 15:56:51 -04:00
bunnei a777f14e18 Merge pull request #954 from lioncash/hid 
services/hid: Add ActivateNpadWithRevision() to the hid function info array
 2018-08-07 15:56:34 -04:00
bunnei d93f3bd129 Merge pull request #960 from lioncash/apm 
service/apm: Add the apm:sys service
 2018-08-07 14:57:12 -04:00
bunnei 412032e69d Merge pull request #950 from lioncash/hotkey 
qt/hotkey: Get rid of global hotkey map instance
 2018-08-07 14:45:45 -04:00
bunnei 2493d8b5c1 Merge pull request #955 from lioncash/view 
nvflinger: Use std::string_view in OpenDisplay()
 2018-08-07 14:26:51 -04:00
bunnei a87a2b8737 Merge pull request #953 from lioncash/time 
service/time: Amend command IDs of ToPosixTime() and ToPosixTimeWithMyRule()
 2018-08-07 14:25:52 -04:00
bunnei 94e979a6be Merge pull request #959 from KAMiKAZOW/cubeb-compilation 
Make building cubeb optional
 2018-08-07 14:25:17 -04:00
bunnei 785aececf3 Merge pull request #956 from lioncash/nv 
nvdrv: Get rid of indirect inclusions
 2018-08-07 14:23:32 -04:00
Lioncash 30c608d046 file_util: Avoid sign-conversions in WriteArray() and ReadArray() 
Prevents compiler warnings.
 2018-08-07 13:51:37 -04:00
Hexagon12 d87674e755 Lowered down the logging for methods 2018-08-07 19:51:40 +03:00
bunnei 17c102b576 Merge pull request #952 from lioncash/usb 
service: Add usb services
 2018-08-07 11:27:49 -04:00
bunnei 90ebf1828c Merge pull request #949 from lioncash/priv 
client_port: Make all data members private
 2018-08-07 11:20:26 -04:00
Zach Hilman 9aa2bfc60c loader: Fix scope error in DeconstructedRomDirectory 2018-08-07 10:37:38 -04:00
Lioncash a3f5289038 service/apm: Add the apm:sys service 
Adds the basic skeleton of the apm:sys service based off the information
on Switch Brew.
 2018-08-07 10:05:26 -04:00
Lioncash 64e8d3fd3d nvflinger: Correct typo in name of composition event 2018-08-07 09:03:52 -04:00
Lioncash e1625fdbec nvdrv: Make Ioctl()'s definition match its prototype 
The only reason this wasn't a compilation error is because we use
little-endian systems.
 2018-08-07 08:57:11 -04:00
Lioncash 5bdcce6955 nvdrv: Get rid of indirect inclusions 2018-08-07 08:54:50 -04:00
Lioncash fd0111572b nvflinger: Get rid of indirect inclusions 2018-08-07 08:32:05 -04:00
Lioncash a907041218 nvflinger: Use std::string_view in OpenDisplay() 
We don't need to use a std::string here, given all that's done is
comparing the character sequence against another. This allows passing
regular const char* without needing to heap allocate.
 2018-08-07 08:32:06 -04:00
KAMiKAZOW fef6c33e77 Make building cubeb optional 2018-08-07 13:21:56 +02:00
Lioncash 20f059acef services/hid: Add ActivateNpadWithRevision() to the hid function info array 
Updated based off the information on Switch Brew.
 2018-08-07 03:23:20 -04:00
Lioncash 0c0bdb7d9e service/time: Amend command IDs of ToPosixTime() and ToPosixTimeWithMyRule() 
Updates the ID of these based off the information on Switch Brew.
 2018-08-07 03:18:07 -04:00
Lioncash 705c5b6166 service: Add usb services 
Adds basic skeleton for the usb services based off the information provided by Switch Brew.
 2018-08-07 03:14:03 -04:00
Lioncash ee8808c6a7 qt/hotkey: Get rid of global hotkey map instance 
Instead, we make a proper registry class and house it within the main
window, then pass it to whatever needs access to the loaded hotkeys.

This way, we avoid a global variable, and don't need to initialize a
std::map instance before the program can do anything.
 2018-08-07 02:28:17 -04:00
Zach Hilman d53b3a13b3 loader: Add icon and title support to XCI 2018-08-06 23:13:42 -04:00
Zach Hilman 469f7cefe4 Use const where applicable 2018-08-06 23:06:33 -04:00
Zach Hilman f89988272e Avoid parsing RomFS to directory in NCA 2018-08-06 23:06:33 -04:00
Lioncash 5fcac98ec8 client_port: Make all data members private 
These members don't need to be entirely exposed, we can instead expose
an API to operate on them without directly needing to mutate them

We can also guard against overflow/API misuse this way as well, given
active_sessions is an unsigned value.
 2018-08-06 23:05:17 -04:00
bunnei 44f76e2cfd Merge pull request #931 from DarkLordZach/nca-as-drd 
loader: Make AppLoader_NCA rely on directory loading code
 2018-08-06 22:02:41 -04:00
bunnei caf5d8d15a Merge pull request #947 from lioncash/encoding 
game_list: Use QString::fromStdString() where applicable instead of c_str()
 2018-08-06 22:02:01 -04:00
Hedges 3e421bb6fb GDBStub works with both Unicorn and Dynarmic now (#941) 
* GDBStub works with both Unicorn and Dynarmic now

* Tidy up
 2018-08-06 22:01:24 -04:00
bunnei 0f23a124f7 Merge pull request #943 from lioncash/decl 
game_list: Join declarations and assignments in onTextChanged()
 2018-08-06 22:00:49 -04:00
bunnei a6ad14902c Merge pull request #946 from lioncash/compress 
qt/main: Collapse if statement in UpdateRecentFiles()
 2018-08-06 21:34:20 -04:00
bunnei 48e19379cb Merge pull request #944 from lioncash/menu 
qt: Don't show error dialog when canceling the Load Folder dialog
 2018-08-06 21:33:23 -04:00
bunnei 2e734eeb0c Merge pull request #942 from lioncash/default 
qt: Minor cleanup-related changes
 2018-08-06 21:32:25 -04:00
bunnei 39e6698f2c Merge pull request #940 from lioncash/private 
kernel/event: Make data members private
 2018-08-06 21:31:25 -04:00
bunnei 7dafc8b634 Merge pull request #936 from bunnei/avoid-copies 
gl_rasterizer_cache: Avoid superfluous surface copies.
 2018-08-06 21:29:29 -04:00
bunnei 51c6d09680 Merge pull request #934 from lioncash/chrono 
core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds
 2018-08-06 18:03:05 -04:00
Lioncash 4de0824ad2 qt/main: Avoid sign conversions in UpdateRecentFiles() 
This was intermixing signed and unsigned values when they could all just
be signed.
 2018-08-06 15:42:44 -04:00
Lioncash 35f1943b0f game_list: Remove unnecessary conversion to std::string in ValidateEntry() 
We can just use the file interfaces that Qt provides to prevent needing
to convert to std::string.
 2018-08-06 15:06:29 -04:00
Lioncash 2d3b313879 game_list: Use QString::fromStdString() where applicable instead of c_str() 
The codec used by Qt for const char* and std::string don't necessarily
have to be the same depending on locale. Therefore, we should be using
the correct functions to do the conversions.
 2018-08-06 15:06:30 -04:00
Lioncash c41c5028db game_list: Join declarations and assignments in onTextChanged() 
There's no need to keep these separate from one another.
 2018-08-06 14:35:40 -04:00
Lioncash 9790f8c9ff qt/main: Collapse if statement in UpdateRecentFiles() 
Given the function accepts a boolean, we don't need to use an if
statement here and repeat ourselves.
 2018-08-06 14:32:28 -04:00
Lioncash 0c6d371dd0 qt/main: Better file-existence checking within OnMenuRecentFile() and UpdateUITheme() 
In OnMenuRecentFile() we don't need to construct a QFileInfo instance
just to check if a file exists, we can just use the static member
function to do that (which Qt's documentation also notes as quicker than
constructing an instance).

In UpdateUITheme(), we just want to try and open the file and check the
success of that operation. Technically speaking, between the existence
check and the open call, the file can be deleted or moved, but still
appear to succeed in code. i.e.

1. Existence check -> Returns true
2. File is moved/deleted
3. Open is called, the return value of which isn't checked
4. Nonsense behavior

This way we combine the existence check and the open into one.
 2018-08-06 14:17:13 -04:00
Lioncash ab6bc68bc1 qt: Don't show error dialog when canceling the Load Folder dialog 
Previously, when canceling out of the Load Folder dialog, a user would
get an error dialog about the selected folder not containing a main
file, however, by canceling out of the dialog, no selection was actually
made.
 2018-08-06 14:02:34 -04:00
Lioncash 56cde60393 qt/game_list_p: Remove redundant base class constructor invocations 
These occur automatically without the need to call them. While we're at
it, also std::move the QString instance into its member variable.
 2018-08-06 13:42:12 -04:00
Lioncash a648516863 qt: Add missing override specifiers where applicable 2018-08-06 13:29:14 -04:00
Lioncash 5de7c31baa qt: Default destructors where applicable 
Makes code consistent with our style of defaulting special member
functions where applicable.
 2018-08-06 13:27:08 -04:00
Lioncash 11eadbccc9 kernel/event: Make data members private 
Instead we can simply provide accessors to the required data instead of
giving external read/write access to the variables directly.
 2018-08-06 12:53:02 -04:00
bunnei bca27da66b Merge pull request #933 from lioncash/memory 
memory: Correct prototype of ZeroBlock
 2018-08-06 12:34:57 -04:00
mailwl d77ba2a4df Service/Audio: audout_a.cpp: remove pragma once 2018-08-06 12:29:27 +03:00
bunnei 881573c77a maxwell_3d: Remove outdated assert. 2018-08-05 23:57:19 -04:00
bunnei 2bb2f176b1 gl_rasterizer_cache: Avoid superfluous surface copies. 2018-08-05 23:40:03 -04:00
bunnei cdb4cd4254 Merge pull request #932 from lioncash/func 
core_timing: Use transparent functors where applicable
 2018-08-05 23:37:53 -04:00
bunnei 42aae6b040 Merge pull request #929 from lioncash/addr 
gdbstub: Minor changes
 2018-08-05 23:36:26 -04:00
bunnei cb37285626 Merge pull request #930 from lioncash/thread 
address_arbiter: Return by value from GetThreadsWaitingOnAddress()
 2018-08-05 23:35:59 -04:00
bunnei bccec4825d Merge pull request #925 from bunnei/audren 
Implement audren audio output
 2018-08-05 23:35:22 -04:00
Lioncash 610c7e7685 perf_stats: Correct literal used for MAX_LAG_TIME_US 
ms is shorthand for milliseconds, not microseconds, and given there's no
comment indicating that this was intentional, it probably wasn't.
 2018-08-05 22:12:58 -04:00
Lioncash c34ee8cf08 core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds 
Enforces the time unit being returned and also allows using the standard
time utilities to manipulate it.
 2018-08-05 22:07:30 -04:00
Lioncash ab21a210b1 memory: Make prototype parameter names match their definitions 
Keeps the code consistent.
 2018-08-05 21:39:09 -04:00
Lioncash 856edeb95d memory: Correct prototype of ZeroBlock 
Previously, the prototype wasn't matching the definition, which has a
Processor parameter before the destination address.
 2018-08-05 21:39:06 -04:00
Lioncash 572bff0143 memory: Remove unnecessary const qualifiers in prototypes 
These aren't necessary, as value-wise const only matters in the
definition.
 2018-08-05 21:38:22 -04:00
Lioncash 82ab069b22 core_timing: Convert typedef into a type alias 
Makes the alias a little more readable from left-to-right.
 2018-08-05 21:27:14 -04:00
Lioncash c03f854546 core_timing: Use transparent functors where applicable 
Gets rid of the need to hardcode the type in multiple places. This will
now be deduced automatically, based off the elements in the container
being provided to the algorithm.
 2018-08-05 21:19:24 -04:00
Zach Hilman 8d948e4f17 loader: Make AppLoader_NCA rely on directory loading code 
Eliminates duplicate code shared between their Load methods, after all the only difference is how the romfs is handled.
 2018-08-05 18:28:15 -04:00
bunnei ee30143bf3 Merge pull request #927 from bunnei/fix-texs 
gl_shader_decompiler: Fix TEXS mask and dest.
 2018-08-05 16:42:21 -04:00
Lioncash a3e0a2d3b3 gdbstub: Use type alias for breakpoint maps 
Rather than having to type out the full std::map type signature, we can
just use a straightforward alias. While we're at it, rename
GetBreakpointList to GetBreakpointMap, which makes the name more
accurate. We can also get rid of unnecessary u64 static_casts, since
VAddr is an alias for a u64.
 2018-08-05 16:41:22 -04:00
Lioncash 6602a1b319 gdbstub: Move all file-static variables into the GDBStub namespace 
Keeps everything under the same namespace. While we're at it, enclose
them all within an inner anonymous namespace.
 2018-08-05 16:41:18 -04:00
bunnei 5160c0c975 Merge pull request #912 from lioncash/global-var 
video_core: Eliminate the g_renderer global variable
 2018-08-05 16:37:39 -04:00
Lioncash 65c0fe0d39 address_arbiter: Return by value from GetThreadsWaitingOnAddress() 
In all cases the vector being supplied is empty, so we can just return
by value in these instances.
 2018-08-05 16:29:17 -04:00
Lioncash 88023a481d gdbstub: Replace PAddr alias with VAddr 
In all cases, a virtual address is being passed in, not a physical one.
 2018-08-05 15:56:01 -04:00
bunnei 4215d08d37 gl_shader_decompiler: Fix TEXS mask and dest. 2018-08-05 01:47:09 -04:00
bunnei 14d7adf99a Merge pull request #926 from ogniK5377/vertex-attrib-format 
gl_rasterizer: Fix glVertexAttribFormat for integers
 2018-08-05 01:38:54 -04:00
bunnei 5904aa20ce audio_core: Implement audren_u audio playback. 2018-08-04 21:54:30 -04:00
David Marcec 112a0b8d6d added braces for conditions 2018-08-05 11:36:55 +10:00
David Marcec 45078c8b24 fix the attrib format for ints 2018-08-05 11:29:21 +10:00
bunnei c33e13366f Merge pull request #924 from lioncash/arp 
service: Add arp services
 2018-08-04 21:20:26 -04:00
bunnei c4d7092d4b Merge pull request #921 from lioncash/view 
core/crypto: Minor changes
 2018-08-04 21:17:10 -04:00
bunnei 600e4bbeac audio_core: Use s16 where possible for audio samples. 2018-08-04 18:22:58 -04:00
bunnei 7688b83a1c audio_core: Port codec code from Citra for ADPCM decoding. 2018-08-04 18:22:58 -04:00
Lioncash ed0e62fe9e service: Add arp services 
Adds the basic skeleton of the arp services based off the information
provided by Switch Brew.
 2018-08-04 18:01:12 -04:00
Lioncash 2ce618c2c8 service: Remove redundant #pragma once directives 
These don't do anything within .cpp files (we don't include cpp files,
so...)
 2018-08-04 17:39:08 -04:00
Lioncash c8617a1465 aes_util: Add static assertion to Transcode() and XTSTranscode() to ensure well-defined behavior 
These functions should only be given trivially-copyable types.
 2018-08-04 17:30:52 -04:00
Lioncash f0a2d4da2b aes_util: Make CalculateNintendoTweak() an internally linked function 
This function doesn't directly depend on class state, so it can be
hidden entirely from the interface in the cpp file.
 2018-08-04 17:30:48 -04:00
Lioncash 1fb5027501 aes_util: Make Transcode() a const member function 
This doesn't modify member state, so it can be made const.
 2018-08-04 16:49:42 -04:00
Lioncash 8b86a89dd5 core/crypto: Remove unnecessary includes 2018-08-04 16:44:07 -04:00
Lioncash d74342ad3f key_manager: Use regular std::string instead of std::string_view 
The benefit of std::string_view comes from the idea of avoiding copies
(essentially acting as a non-owning view), however if we're just going
to copy into a local variable immediately, there's not much benefit
gained here.
 2018-08-04 16:37:30 -04:00
bunnei 950de5fd73 cubeb_sink: Support variable sample_rate and num_channels. 2018-08-04 15:30:10 -04:00
Zach Hilman 3150538b3f content_archive: Add support for titlekey cryptography 2018-08-04 14:57:21 -04:00
bunnei 97647e60f2 audio_core: Sinks need unique names as well. 2018-08-04 14:34:12 -04:00
bunnei 7186882bfe audio_core: Streams need unique names for CoreTiming. 2018-08-04 14:34:12 -04:00
bunnei 4c42134b09 Merge pull request #849 from DarkLordZach/xci 
XCI and Encrypted NCA Support
 2018-08-04 14:33:11 -04:00
bunnei a43ae368d3 Merge pull request #919 from lioncash/sign 
gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding()
 2018-08-04 14:29:59 -04:00
Lioncash 32901799b5 gl_shader_manager: Invert conditional in SetShaderUniformBlockBinding() 
This lets us indent the majority of the code and places the error case
first.
 2018-08-04 02:57:11 -04:00
Lioncash c043a5c930 gl_shader_manager: Amend sign differences in an assertion comparison in SetShaderUniformBlockBinding() 
Ensures both operands have the same sign in the comparison.

While we're at it, we can get rid of the redundant casting of ub_size to
an int. This type will always be trivial and alias a built-in type (not
doing so would break backwards compatibility at a standard level).
 2018-08-04 02:55:03 -04:00
Lioncash 69bbe31ca8 renderer_base: Make Rasterizer() return the rasterizer by reference 
All calling code assumes that the rasterizer will be in a valid state,
which is a totally fine assumption. The only way the rasterizer wouldn't
be is if initialization is done incorrectly or fails, which is checked
against in System::Init().
 2018-08-04 02:36:58 -04:00
Lioncash 49dc22f84e video_core: Eliminate the g_renderer global variable 
We move the initialization of the renderer to the core class, while
keeping the creation of it and any other specifics in video_core. This
way we can ensure that the renderer is initialized and doesn't give
unfettered access to the renderer. This also makes dependencies on types
more explicit.

For example, the GPU class doesn't need to depend on the
existence of a renderer, it only needs to care about whether or not it
has a rasterizer, but since it was accessing the global variable, it was
also making the renderer a part of its dependency chain. By adjusting
the interface, we can get rid of this dependency.
 2018-08-04 02:36:57 -04:00
bunnei bf006dd1d4 Merge pull request #911 from lioncash/prototype 
video_core: Remove unimplemented Start() function prototype
 2018-08-04 02:18:38 -04:00
bunnei a8755cb738 Merge pull request #913 from lioncash/unused-func 
memory: Remove unused GetSpecialHandlers() function
 2018-08-04 02:17:44 -04:00
bunnei 017fa55c0a Merge pull request #914 from lioncash/codeset 
kernel/process: Use accessors instead of class members for referencing segment array
 2018-08-04 02:17:25 -04:00
bunnei 26a9093726 Merge pull request #917 from lioncash/crash 
kernel/thread: Fix potential crashes introduced in 3bcf090d
 2018-08-04 01:19:01 -04:00
Lioncash 6f3a3ed8c5 kernel/thread: Fix potential crashes introduced in 3bcf090d37 
This amends cases where crashes can occur that were missed due to the
odd way the previous code was set up (using 3DS memory regions that
don't exist).
 2018-08-03 23:49:10 -04:00
bunnei 46db65403f Merge pull request #910 from lioncash/unused 
gl_shader_decompiler: Remove unused variable in GenerateDeclarations()
 2018-08-03 15:54:11 -04:00
Lioncash 73e1be4350 kernel/process: Use std::array where applicable 2018-08-03 14:46:30 -04:00
Lioncash 73f162a5b0 kernel/process: Use accessors instead of class members for referencing segment array 
Using member variables for referencing the segments array increases the
size of the class in memory for little benefit. The same behavior can be
achieved through the use of accessors that just return the relevant
segment.
 2018-08-03 14:45:45 -04:00
Lioncash 0e92e67e06 memory: Remove unused GetSpecialHandlers() function 
This is just unused code, so we may as well get rid of it.
 2018-08-03 14:20:50 -04:00
bunnei 67b4326d93 Merge pull request #908 from lioncash/memory 
core/memory: Get rid of 3DS leftovers
 2018-08-03 14:07:49 -04:00
Lioncash 02cdd82efc video_core: Remove unimplemented Start() function prototype 
Given this has no definition, we can just remove it entirely.
 2018-08-03 12:48:14 -04:00
Lioncash c155adb42a gl_shader_decompiler: Remove unused variable in GenerateDeclarations() 
This variable was being incremented, but we were never actually using
it.
 2018-08-03 12:18:31 -04:00
Lioncash 300a4e3d79 gl_shader_manager: Make ProgramManager's GetCurrentProgramStage() a const member function 
This function doesn't modify class state, so it can be made const.
 2018-08-03 12:08:17 -04:00
Lioncash 3bcf090d37 core/memory: Get rid of 3DS leftovers 
Removes leftover code from citra that isn't needed.
 2018-08-03 11:22:47 -04:00
David 4a4641a134 Added ability to change username & language code in the settings ui. Added IProfile::Get and SET::GetLanguageCode for libnx tests (#851) 2018-08-03 11:02:55 -04:00
bunnei 1028560b4c Merge pull request #895 from lioncash/sink 
sink_details: std::move std::function instances
 2018-08-03 11:00:56 -04:00
bunnei 485a6770e9 Merge pull request #898 from lioncash/mig 
service: Add migration services
 2018-08-03 11:00:27 -04:00
bunnei ff296707b1 Merge pull request #900 from lioncash/init 
math_util: Always initialize members of Rectangle
 2018-08-03 11:00:10 -04:00
bunnei 299975e4a8 Merge pull request #892 from lioncash/global 
video_core: Make global EmuWindow instance part of the base renderer …
 2018-08-03 00:31:32 -04:00
bunnei 20b6c79859 Merge pull request #894 from lioncash/object 
kernel: Move object class to its own source files
 2018-08-03 00:28:43 -04:00
bunnei 9f560b2c57 Merge pull request #904 from lioncash/static 
kernel/thread: Minor changes
 2018-08-03 00:19:29 -04:00
bunnei b6930f7a1e Merge pull request #906 from lioncash/override 
input_common: minor changes
 2018-08-03 00:18:52 -04:00
bunnei ca12628324 Merge pull request #907 from lioncash/slot 
yuzu: Use Qt 5 signal/slots where applicable
 2018-08-03 00:17:55 -04:00
bunnei 3ce7cf5e42 Merge pull request #905 from lioncash/vma 
kernel/vm_manager: Minor changes
 2018-08-02 23:18:03 -04:00
bunnei f720eee031 Merge pull request #903 from lioncash/copy 
vfs_vector: Minor changes
 2018-08-02 23:01:19 -04:00
bunnei 309b596a21 Merge pull request #901 from lioncash/ref 
gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader()
 2018-08-02 23:00:56 -04:00
Lioncash f90c667a44 yuzu: Use Qt 5 signal/slots where applicable 
Makes the signal/slot connections type-safe instead of string-based.
 2018-08-02 22:18:33 -04:00
Lioncash fc2d6869bf input_common: Use std::move where applicable 
Avoids unnecessary atomic reference count increments and decrements
 2018-08-02 21:51:11 -04:00
Lioncash d682d53bb2 input_common: Add missing override specifiers 2018-08-02 21:44:25 -04:00
bunnei 403cb09019 Merge pull request #899 from lioncash/unused 
hw: Remove unused files
 2018-08-02 14:58:01 -04:00
bunnei b57d279b57 Merge pull request #902 from lioncash/array 
gl_state: Make texture_units a std::array
 2018-08-02 14:57:42 -04:00
bunnei 4a087fed32 Merge pull request #891 from lioncash/ns 
service/ns: Add missing ns services
 2018-08-02 14:57:24 -04:00
greggameplayer 6abb522f98 Implement RGB32F PixelFormat (#886) (used by Go Vacation) 2018-08-02 14:56:38 -04:00
bunnei fc6356f5c2 Merge pull request #893 from lioncash/psc 
service: Add the psc services
 2018-08-02 14:53:55 -04:00
Lioncash bf632d8e1e kernel/vm_manager: Convert loop into std::any_of() 2018-08-02 12:46:15 -04:00
Lioncash ec7319a5de kernel/vm_manager: Use const where applicable 
Makes our immutable state explicit.
 2018-08-02 12:21:46 -04:00
Lioncash 26e2e7b657 kernel/vm_manager: Use the VAddr type alias in CarveVMA() 
These two variables correspond to address ranges.
 2018-08-02 12:15:50 -04:00
Lioncash fa173d1874 kernel/thread: Make GetFreeThreadLocalSlot()'s loop indices size_t 
Avoids using a u32 to compare against a range of size_t, which can be a
source of warnings. While we're at it, compress a std::tie into a
structured binding.
 2018-08-02 12:01:25 -04:00
Lioncash 12afa56830 kernel/thread: Make GetFreeThreadLocalSlot() reference parameter a const reference 
This function only reads the data being referenced, it doesn't modify
it, so we can turn the reference into a const reference.
 2018-08-02 11:56:11 -04:00
Lioncash 16c5f5fe1b kernel/thread: Make GetFreeThreadLocalSlot() internally linked 
This function isn't used outside of this translation unit, so we can
make it internally linked.
 2018-08-02 11:54:23 -04:00
Lioncash 5b317d1b80 vfs_vector: Remove unused variable in FindAndRemoveVectorElement() 
This wasn't being used for anything, so it can be removed.
 2018-08-02 11:40:24 -04:00
Lioncash 0bb1b9c168 vfs_vector: Avoid unnecessary copies where applicable 
The lambda elements should be taken by const reference here, and we can
move the virtual directory passed to ReplaceFileWithSubdirectory()
 2018-08-02 11:37:39 -04:00
Lioncash 68150d3d79 gl_state: Make texture_units a std::array 
Gets rid of the use of a raw C array.
 2018-08-02 11:19:58 -04:00
Lioncash 807d0cf4f2 gl_shader_manager: Take ShaderSetup instances by const reference in UseProgrammableVertexShader() and UseProgrammableFragmentShader() 
Avoids performing unnecessary copies of 65560 byte sized ShaderSetup
instances, considering it's only used as part of lookup and not
modified.

Given the parameters were already const, it's likely taking these
parameters by reference was intended but the ampersand was forgotten.
 2018-08-02 11:09:46 -04:00
Lioncash 9f5ba9df95 math_util: Always initialize members of Rectangle 
Prevents potentially using the members uninitialized.
 2018-08-02 10:47:34 -04:00
Lioncash db3603df94 hw: Remove unused files 
None of these files are used in any meaningful way. They're just
leftovers from citra. Also has the benefit of getting rid of an unused
global variable.
 2018-08-02 10:23:10 -04:00
Lioncash 6ac24e4e5a service: Add migration services 
Adds the basic skeleton for the mig:usr service based off information
provided by Switch Brew.
 2018-08-02 10:09:45 -04:00
Lioncash 07a3c8a2a5 audio_out: Use Buffer::Tag alias in GetTagsAndReleaseBuffers()'s prototype 
This makes the Buffer::Tag usage consistent with the Stream class's
prototype of GetTagsAndReleaseBuffers().
 2018-08-02 05:18:32 -04:00
Lioncash 881380bc97 sink_details: Deduplicate long std::function repetition 
We can just use type aliases to avoid needing to write the same long
type twice
 2018-08-01 23:56:02 -04:00
Lioncash 5061e89fd1 sink_details: std::move std::function instances 
Given std::function is allowed to potentially allocate, these should be
std::move'd to prevent potential reallocation (should that ever happen).
 2018-08-01 23:50:48 -04:00