ihateninjas/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher synced 2026-04-23 09:05:03 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add asserts to invalid Task states

Browse source 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
(cherry picked from commit 9ac0314d7a)
This commit is contained in:
Octol1ttle 2026-01-21 17:10:14 +05:00 committed by github-actions[bot]
parent 3e567fef3b
commit f686d9b598
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
launcher/tasks/Task.cpp
View file

@ -98,6 +98,7 @@ void Task::start()
case State::Running: {
if (m_show_debug)
qCWarning(taskLogC) << "The launcher tried to start task" << describe() << "while it was already running!";
Q_ASSERT(!isRunning());
return;
}
}
@ -112,6 +113,7 @@ void Task::emitFailed(QString reason)
// Don't fail twice.
if (!isRunning()) {
qCCritical(taskLogC) << "Task" << describe() << "failed while not running!!!!: " << reason;
Q_ASSERT(!isRunning());
return;
}
m_state = State::Failed;
@ -126,6 +128,7 @@ void Task::emitAborted()
// Don't abort twice.
if (!isRunning()) {
qCCritical(taskLogC) << "Task" << describe() << "aborted while not running!!!!";
Q_ASSERT(!isRunning());
return;
}
m_state = State::AbortedByUser;
@ -141,6 +144,7 @@ void Task::emitSucceeded()
// Don't succeed twice.
if (!isRunning()) {
qCCritical(taskLogC) << "Task" << describe() << "succeeded while not running!!!!";
Q_ASSERT(!isRunning());
return;
}
m_state = State::Succeeded;