From a0d5c649b9b79658e77078888302bc30d3d0123e Mon Sep 17 00:00:00 2001 From: "George V." Date: Thu, 9 Apr 2026 21:03:30 +0300 Subject: [PATCH] refactor: remove duplicate custom name handling in boss renderers The custom name assignment for boss mobs is already handled inside the `BossMobGuiInfo::setBossHealth` method. The removed code in both `WitherBossRenderer` and `EnderDragonRenderer` was redundant and not working. --- Minecraft.Client/EnderDragonRenderer.cpp | 9 +++++---- Minecraft.Client/WitherBossRenderer.cpp | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Minecraft.Client/EnderDragonRenderer.cpp b/Minecraft.Client/EnderDragonRenderer.cpp index 44e92192..da6e7bf8 100644 --- a/Minecraft.Client/EnderDragonRenderer.cpp +++ b/Minecraft.Client/EnderDragonRenderer.cpp @@ -89,10 +89,11 @@ void EnderDragonRenderer::render(shared_ptr _mob, double x, double y, do // 4J - dynamic cast required because we aren't using templates/generics in our version shared_ptr mob = dynamic_pointer_cast(_mob); BossMobGuiInfo::setBossHealth(mob, false); - if (!mob->getCustomName().empty()) - { - BossMobGuiInfo::name = mob->getCustomName(); - } + // GeorgeV22 - BossMobGuiInfo::setBossHealth already handles this + // if (!mob->getCustomName().empty()) + // { + // BossMobGuiInfo::name = mob->getCustomName(); + // } MobRenderer::render(mob, x, y, z, rot, a); if (mob->nearestCrystal != nullptr) diff --git a/Minecraft.Client/WitherBossRenderer.cpp b/Minecraft.Client/WitherBossRenderer.cpp index dc1d8f92..736d1e41 100644 --- a/Minecraft.Client/WitherBossRenderer.cpp +++ b/Minecraft.Client/WitherBossRenderer.cpp @@ -20,10 +20,11 @@ void WitherBossRenderer::render(shared_ptr entity, double x, double y, d shared_ptr mob = dynamic_pointer_cast(entity); BossMobGuiInfo::setBossHealth(mob, true); - if (!mob->getCustomName().empty()) - { - BossMobGuiInfo::name = mob->getCustomName(); - } + // GeorgeV22 - BossMobGuiInfo::setBossHealth already handles this + // if (!mob->getCustomName().empty()) + // { + // BossMobGuiInfo::name = mob->getCustomName(); + // } int modelVersion = dynamic_cast(model)->modelVersion(); if (modelVersion != this->modelVersion)