From 5efd4892294a500e4b8fd51e887a47ceb8c5fa1b Mon Sep 17 00:00:00 2001 From: "George V." Date: Mon, 13 Apr 2026 17:17:33 +0300 Subject: [PATCH] fix: Prevent crash when displaying hardcore difficulty label The hardcore difficulty label was using the raw string ID `IDS_HARDCORE` (oops) instead of a localized string, which caused a crash in the UI. Replaced `IDS_HARDCORE` with `app.GetString(IDS_HARDCORE)` --- Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp | 2 +- Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp b/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp index 860e4b00..85d8ee26 100644 --- a/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp +++ b/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp @@ -669,7 +669,7 @@ void UIScene_CreateWorldMenu::handleSliderMove(F64 sliderId, F64 currentValue) s_bHardcore = (value >= 4); app.SetGameSettings(m_iPad, eGameSetting_Difficulty, s_bHardcore ? 3 : value); if (value >= 4) - swprintf( (WCHAR *)TempString, 256, L"%ls: %ls", app.GetString( IDS_SLIDER_DIFFICULTY ), IDS_HARDCORE); + swprintf( (WCHAR *)TempString, 256, L"%ls: %ls", app.GetString( IDS_SLIDER_DIFFICULTY ), app.GetString(IDS_HARDCORE)); else swprintf( (WCHAR *)TempString, 256, L"%ls: %ls", app.GetString( IDS_SLIDER_DIFFICULTY ),app.GetString(m_iDifficultyTitleSettingA[value])); m_sliderDifficulty.setLabel(TempString); diff --git a/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp b/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp index b76ec04e..ee8d4eb2 100644 --- a/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp +++ b/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp @@ -285,7 +285,7 @@ UIScene_LoadMenu::UIScene_LoadMenu(int iPad, void *initData, UILayer *parentLaye if (m_bHardcore) { WCHAR TempString[256]; - swprintf((WCHAR *)TempString, 256, L"%ls: %ls", app.GetString(IDS_SLIDER_DIFFICULTY), IDS_HARDCORE); + swprintf((WCHAR *)TempString, 256, L"%ls: %ls", app.GetString(IDS_SLIDER_DIFFICULTY), app.GetString(IDS_HARDCORE)); m_sliderDifficulty.init(TempString, eControl_Difficulty, 0, 4, 4); } } @@ -586,7 +586,7 @@ void UIScene_LoadMenu::tick() if (m_bHardcore) { WCHAR TempString[256]; - swprintf( (WCHAR *)TempString, 256, L"%ls: %ls", app.GetString( IDS_SLIDER_DIFFICULTY ), IDS_HARDCORE); + swprintf( (WCHAR *)TempString, 256, L"%ls: %ls", app.GetString( IDS_SLIDER_DIFFICULTY ), app.GetString(IDS_HARDCORE)); m_sliderDifficulty.init(TempString, eControl_Difficulty, 0, 4, 4); // Hardcore locks game mode to Survival