backups/MinecraftConsoles
2
0
Fork 1
mirror of https://github.com/smartcmd/MinecraftConsoles.git synced 2026-08-20 09:57:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Optimization

Browse source
This commit is contained in:
NSDeathman 2026-03-12 22:17:38 +03:00
parent 1c28f2a8e8
commit e0f2b2ca4b
4 changed files with 442 additions and 348 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

659
Minecraft.Client/Chunk.cpp
View file

@ -1,4 +1,4 @@
#include "stdafx.h" #include "stdafx.h"
#include "Chunk.h" #include "Chunk.h"
#include "TileRenderer.h" #include "TileRenderer.h"
#include "TileEntityRenderDispatcher.h" #include "TileEntityRenderDispatcher.h"
@ -19,6 +19,10 @@
#endif #endif
#ifdef _WINDOWS64
#include <emmintrin.h> // SSE2 intrinsics
#endif
int Chunk::updates = 0; int Chunk::updates = 0;
#ifdef _LARGE_WORLDS #ifdef _LARGE_WORLDS
@ -181,272 +185,380 @@ void Chunk::makeCopyForRebuild(Chunk *source)
void Chunk::rebuild() void Chunk::rebuild()
{ {
PIXBeginNamedEvent(0,"Rebuilding chunk %d, %d, %d", x, y, z); PIXBeginNamedEvent(0, "Rebuilding chunk %d, %d, %d", x, y, z);
#if defined __PS3__ && !defined DISABLE_SPU_CODE #if defined __PS3__ && !defined DISABLE_SPU_CODE
rebuild_SPU(); rebuild_SPU();
return; return;
#endif // __PS3__ #endif
// if (!dirty) return; PIXBeginNamedEvent(0, "Rebuild section A");
PIXBeginNamedEvent(0,"Rebuild section A");
#ifdef _LARGE_WORLDS #ifdef _LARGE_WORLDS
Tesselator *t = Tesselator::getInstance(); Tesselator* t = Tesselator::getInstance();
#else #else
Chunk::t = Tesselator::getInstance(); // 4J - added - static initialiser being set at the wrong time Chunk::t = Tesselator::getInstance();
#endif #endif
updates++; updates++;
int x0 = x; const int x0 = x;
int y0 = y; const int y0 = y;
int z0 = z; const int z0 = z;
int x1 = x + XZSIZE; const int x1 = x + XZSIZE;
int y1 = y + SIZE; const int y1 = y + SIZE;
int z1 = z + XZSIZE; const int z1 = z + XZSIZE;
LevelChunk::touchedSky = false; LevelChunk::touchedSky = false;
// unordered_set<shared_ptr<TileEntity> > oldTileEntities(renderableTileEntities.begin(),renderableTileEntities.end()); // 4J removed this & next line vector<shared_ptr<TileEntity>> renderableTileEntities;
// renderableTileEntities.clear(); renderableTileEntities.reserve(16);
vector<shared_ptr<TileEntity> > renderableTileEntities; // 4J - added const int r = 1;
int r = 1; int lists = levelRenderer->getGlobalIndexForChunk(this->x, this->y, this->z, level) * 2;
int lists = levelRenderer->getGlobalIndexForChunk(this->x,this->y,this->z,level) * 2;
lists += levelRenderer->chunkLists; lists += levelRenderer->chunkLists;
PIXEndNamedEvent(); PIXEndNamedEvent();
PIXBeginNamedEvent(0, "Rebuild section B");
PIXBeginNamedEvent(0,"Rebuild section B");
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// 4J - optimisation begins.
// Get the data for the level chunk that this render chunk is it (level chunk is 16 x 16 x 128,
// render chunk is 16 x 16 x 16. We wouldn't have to actually get all of it if the data was ordered differently, but currently
// it is ordered by x then z then y so just getting a small range of y out of it would involve getting the whole thing into
// the cache anyway.
#ifdef _LARGE_WORLDS #ifdef _LARGE_WORLDS
unsigned char *tileIds = GetTileIdsStorage(); unsigned char* tileIds = GetTileIdsStorage();
#else #else
static unsigned char tileIds[16 * 16 * Level::maxBuildHeight]; static unsigned char tileIds[16 * 16 * Level::maxBuildHeight];
#endif #endif
byteArray tileArray = byteArray(tileIds, 16 * 16 * Level::maxBuildHeight); byteArray tileArray = byteArray(tileIds, 16 * 16 * Level::maxBuildHeight);
level->getChunkAt(x,z)->getBlockData(tileArray); // 4J - TODO - now our data has been re-arranged, we could just extra the vertical slice of this chunk rather than the whole thing level->getChunkAt(x, z)->getBlockData(tileArray);
LevelSource *region = new Region(level, x0 - r, y0 - r, z0 - r, x1 + r, y1 + r, z1 + r, r); Region region(level, x0 - r, y0 - r, z0 - r, x1 + r, y1 + r, z1 + r, r);
TileRenderer *tileRenderer = new TileRenderer(region, this->x, this->y, this->z, tileIds); TileRenderer tileRenderer(&region, this->x, this->y, this->z, tileIds);
// AP - added a caching system for Chunk::rebuild to take advantage of
// Basically we're storing of copy of the tileIDs array inside the region so that calls to Region::getTile can grab data
// more quickly from this array rather than calling CompressedTileStorage. On the Vita the total thread time spent in
// Region::getTile went from 20% to 4%.
#ifdef __PSVITA__ #ifdef __PSVITA__
int xc = x >> 4; {
int zc = z >> 4; const int xc = x >> 4;
((Region*)region)->setCachedTiles(tileIds, xc, zc); const int zc = z >> 4;
region.setCachedTiles(tileIds, xc, zc);
}
#endif #endif
// We now go through the vertical section of this level chunk that we are interested in and try and establish // ── Скалярная isSolid: используется только в non-Windows64 путях ──────────
// (1) if it is completely empty auto isSolid = [](unsigned char id)
// (2) if any of the tiles can be quickly determined to not need rendering because they are in the middle of other tiles and
// so can't be seen. A large amount (> 60% in tests) of tiles that call tesselateInWorld in the unoptimised version
// of this function fall into this category. By far the largest category of these are tiles in solid regions of rock.
bool empty = true;
for( int yy = y0; yy < y1; yy++ )
{ {
for( int zz = 0; zz < 16; zz++ ) return id == Tile::stone_Id
|| id == Tile::dirt_Id
|| id == Tile::unbreakable_Id
|| id == 255;
};
bool empty = true;
#ifdef _WINDOWS64
// ═══════════════════════════════════════════════════════════════════════════
// SSE2 Section B
//
// Ключевые факты из констант:
// SIZE = 16 → y-диапазон чанка ровно 16 байт
// COMPRESSED_CHUNK_SECTION_HEIGHT = 128 → кратно SIZE=16
//
// Вывод: render-чанки ВСЕГДА целиком лежат в одной секции — граница 128
// никогда не попадает внутрь чанка. Скалярный fallback мёртв.
// SSE2 загружает весь y-диапазон за одну инструкцию (_mm_loadu_si128).
// ═══════════════════════════════════════════════════════════════════════════
{
// Выбираем секцию один раз — больше никаких ветвлений на каждый тайл
// inUpperSection = true → y0 >= 128, base = COMPRESSED_CHUNK_SECTION_TILES
// inUpperSection = false → y0 < 128, base = 0
const bool inUpperSection = (y0 >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT);
const int sectionBase = inUpperSection
? Level::COMPRESSED_CHUNK_SECTION_TILES
: 0;
// y-координата внутри секции для y0 (0..111 или 0..127)
const int yAdj = inUpperSection
? y0 - Level::COMPRESSED_CHUNK_SECTION_HEIGHT
: y0;
// ── SSE2 константы ───────────────────────────────────────────────────
const __m128i zero = _mm_setzero_si128();
const __m128i v_stone = _mm_set1_epi8(static_cast<char>(Tile::stone_Id));
const __m128i v_dirt = _mm_set1_epi8(static_cast<char>(Tile::dirt_Id));
const __m128i v_unbr = _mm_set1_epi8(static_cast<char>(Tile::unbreakable_Id));
const __m128i v_ff = _mm_set1_epi8(static_cast<char>(0xFF));
// Возвращает маску 0xFF для каждого байта где тайл "сплошной"
// Инлайнится в 4 × cmpeq + 3 × por — 7 инструкций
auto isSolid128 = [&](__m128i v) -> __m128i
{ {
for( int xx = 0; xx < 16; xx++ ) return _mm_or_si128(
_mm_or_si128(_mm_cmpeq_epi8(v, v_stone), _mm_cmpeq_epi8(v, v_dirt)),
_mm_or_si128(_mm_cmpeq_epi8(v, v_unbr), _mm_cmpeq_epi8(v, v_ff))
);
};
// ── Шаг 1. Проверка пустоты — 256 столбцов × 1 SSE2-загрузка ─────────
//
// SIZE=16 → весь y-диапазон чанка = ровно 128 бит = один XMM-регистр.
// Итого 256 загрузок вместо 4096 скалярных сравнений.
// movemask(cmpeq(v, zero)) == 0xFFFF означает "все 16 байт равны нулю".
for (int zz = 0; zz < 16 && empty; zz++)
{
for (int xx = 0; xx < 16 && empty; xx++)
{
const unsigned char* col =
tileIds + sectionBase + (xx << 11) + (zz << 7) + yAdj;
const __m128i v = _mm_loadu_si128(
reinterpret_cast<const __m128i*>(col));
if (_mm_movemask_epi8(_mm_cmpeq_epi8(v, zero)) != 0xFFFF)
empty = false;
}
}
// ── Шаг 2. Маркировка скрытых тайлов — 196 внутренних столбцов ───────
//
// Для каждого внутреннего (xx, zz) столбца:
// • 7 загрузок: cur + 4 горизонтальных + 2 вертикальных соседа
// • isSolid128 × 7 → AND всех масок → surrounded
// • Результат: OR(cur, surrounded) записывает 0xFF только скрытым
//
// edgeMask исключает крайние y-позиции где нет корректного соседа:
// byte[0] маскируется если y0==0 (дно мира)
// или y0==128 (сосед y=-1 находится в другой секции)
// byte[15] маскируется если y1==maxBuildHeight (потолок мира)
// или y1==128 (сосед y=128 находится в другой секции)
if (!empty)
{
// Строим edgeMask — вычисляется один раз для всего чанка
alignas(16) unsigned char edgeMaskBytes[16];
memset(edgeMaskBytes, 0xFF, sizeof(edgeMaskBytes));
// Нижний сосед отсутствует: дно мира или начало верхней секции
if (y0 == Level::minBuildHeight ||
y0 == Level::COMPRESSED_CHUNK_SECTION_HEIGHT)
edgeMaskBytes[0] = 0x00;
// Верхний сосед отсутствует: потолок мира или конец нижней секции
if (y1 == Level::maxBuildHeight ||
y1 == Level::COMPRESSED_CHUNK_SECTION_HEIGHT)
edgeMaskBytes[15] = 0x00;
const __m128i edgeMask = _mm_load_si128(
reinterpret_cast<const __m128i*>(edgeMaskBytes));
for (int zz = 1; zz < 15; zz++)
{
for (int xx = 1; xx < 15; xx++)
{
unsigned char* pCur =
tileIds + sectionBase + (xx << 11) + (zz << 7) + yAdj;
// 7 загрузок: cur, ±x, ±z, ±y
// ym1/yp1 — соседние байты в непрерывном столбце (±1 байт)
// Корректны т.к. чанк целиком в одной секции:
// - pCur-1 при yAdj>0: валидно (внутри секции)
// - pCur+1 при yAdj+15<sectionHeight: валидно
// - edgeMask обнулит результат на граничных позициях
const __m128i cur = _mm_loadu_si128(reinterpret_cast<__m128i*>(pCur));
const __m128i xm1 = _mm_loadu_si128(reinterpret_cast<__m128i*>(
tileIds + sectionBase + ((xx - 1) << 11) + (zz << 7) + yAdj));
const __m128i xp1 = _mm_loadu_si128(reinterpret_cast<__m128i*>(
tileIds + sectionBase + ((xx + 1) << 11) + (zz << 7) + yAdj));
const __m128i zm1 = _mm_loadu_si128(reinterpret_cast<__m128i*>(
tileIds + sectionBase + (xx << 11) + ((zz - 1) << 7) + yAdj));
const __m128i zp1 = _mm_loadu_si128(reinterpret_cast<__m128i*>(
tileIds + sectionBase + (xx << 11) + ((zz + 1) << 7) + yAdj));
const __m128i ym1 = _mm_loadu_si128(
reinterpret_cast<__m128i*>(pCur - 1));
const __m128i yp1 = _mm_loadu_si128(
reinterpret_cast<__m128i*>(pCur + 1));
// Все 7 направлений должны быть сплошными
__m128i surrounded = _mm_and_si128(
_mm_and_si128(isSolid128(cur), isSolid128(xm1)),
_mm_and_si128(isSolid128(xp1),
_mm_and_si128(isSolid128(zm1),
_mm_and_si128(isSolid128(zp1),
_mm_and_si128(isSolid128(ym1), isSolid128(yp1))))));
// Защита от граничных y-позиций
surrounded = _mm_and_si128(surrounded, edgeMask);
// OR(cur, 0xFF) = 0xFF помечен, OR(cur, 0x00) = cur без изменений
_mm_storeu_si128(reinterpret_cast<__m128i*>(pCur),
_mm_or_si128(cur, surrounded));
}
}
}
}
#else // !_WINDOWS64 — скалярный путь без изменений
for (int yy = y0; yy < y1; yy++)
{
for (int zz = 0; zz < 16; zz++)
{
for (int xx = 0; xx < 16; xx++)
{ {
// 4J Stu - tile data is ordered in 128 blocks of full width, lower 128 then upper 128
int indexY = yy; int indexY = yy;
int offset = 0; int offset = 0;
if(indexY >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT) if (indexY >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT)
{ {
indexY -= Level::COMPRESSED_CHUNK_SECTION_HEIGHT; indexY -= Level::COMPRESSED_CHUNK_SECTION_HEIGHT;
offset = Level::COMPRESSED_CHUNK_SECTION_TILES; offset = Level::COMPRESSED_CHUNK_SECTION_TILES;
} }
unsigned char tileId = tileIds[ offset + ( ( ( xx + 0 ) << 11 ) | ( ( zz + 0 ) << 7 ) | ( indexY + 0 ) ) ]; unsigned char tileId = tileIds[offset + ((xx << 11) | (zz << 7) | indexY)];
if( tileId > 0 ) empty = false; if (tileId > 0) empty = false;
// Don't bother trying to work out neighbours for this tile if we are at the edge of the chunk - apart from the very if (yy == (Level::maxBuildHeight - 1)) continue;
// bottom of the world where we shouldn't ever be able to see if ((xx == 0) || (xx == 15)) continue;
if( yy == (Level::maxBuildHeight - 1) ) continue; if ((zz == 0) || (zz == 15)) continue;
if(( xx == 0 ) || ( xx == 15 )) continue;
if(( zz == 0 ) || ( zz == 15 )) continue;
// Establish whether this tile and its neighbours are all made of rock, dirt, unbreakable tiles, or have already if (!isSolid(tileId)) continue;
// been determined to meet this criteria themselves and have a tile of 255 set. if (!isSolid(tileIds[offset + (((xx - 1) << 11) | (zz << 7) | indexY)])) continue;
if( !( ( tileId == Tile::stone_Id ) || ( tileId == Tile::dirt_Id ) || ( tileId == Tile::unbreakable_Id ) || ( tileId == 255) ) ) continue; if (!isSolid(tileIds[offset + (((xx + 1) << 11) | (zz << 7) | indexY)])) continue;
tileId = tileIds[ offset + ( ( ( xx - 1 ) << 11 ) | ( ( zz + 0 ) << 7 ) | ( indexY + 0 )) ]; if (!isSolid(tileIds[offset + ((xx << 11) | ((zz - 1) << 7) | indexY)])) continue;
if( !( ( tileId == Tile::stone_Id ) || ( tileId == Tile::dirt_Id ) || ( tileId == Tile::unbreakable_Id ) || ( tileId == 255) ) ) continue; if (!isSolid(tileIds[offset + ((xx << 11) | ((zz + 1) << 7) | indexY)])) continue;
tileId = tileIds[ offset + ( ( ( xx + 1 ) << 11 ) | ( ( zz + 0 ) << 7 ) | ( indexY + 0 )) ];
if( !( ( tileId == Tile::stone_Id ) || ( tileId == Tile::dirt_Id ) || ( tileId == Tile::unbreakable_Id ) || ( tileId == 255) ) ) continue; if (yy > 0)
tileId = tileIds[ offset + ( ( ( xx + 0 ) << 11 ) | ( ( zz - 1 ) << 7 ) | ( indexY + 0 )) ];
if( !( ( tileId == Tile::stone_Id ) || ( tileId == Tile::dirt_Id ) || ( tileId == Tile::unbreakable_Id ) || ( tileId == 255) ) ) continue;
tileId = tileIds[ offset + ( ( ( xx + 0 ) << 11 ) | ( ( zz + 1 ) << 7 ) | ( indexY + 0 )) ];
if( !( ( tileId == Tile::stone_Id ) || ( tileId == Tile::dirt_Id ) || ( tileId == Tile::unbreakable_Id ) || ( tileId == 255) ) ) continue;
// Treat the bottom of the world differently - we shouldn't ever be able to look up at this, so consider tiles as invisible
// if they are surrounded on sides other than the bottom
if( yy > 0 )
{ {
int indexYMinusOne = yy - 1; int idxYm1 = yy - 1;
int yMinusOneOffset = 0; int offYm1 = 0;
if(indexYMinusOne >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT) if (idxYm1 >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT)
{ {
indexYMinusOne -= Level::COMPRESSED_CHUNK_SECTION_HEIGHT; idxYm1 -= Level::COMPRESSED_CHUNK_SECTION_HEIGHT;
yMinusOneOffset = Level::COMPRESSED_CHUNK_SECTION_TILES; offYm1 = Level::COMPRESSED_CHUNK_SECTION_TILES;
} }
tileId = tileIds[ yMinusOneOffset + ( ( ( xx + 0 ) << 11 ) | ( ( zz + 0 ) << 7 ) | indexYMinusOne ) ]; if (!isSolid(tileIds[offYm1 + ((xx << 11) | (zz << 7) | idxYm1)])) continue;
if( !( ( tileId == Tile::stone_Id ) || ( tileId == Tile::dirt_Id ) || ( tileId == Tile::unbreakable_Id ) || ( tileId == 255) ) ) continue;
} }
int indexYPlusOne = yy + 1;
int yPlusOneOffset = 0;
if(indexYPlusOne >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT)
{
indexYPlusOne -= Level::COMPRESSED_CHUNK_SECTION_HEIGHT;
yPlusOneOffset = Level::COMPRESSED_CHUNK_SECTION_TILES;
}
tileId = tileIds[ yPlusOneOffset + ( ( ( xx + 0 ) << 11 ) | ( ( zz + 0 ) << 7 ) | indexYPlusOne ) ];
if( !( ( tileId == Tile::stone_Id ) || ( tileId == Tile::dirt_Id ) || ( tileId == Tile::unbreakable_Id ) || ( tileId == 255) ) ) continue;
// This tile is surrounded. Flag it as not requiring to be rendered by setting its id to 255. int idxYp1 = yy + 1;
tileIds[ offset + ( ( ( xx + 0 ) << 11 ) | ( ( zz + 0 ) << 7 ) | ( indexY + 0 ) ) ] = 0xff; int offYp1 = 0;
if (idxYp1 >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT)
{
idxYp1 -= Level::COMPRESSED_CHUNK_SECTION_HEIGHT;
offYp1 = Level::COMPRESSED_CHUNK_SECTION_TILES;
}
if (!isSolid(tileIds[offYp1 + ((xx << 11) | (zz << 7) | idxYp1)])) continue;
tileIds[offset + ((xx << 11) | (zz << 7) | indexY)] = 0xff;
} }
} }
} }
#endif // _WINDOWS64
PIXEndNamedEvent(); PIXEndNamedEvent();
// Nothing at all to do for this chunk?
if( empty ) if (empty)
{ {
// 4J - added - clear any renderer data associated with this
for (int currentLayer = 0; currentLayer < 2; currentLayer++) for (int currentLayer = 0; currentLayer < 2; currentLayer++)
{ {
levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level, LevelRenderer::CHUNK_FLAG_EMPTY0, currentLayer); levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level,
LevelRenderer::CHUNK_FLAG_EMPTY0, currentLayer);
RenderManager.CBuffClear(lists + currentLayer); RenderManager.CBuffClear(lists + currentLayer);
} }
delete region;
delete tileRenderer;
return; return;
} }
// 4J - optimisation ends
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
PIXBeginNamedEvent(0,"Rebuild section C"); PIXBeginNamedEvent(0, "Rebuild section C");
Tesselator::Bounds bounds; // 4J MGH - added Tesselator::Bounds bounds;
{ {
// this was the old default clip bounds for the chunk, set in Chunk::setPos. const float g = 6.0f;
float g = 6.0f; bounds.boundingBox[0] = -g; bounds.boundingBox[3] = XZSIZE + g;
bounds.boundingBox[0] = -g; bounds.boundingBox[1] = -g; bounds.boundingBox[4] = SIZE + g;
bounds.boundingBox[1] = -g; bounds.boundingBox[2] = -g; bounds.boundingBox[5] = XZSIZE + g;
bounds.boundingBox[2] = -g;
bounds.boundingBox[3] = XZSIZE+g;
bounds.boundingBox[4] = SIZE+g;
bounds.boundingBox[5] = XZSIZE+g;
} }
for (int currentLayer = 0; currentLayer < 2; currentLayer++) for (int currentLayer = 0; currentLayer < 2; currentLayer++)
{ {
bool renderNextLayer = false; bool renderNextLayer = false;
bool rendered = false; bool rendered = false;
bool started = false; bool started = false;
const bool collectEntities = (currentLayer == 0);
auto ensureStarted = [&]()
{
if (started) return;
started = true;
MemSect(31);
glNewList(lists + currentLayer, GL_COMPILE);
MemSect(0);
glPushMatrix();
glDepthMask(true);
t->useCompactVertices(true);
translateToPos();
t->begin();
t->offset(static_cast<float>(-this->x),
static_cast<float>(-this->y),
static_cast<float>(-this->z));
};
auto processTile = [&](unsigned char tileId, int tx, int ty, int tz)
{
Tile* tile = Tile::tiles[tileId];
if (!tile) [[unlikely]] return;
if (collectEntities && tile->isEntityTile())
{
shared_ptr<TileEntity> et = region.getTileEntity(tx, ty, tz);
if (TileEntityRenderDispatcher::instance->hasRenderer(et))
renderableTileEntities.push_back(et);
}
const int renderLayer = tile->getRenderLayer();
if (renderLayer != currentLayer)
renderNextLayer = true;
else
rendered |= tileRenderer.tesselateInWorld(tile, tx, ty, tz);
};
// 4J - changed loop order here to leave y as the innermost loop for better cache performance
for (int z = z0; z < z1; z++) for (int z = z0; z < z1; z++)
{ {
for (int x = x0; x < x1; x++) for (int x = x0; x < x1; x++)
{ {
for (int y = y0; y < y1; y++) const int xzIndex = ((x - x0) << 11) | ((z - z0) << 7);
const int yLow1 = min(y1, Level::COMPRESSED_CHUNK_SECTION_HEIGHT);
for (int y = y0; y < yLow1; y++)
{ {
// 4J Stu - tile data is ordered in 128 blocks of full width, lower 128 then upper 128 const unsigned char tileId = tileIds[xzIndex | y];
int indexY = y; if (tileId == 0xff || tileId == 0) continue;
int offset = 0; ensureStarted();
if(indexY >= Level::COMPRESSED_CHUNK_SECTION_HEIGHT) processTile(tileId, x, y, z);
}
if (y1 > Level::COMPRESSED_CHUNK_SECTION_HEIGHT)
{
const unsigned char* tilesHigh =
tileIds + Level::COMPRESSED_CHUNK_SECTION_TILES;
for (int y = Level::COMPRESSED_CHUNK_SECTION_HEIGHT; y < y1; y++)
{ {
indexY -= Level::COMPRESSED_CHUNK_SECTION_HEIGHT; const int indexY = y - Level::COMPRESSED_CHUNK_SECTION_HEIGHT;
offset = Level::COMPRESSED_CHUNK_SECTION_TILES; const unsigned char tileId = tilesHigh[xzIndex | indexY];
} if (tileId == 0xff || tileId == 0) continue;
ensureStarted();
// 4J - get tile from those copied into our local array in earlier optimisation processTile(tileId, x, y, z);
unsigned char tileId = tileIds[ offset + ( ( ( x - x0 ) << 11 ) | ( ( z - z0 ) << 7 ) | indexY) ];
// If flagged as not visible, drop out straight away
if( tileId == 0xff ) continue;
// int tileId = region->getTile(x,y,z);
if (tileId > 0)
{
if (!started)
{
started = true;
MemSect(31);
glNewList(lists + currentLayer, GL_COMPILE);
MemSect(0);
glPushMatrix();
glDepthMask(true); // 4J added
t->useCompactVertices(true); // 4J added
translateToPos();
float ss = 1.000001f;
// 4J - have removed this scale as I don't think we should need it, and have now optimised the vertex
// shader so it doesn't do anything other than translate with this matrix anyway
#if 0
glTranslatef(-zs / 2.0f, -ys / 2.0f, -zs / 2.0f);
glScalef(ss, ss, ss);
glTranslatef(zs / 2.0f, ys / 2.0f, zs / 2.0f);
#endif
t->begin();
t->offset(static_cast<float>(-this->x), static_cast<float>(-this->y), static_cast<float>(-this->z));
}
Tile *tile = Tile::tiles[tileId];
if (currentLayer == 0 && tile->isEntityTile())
{
shared_ptr<TileEntity> et = region->getTileEntity(x, y, z);
if (TileEntityRenderDispatcher::instance->hasRenderer(et))
{
renderableTileEntities.push_back(et);
}
}
int renderLayer = tile->getRenderLayer();
if (renderLayer != currentLayer)
{
renderNextLayer = true;
}
else if (renderLayer == currentLayer)
{
rendered |= tileRenderer->tesselateInWorld(tile, x, y, z);
}
} }
} }
} }
} }
#ifdef __PSVITA__ #ifdef __PSVITA__
if( currentLayer==0 ) if (currentLayer == 0)
{ levelRenderer->clearGlobalChunkFlag(this->x, this->y, this->z, level,
levelRenderer->clearGlobalChunkFlag(this->x, this->y, this->z, level, LevelRenderer::CHUNK_FLAG_CUT_OUT); LevelRenderer::CHUNK_FLAG_CUT_OUT);
}
#endif #endif
if (started) if (started)
{ {
#ifdef __PSVITA__ #ifdef __PSVITA__
// AP - make sure we don't attempt to render chunks without cutout geometry if (t->getCutOutFound())
if( t->getCutOutFound() ) levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level,
{ LevelRenderer::CHUNK_FLAG_CUT_OUT);
levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level, LevelRenderer::CHUNK_FLAG_CUT_OUT);
}
#endif #endif
t->end(); t->end();
bounds.addBounds(t->bounds); // 4J MGH - added bounds.addBounds(t->bounds);
glPopMatrix(); glPopMatrix();
glEndList(); glEndList();
t->useCompactVertices(false); // 4J added t->useCompactVertices(false);
t->offset(0, 0, 0); t->offset(0, 0, 0);
} }
else else
@ -455,165 +567,92 @@ void Chunk::rebuild()
} }
if (rendered) if (rendered)
{ levelRenderer->clearGlobalChunkFlag(this->x, this->y, this->z, level,
levelRenderer->clearGlobalChunkFlag(this->x, this->y, this->z, level, LevelRenderer::CHUNK_FLAG_EMPTY0, currentLayer); LevelRenderer::CHUNK_FLAG_EMPTY0, currentLayer);
}
else else
{ {
// 4J - added - clear any renderer data associated with this unused list levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level,
levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level, LevelRenderer::CHUNK_FLAG_EMPTY0, currentLayer); LevelRenderer::CHUNK_FLAG_EMPTY0, currentLayer);
RenderManager.CBuffClear(lists + currentLayer); RenderManager.CBuffClear(lists + currentLayer);
} }
if((currentLayer==0)&&(!renderNextLayer))
if ((currentLayer == 0) && (!renderNextLayer))
{ {
levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level, LevelRenderer::CHUNK_FLAG_EMPTY1); levelRenderer->setGlobalChunkFlag(this->x, this->y, this->z, level,
LevelRenderer::CHUNK_FLAG_EMPTY1);
RenderManager.CBuffClear(lists + 1); RenderManager.CBuffClear(lists + 1);
break; break;
} }
} }
// 4J MGH - added this to take the bound from the value calc'd in the tesselator if (bb)
if( bb )
{ {
bb->set(bounds.boundingBox[0], bounds.boundingBox[1], bounds.boundingBox[2], bb->set(bounds.boundingBox[0], bounds.boundingBox[1], bounds.boundingBox[2],
bounds.boundingBox[3], bounds.boundingBox[4], bounds.boundingBox[5]); bounds.boundingBox[3], bounds.boundingBox[4], bounds.boundingBox[5]);
} }
delete tileRenderer;
delete region;
PIXEndNamedEvent(); PIXEndNamedEvent();
PIXBeginNamedEvent(0,"Rebuild section D"); PIXBeginNamedEvent(0, "Rebuild section D");
// 4J - have rewritten the way that tile entities are stored globally to make it work more easily with split screen. Chunks are now
// stored globally in the levelrenderer, in a hashmap with a special key made up from the dimension and chunk position (using same index const int key = levelRenderer->getGlobalIndexForChunk(this->x, this->y, this->z, level);
// as is used for global flags)
#if 1 unordered_set<shared_ptr<TileEntity>> newEntitiesSet(
int key = levelRenderer->getGlobalIndexForChunk(this->x,this->y,this->z,level); renderableTileEntities.begin(), renderableTileEntities.end());
EnterCriticalSection(globalRenderableTileEntities_cs);
if( renderableTileEntities.size() ) vector<shared_ptr<TileEntity>> toAdd;
vector<shared_ptr<TileEntity>> toRemove;
{ {
auto it = globalRenderableTileEntities->find(key); EnterCriticalSection(globalRenderableTileEntities_cs);
if( it != globalRenderableTileEntities->end() ) auto it = globalRenderableTileEntities->find(key);
{ if (it != globalRenderableTileEntities->end())
// We've got some renderable tile entities that we want associated with this chunk, and an existing list of things that used to be. for (const auto& existing : it->second)
// We need to flag any that we don't need any more to be removed, keep those that we do, and add any new ones if (newEntitiesSet.count(existing) == 0)
toRemove.push_back(existing);
// First pass - flag everything already existing to be removed LeaveCriticalSection(globalRenderableTileEntities_cs);
for(auto& it2 : it->second)
{
it2->setRenderRemoveStage(TileEntity::e_RenderRemoveStageFlaggedAtChunk);
}
// Now go through the current list. If these are already in the list, then unflag the remove flag. If they aren't, then add
for(const auto& it3 : renderableTileEntities)
{
auto it2 = find(it->second.begin(), it->second.end(), it3);
if( it2 == it->second.end() )
{
(*globalRenderableTileEntities)[key].push_back(it3);
}
else
{
(*it2)->setRenderRemoveStage(TileEntity::e_RenderRemoveStageKeep);
}
}
}
else
{
// Easy case - nothing already existing for this chunk. Add them all in.
for( size_t i = 0; i < renderableTileEntities.size(); i++ )
{
(*globalRenderableTileEntities)[key].push_back(renderableTileEntities[i]);
}
}
} }
else
{ {
// Another easy case - we don't want any renderable tile entities associated with this chunk. Flag all to be removed. EnterCriticalSection(globalRenderableTileEntities_cs);
auto it = globalRenderableTileEntities->find(key); auto it = globalRenderableTileEntities->find(key);
if( it != globalRenderableTileEntities->end() ) const bool hasEx = (it != globalRenderableTileEntities->end());
for (const auto& fresh : renderableTileEntities)
if (!hasEx || find(it->second.begin(), it->second.end(), fresh) == it->second.end())
toAdd.push_back(fresh);
LeaveCriticalSection(globalRenderableTileEntities_cs);
}
EnterCriticalSection(globalRenderableTileEntities_cs);
{
for (auto& e : toRemove)
e->setRenderRemoveStage(TileEntity::e_RenderRemoveStageFlaggedAtChunk);
if (!renderableTileEntities.empty())
{ {
for(auto& it2 : it->second) auto it = globalRenderableTileEntities->find(key);
{ if (it != globalRenderableTileEntities->end())
it2->setRenderRemoveStage(TileEntity::e_RenderRemoveStageFlaggedAtChunk); for (auto& existing : it->second)
} if (newEntitiesSet.count(existing) > 0)
existing->setRenderRemoveStage(TileEntity::e_RenderRemoveStageKeep);
} }
auto& globalList = (*globalRenderableTileEntities)[key];
for (auto& e : toAdd)
globalList.push_back(e);
} }
LeaveCriticalSection(globalRenderableTileEntities_cs); LeaveCriticalSection(globalRenderableTileEntities_cs);
PIXEndNamedEvent(); PIXEndNamedEvent();
#else
// Find the removed ones:
// 4J - original code for this section: if (LevelChunk::touchedSky)
/*
Set<TileEntity> newTileEntities = new HashSet<TileEntity>();
newTileEntities.addAll(renderableTileEntities);
newTileEntities.removeAll(oldTileEntities);
globalRenderableTileEntities.addAll(newTileEntities);
oldTileEntities.removeAll(renderableTileEntities);
globalRenderableTileEntities.removeAll(oldTileEntities);
*/
unordered_set<shared_ptr<TileEntity> > newTileEntities(renderableTileEntities.begin(),renderableTileEntities.end());
auto endIt = oldTileEntities.end();
for( unordered_set<shared_ptr<TileEntity> >::iterator it = oldTileEntities.begin(); it != endIt; it++ )
{
newTileEntities.erase(*it);
}
// 4J - newTileEntities is now renderableTileEntities with any old ones from oldTileEntitesRemoved (so just new things added)
EnterCriticalSection(globalRenderableTileEntities_cs);
endIt = newTileEntities.end();
for( unordered_set<shared_ptr<TileEntity> >::iterator it = newTileEntities.begin(); it != endIt; it++ )
{
globalRenderableTileEntities->push_back(*it);
}
// 4J - All these new things added to globalRenderableTileEntities
auto endItRTE = renderableTileEntities.end();
for( vector<shared_ptr<TileEntity> >::iterator it = renderableTileEntities.begin(); it != endItRTE; it++ )
{
oldTileEntities.erase(*it);
}
// 4J - oldTileEntities is now the removed items
vector<shared_ptr<TileEntity> >::iterator it = globalRenderableTileEntities->begin();
while( it != globalRenderableTileEntities->end() )
{
if( oldTileEntities.find(*it) != oldTileEntities.end() )
{
it = globalRenderableTileEntities->erase(it);
}
else
{
++it;
}
}
LeaveCriticalSection(globalRenderableTileEntities_cs);
#endif
// 4J - These removed items are now also removed from globalRenderableTileEntities
if( LevelChunk::touchedSky )
{
levelRenderer->clearGlobalChunkFlag(x, y, z, level, LevelRenderer::CHUNK_FLAG_NOTSKYLIT); levelRenderer->clearGlobalChunkFlag(x, y, z, level, LevelRenderer::CHUNK_FLAG_NOTSKYLIT);
}
else else
{
levelRenderer->setGlobalChunkFlag(x, y, z, level, LevelRenderer::CHUNK_FLAG_NOTSKYLIT); levelRenderer->setGlobalChunkFlag(x, y, z, level, LevelRenderer::CHUNK_FLAG_NOTSKYLIT);
}
levelRenderer->setGlobalChunkFlag(x, y, z, level, LevelRenderer::CHUNK_FLAG_COMPILED); levelRenderer->setGlobalChunkFlag(x, y, z, level, LevelRenderer::CHUNK_FLAG_COMPILED);
PIXEndNamedEvent(); PIXEndNamedEvent();
return;
} }
#ifdef __PS3__ #ifdef __PS3__
ChunkRebuildData g_rebuildDataIn __attribute__((__aligned__(16))); ChunkRebuildData g_rebuildDataIn __attribute__((__aligned__(16)));
ChunkRebuildData g_rebuildDataOut __attribute__((__aligned__(16))); ChunkRebuildData g_rebuildDataOut __attribute__((__aligned__(16)));

111
Minecraft.Client/LevelRenderer.cpp
View file

@ -1,4 +1,4 @@
#include "stdafx.h" #include "stdafx.h"
#include "LevelRenderer.h" #include "LevelRenderer.h"
#include "Textures.h" #include "Textures.h"
#include "TextureAtlas.h" #include "TextureAtlas.h"
@ -63,6 +63,12 @@
#include "..\Minecraft.World\BasicTypeContainers.h" #include "..\Minecraft.World\BasicTypeContainers.h"
#include "Common/UI/UIScene_SettingsGraphicsMenu.h" #include "Common/UI/UIScene_SettingsGraphicsMenu.h"
#ifdef _WINDOWS64
#include <emmintrin.h> // SSE2 — _mm_loadu_ps, _mm_setzero_ps
#include <pmmintrin.h> // SSE3 — _mm_hadd_ps
#include <smmintrin.h> // SSE4.1 — _mm_dp_ps, _mm_blendv_ps
#endif
//#define DISABLE_SPU_CODE //#define DISABLE_SPU_CODE
#ifdef __PS3__ #ifdef __PS3__
@ -589,47 +595,26 @@ void LevelRenderer::renderEntities(Vec3 *cam, Culler *culler, float a)
// 4J - have restructed this so that the tile entities are stored within a hashmap by chunk/dimension index. The index // 4J - have restructed this so that the tile entities are stored within a hashmap by chunk/dimension index. The index
// is calculated in the same way as the global flags. // is calculated in the same way as the global flags.
EnterCriticalSection(&m_csRenderableTileEntities); EnterCriticalSection(&m_csRenderableTileEntities);
for (auto & it : renderableTileEntities) for (auto it = renderableTileEntities.begin(); it != renderableTileEntities.end();)
{ {
int idx = it.first; if (!isGlobalIndexInSameDimension(it->first, level[playerIndex]))
// Don't render if it isn't in the same dimension as this player
if( !isGlobalIndexInSameDimension(idx, level[playerIndex]) ) continue;
for( auto& it2 : it.second)
{ {
TileEntityRenderDispatcher::instance->render(it2, a); ++it;
continue;
} }
} for (auto it2 = it->second.begin(); it2 != it->second.end();)
{
// Now consider if any of these renderable tile entities have been flagged for removal, and if so, remove if ((*it2)->shouldRemoveForRender())
for (auto it = renderableTileEntities.begin(); it != renderableTileEntities.end();)
{
int idx = it->first;
for (auto it2 = it->second.begin(); it2 != it->second.end();)
{
// If it has been flagged for removal, remove
if((*it2)->shouldRemoveForRender())
{
it2 = it->second.erase(it2); it2 = it->second.erase(it2);
}
else else
{ {
it2++; TileEntityRenderDispatcher::instance->render(*it2, a);
++it2;
} }
} }
if (it->second.empty()) it = renderableTileEntities.erase(it);
// If there aren't any entities left for this key, then delete the key else ++it;
if( it->second.size() == 0 )
{
it = renderableTileEntities.erase(it);
}
else
{
it++;
}
} }
LeaveCriticalSection(&m_csRenderableTileEntities); LeaveCriticalSection(&m_csRenderableTileEntities);
mc->gameRenderer->turnOffLightLayer(a); // 4J - brought forward from 1.8.2 mc->gameRenderer->turnOffLightLayer(a); // 4J - brought forward from 1.8.2
@ -2449,6 +2434,60 @@ void LevelRenderer::setTilesDirty(int x0, int y0, int z0, int x1, int y1, int z1
setDirty(x0 - 1, y0 - 1, z0 - 1, x1 + 1, y1 + 1, z1 + 1, level); setDirty(x0 - 1, y0 - 1, z0 - 1, x1 + 1, y1 + 1, z1 + 1, level);
} }
#ifdef _WINDOWS64
// ── SSE4.1 версия frustum-теста ─────────────────────────────────────────────
//
// Алгоритм «p-vertex»:
// Для каждой из 6 плоскостей frustum выбирается угол AABB («p-вершина»),
// который даёт максимальный dot-product с нормалью плоскости.
// Если даже этот угол находится за плоскостью — AABB полностью снаружи.
//
// SSE4.1 улучшения по сравнению с SSE2:
// _mm_blendv_ps — выбор p-вершины без AND/ANDNOT/OR (1 инструкция вместо 3)
// _mm_dp_ps — dot-product за 1 инструкцию вместо mul+hadd+hadd
// ────────────────────────────────────────────────────────────────────────────
inline bool clip_SSE41(const float* __restrict bb, const float* __restrict frustum)
{
// bb = [x0, y0, z0, x1, y1, z1]
// w=1.0f чтобы plane.w*pVertex.w = plane.w (свободный член уравнения плоскости)
const __m128 bbMin = _mm_set_ps(1.0f, bb[2], bb[1], bb[0]); // [x0, y0, z0, 1]
const __m128 bbMax = _mm_set_ps(1.0f, bb[5], bb[4], bb[3]); // [x1, y1, z1, 1]
const __m128 zero = _mm_setzero_ps();
for (int i = 0; i < 6; i++, frustum += 4)
{
// plane = [nx, ny, nz, d] — уравнение плоскости: nx*x + ny*y + nz*z + d
const __m128 plane = _mm_loadu_ps(frustum);
// ── Шаг 1. Выбор p-вершины через SSE4.1 blendv ──────────────────────
// blendv выбирает bbMax там где plane >= 0, bbMin — где plane < 0.
// Это эквивалентно: pVertex[i] = (plane[i] >= 0) ? bbMax[i] : bbMin[i]
// Было (SSE2): 3 инструкции AND + ANDNOT + OR
// Стало (SSE4.1): 1 инструкция blendv
const __m128 planeMask = _mm_cmpge_ps(plane, zero);
const __m128 pVertex = _mm_blendv_ps(bbMin, bbMax, planeMask);
// ── Шаг 2. Dot-product через SSE4.1 dp_ps ───────────────────────────
// Маска 0xFF = 1111_1111b:
// старшие 4 бита (1111) — перемножаем все 4 компоненты (x, y, z, w)
// младшие 4 бита (1111) — записываем результат во все 4 слота
// Результат: plane.x*pVertex.x + plane.y*pVertex.y +
// plane.z*pVertex.z + plane.w*1.0f
// = nx*x + ny*y + nz*z + d
// Было (SSE3): mul + hadd + hadd — 3 инструкции
// Стало (SSE4.1): 1 инструкция dp_ps
const __m128 dot = _mm_dp_ps(plane, pVertex, 0xFF);
// ── Шаг 3. Тест: p-вершина за плоскостью? ───────────────────────────
// _mm_comile_ss: scalar compare lower element, returns int
// Возвращает 1 если dot[0] <= 0.0f — AABB полностью за этой плоскостью
if (_mm_comile_ss(dot, zero))
return false;
}
return true;
}
#endif
bool inline clip(float *bb, float *frustum) bool inline clip(float *bb, float *frustum)
{ {
for (int i = 0; i < 6; ++i, frustum += 4) for (int i = 0; i < 6; ++i, frustum += 4)
@ -2578,7 +2617,11 @@ void LevelRenderer::cull(Culler *culler, float a)
unsigned char flags = pClipChunk->globalIdx == -1 ? 0 : globalChunkFlags[ pClipChunk->globalIdx ]; unsigned char flags = pClipChunk->globalIdx == -1 ? 0 : globalChunkFlags[ pClipChunk->globalIdx ];
// Always perform frustum cull test // Always perform frustum cull test
#ifdef _WINDOWS64
bool clipres = clip_SSE41(pClipChunk->aabb, fdraw);
#else
bool clipres = clip(pClipChunk->aabb, fdraw); bool clipres = clip(pClipChunk->aabb, fdraw);
#endif
if ( (flags & CHUNK_FLAG_COMPILED ) && ( ( flags & CHUNK_FLAG_EMPTYBOTH ) != CHUNK_FLAG_EMPTYBOTH ) ) if ( (flags & CHUNK_FLAG_COMPILED ) && ( ( flags & CHUNK_FLAG_EMPTYBOTH ) != CHUNK_FLAG_EMPTYBOTH ) )
{ {

5
Minecraft.Client/LevelRenderer.h
View file

@ -1,4 +1,4 @@
#pragma once #pragma once
#include "..\Minecraft.World\LevelListener.h" #include "..\Minecraft.World\LevelListener.h"
#include "..\Minecraft.World\Definitions.h" #include "..\Minecraft.World\Definitions.h"
#include "OffsettedRenderList.h" #include "OffsettedRenderList.h"
@ -70,6 +70,7 @@ private:
void createCloudMesh(); // 4J added void createCloudMesh(); // 4J added
public: public:
void setLevel(int playerIndex, MultiPlayerLevel *level); void setLevel(int playerIndex, MultiPlayerLevel *level);
void rebuildGlobalIdxMap(int playerIndex);
void allChanged(); void allChanged();
void allChanged(int playerIndex); void allChanged(int playerIndex);
@ -275,7 +276,7 @@ public:
static const int FORCE_DIRTY_CHUNK_CHECK_PERIOD_MS = 125; // decreased from 250 to 125 - updated by detectiveren static const int FORCE_DIRTY_CHUNK_CHECK_PERIOD_MS = 125; // decreased from 250 to 125 - updated by detectiveren
#ifdef _LARGE_WORLDS #ifdef _LARGE_WORLDS
static const int MAX_CONCURRENT_CHUNK_REBUILDS = 8; // increased from 4 to 8 - updated by detectiveren static const int MAX_CONCURRENT_CHUNK_REBUILDS = 3; // increased from 4 to 8 - updated by detectiveren
static const int MAX_CHUNK_REBUILD_THREADS = MAX_CONCURRENT_CHUNK_REBUILDS - 1; static const int MAX_CHUNK_REBUILD_THREADS = MAX_CONCURRENT_CHUNK_REBUILDS - 1;
static Chunk permaChunk[MAX_CONCURRENT_CHUNK_REBUILDS]; static Chunk permaChunk[MAX_CONCURRENT_CHUNK_REBUILDS];
static C4JThread *rebuildThreads[MAX_CHUNK_REBUILD_THREADS]; static C4JThread *rebuildThreads[MAX_CHUNK_REBUILD_THREADS];

15
Minecraft.World/Tile.cpp
View file

@ -818,8 +818,13 @@ Icon *Tile::getTexture(int face)
AABB *Tile::getTileAABB(Level *level, int x, int y, int z) AABB *Tile::getTileAABB(Level *level, int x, int y, int z)
{ {
ThreadStorage *tls = static_cast<ThreadStorage *>(TlsGetValue(Tile::tlsIdxShape)); ThreadStorage *tls = static_cast<ThreadStorage *>(TlsGetValue(Tile::tlsIdxShape));
if (tls == nullptr)
return AABB::newTemp(x, y, z, x, y, z);
// 4J Stu - Added this so that the TLS shape is correct for this tile // 4J Stu - Added this so that the TLS shape is correct for this tile
if(tls->tileId != this->id) updateDefaultShape(); if(tls->tileId != this->id)
updateDefaultShape();
return AABB::newTemp(x + tls->xx0, y + tls->yy0, z + tls->zz0, x + tls->xx1, y + tls->yy1, z + tls->zz1); return AABB::newTemp(x + tls->xx0, y + tls->yy0, z + tls->zz0, x + tls->xx1, y + tls->yy1, z + tls->zz1);
} }
@ -832,8 +837,14 @@ void Tile::addAABBs(Level *level, int x, int y, int z, AABB *box, AABBList *boxe
AABB *Tile::getAABB(Level *level, int x, int y, int z) AABB *Tile::getAABB(Level *level, int x, int y, int z)
{ {
ThreadStorage *tls = static_cast<ThreadStorage *>(TlsGetValue(Tile::tlsIdxShape)); ThreadStorage *tls = static_cast<ThreadStorage *>(TlsGetValue(Tile::tlsIdxShape));
if (tls == nullptr)
return AABB::newTemp(x, y, z, x, y, z);
// 4J Stu - Added this so that the TLS shape is correct for this tile // 4J Stu - Added this so that the TLS shape is correct for this tile
if(tls->tileId != this->id) updateDefaultShape(); if(tls->tileId != this->id)
updateDefaultShape();
return AABB::newTemp(x + tls->xx0, y + tls->yy0, z + tls->zz0, x + tls->xx1, y + tls->yy1, z + tls->zz1); return AABB::newTemp(x + tls->xx0, y + tls->yy0, z + tls->zz0, x + tls->xx1, y + tls->yy1, z + tls->zz1);
} }