backups/MinecraftConsoles
2
0
Fork 1
mirror of https://github.com/smartcmd/MinecraftConsoles.git synced 2026-08-20 09:57:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

info about size limits

Browse source 
not sure if this is what you meant by 'could you document where this maximum comes from in the code' but i assume you meant this
This commit is contained in:
JuelzIrons 2026-03-10 00:37:28 -04:00
parent 1cfad1a88c
commit c50e06f564
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Minecraft.Client/Durango/Network/DQRNetworkManager_SendReceive.cpp
View file

@ -217,7 +217,8 @@ void DQRNetworkManager::BytesReceivedInternal(DQRConnectionInfo *connectionInfo,
memcpy( &receivedSize, connectionInfo->m_pucRoomSyncData, 4); memcpy( &receivedSize, connectionInfo->m_pucRoomSyncData, 4);
delete [] connectionInfo->m_pucRoomSyncData; delete [] connectionInfo->m_pucRoomSyncData;
if( receivedSize < 0 || receivedSize > 1048576 ) // a 512KB limit gives enough headroom for legitimate XUID data, but prevents a overflow. With 2 players the size is about 100kb so 512kb gives good headroom
if( receivedSize < 0 || receivedSize > 524288 )
{ {
DQRNetworkManager::LogCommentFormat(L"RoomSyncData rejected: size=%d", receivedSize); DQRNetworkManager::LogCommentFormat(L"RoomSyncData rejected: size=%d", receivedSize);
connectionInfo->m_internalDataState = DQRConnectionInfo::ConnectionState_InternalHeaderByte; connectionInfo->m_internalDataState = DQRConnectionInfo::ConnectionState_InternalHeaderByte;
@ -321,7 +322,8 @@ void DQRNetworkManager::BytesReceivedInternal(DQRConnectionInfo *connectionInfo,
memcpy( &receivedSize, connectionInfo->m_pucAddFailedPlayerData, 4); memcpy( &receivedSize, connectionInfo->m_pucAddFailedPlayerData, 4);
delete [] connectionInfo->m_pucAddFailedPlayerData; delete [] connectionInfo->m_pucAddFailedPlayerData;
if( receivedSize < 0 || receivedSize > 1048576 ) // a 512KB limit gives enough headroom for legitimate XUID strings, but prevents a overflow.
if( receivedSize < 0 || receivedSize > 524288 )
{ {
DQRNetworkManager::LogCommentFormat(L"AddFailedPlayerData rejected: size=%d", receivedSize); DQRNetworkManager::LogCommentFormat(L"AddFailedPlayerData rejected: size=%d", receivedSize);
connectionInfo->m_internalDataState = DQRConnectionInfo::ConnectionState_InternalHeaderByte; connectionInfo->m_internalDataState = DQRConnectionInfo::ConnectionState_InternalHeaderByte;