From aca05bad7bca52f40ad038aac775df2a202818ee Mon Sep 17 00:00:00 2001 From: sylvessa <225480449+sylvessa@users.noreply.github.com> Date: Sun, 22 Mar 2026 15:52:48 -0500 Subject: [PATCH] fix a bug with playerjoinevent (temporary fix) --- Minecraft.Client/PlayerList.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Minecraft.Client/PlayerList.cpp b/Minecraft.Client/PlayerList.cpp index ba82ec6ac..4dd3a0c33 100644 --- a/Minecraft.Client/PlayerList.cpp +++ b/Minecraft.Client/PlayerList.cpp @@ -86,6 +86,7 @@ PlayerList::~PlayerList() bool PlayerList::placeNewPlayer(Connection *connection, shared_ptr player, shared_ptr packet) { + // todo: we should move emit player join event here CompoundTag *playerTag = load(player); bool newPlayer = playerTag == nullptr; @@ -283,7 +284,9 @@ bool PlayerList::placeNewPlayer(Connection *connection, shared_ptr // 4J-PB - removed, since it needs to be localised in the language the client is in //server->players->broadcastAll( shared_ptr( new ChatPacket(L"�e" + playerEntity->name + L" joined the game.") ) ); +#if !(defined(_WINDOWS64) && defined(MINECRAFT_SERVER_BUILD)) broadcastAll(std::make_shared(player->name, ChatPacket::e_ChatPlayerJoinedGame)); +#endif MemSect(14); add(player);