backups/MinecraftConsoles
2
0
Fork 1
mirror of https://github.com/smartcmd/MinecraftConsoles.git synced 2026-08-20 09:57:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix fatal bug where skins with no additional boxes would crash the game

Browse source
This commit is contained in:
Botch 2026-03-26 20:03:30 -06:00 committed by GitHub
parent c69c8eeee1
commit 77c235ee67
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Minecraft.Client/PlayerRenderer.cpp
View file

@ -522,13 +522,13 @@ void PlayerRenderer::renderHand()
//Render custom skin boxes on viewmodel - Botch //Render custom skin boxes on viewmodel - Botch
vector<ModelPart*>* mdlprts = Minecraft::GetInstance()->player->GetAdditionalModelParts(); vector<ModelPart*>* additionalModelParts = Minecraft::GetInstance()->player->GetAdditionalModelParts();
if (!additionalModelParts) return; //If there are no custom boxes, return. This fixes bug where the game will crash if you select a skin with no additional boxes.
vector<ModelPart*> armchildren = humanoidModel->arm0->children; vector<ModelPart*> armchildren = humanoidModel->arm0->children;
std::unordered_set<ModelPart*> additionalModelPartSet(additionalModelParts->begin(), additionalModelParts->end());
std::unordered_set<ModelPart*> mdlSet(mdlprts->begin(), mdlprts->end());
for (const auto& x : armchildren) { for (const auto& x : armchildren) {
if (x) { if (x) {
if (mdlSet.find(x) != mdlSet.end()) { //This is to verify box is still actually on current skin - Botch if (additionalModelPartSet.find(x) != additionalModelPartSet.end()) { //This is to verify box is still actually on current skin - Botch
glPushMatrix(); glPushMatrix();
//We need to transform to match offset of arm - Botch //We need to transform to match offset of arm - Botch
glTranslatef(-5 * 0.0625f, 2 * 0.0625f, 0); glTranslatef(-5 * 0.0625f, 2 * 0.0625f, 0);