From 39995c59efedae0eed8d005712c6bec3b5f44ded Mon Sep 17 00:00:00 2001 From: Sestain Date: Fri, 27 Mar 2026 07:56:43 +0200 Subject: [PATCH] Better implementation of XMLVersion check --- Minecraft.Client/Common/DLC/DLCManager.cpp | 8 ++++---- Minecraft.Client/Common/DLC/DLCManager.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Minecraft.Client/Common/DLC/DLCManager.cpp b/Minecraft.Client/Common/DLC/DLCManager.cpp index 31e72b982..3ce1d15aa 100644 --- a/Minecraft.Client/Common/DLC/DLCManager.cpp +++ b/Minecraft.Client/Common/DLC/DLCManager.cpp @@ -410,11 +410,11 @@ bool DLCManager::processDLCDataFile(DWORD &dwFilesProcessed, PBYTE pbData, DWORD if( type != e_DLCParamType_Invalid ) { parameterMapping[pParams->dwType] = type; - } - if (parameterName == L"XMLVERSION") - { - bXMLVersion = true; + if (type == e_DLCParamType_XMLVersion) + { + bXMLVersion = true; + } } uiCurrentByte+= sizeof(C4JStorage::DLC_FILE_PARAM)+(pParams->dwWchCount*sizeof(WCHAR)); diff --git a/Minecraft.Client/Common/DLC/DLCManager.h b/Minecraft.Client/Common/DLC/DLCManager.h index d4dd2508e..3ee7671c5 100644 --- a/Minecraft.Client/Common/DLC/DLCManager.h +++ b/Minecraft.Client/Common/DLC/DLCManager.h @@ -31,7 +31,8 @@ public: { e_DLCParamType_Invalid = -1, - e_DLCParamType_DisplayName = 0, + e_DLCParamType_XMLVersion = 0, + e_DLCParamType_DisplayName, e_DLCParamType_ThemeName, e_DLCParamType_Free, // identify free skins e_DLCParamType_Credit, // legal credits for DLC