backups/4jcraft
2
0
Fork 0
mirror of https://github.com/4jcraft/4jcraft.git synced 2026-05-28 03:22:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: switch CompoundTag from unordered_map to flat_map

Browse source
This commit is contained in:
MatthewBeshay 2026-04-03 20:40:19 +11:00
parent 57641ebcca
commit f11473776c
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
targets/nbt/include/nbt/CompoundTag.h
View file

@ -1,6 +1,6 @@
#pragma once
#include <flat_map>
#include <memory>
#include <unordered_map>
#include "ByteArrayTag.h"
#include "ByteTag.h"
@ -16,14 +16,14 @@
class CompoundTag : public Tag {
private:
std::unordered_map<std::wstring, std::unique_ptr<Tag>> tags;
std::flat_map<std::wstring, std::unique_ptr<Tag>> tags;
public:
CompoundTag() : Tag(L"") {}
CompoundTag(const std::wstring& name) : Tag(name) {}
void write(DataOutput* dos) {
for (auto& [key, value] : tags) {
for (auto&& [key, value] : tags) {
Tag::writeNamedTag(value.get(), dos);
}
dos->writeByte(Tag::TAG_End);
@ -49,7 +49,7 @@ public:
std::vector<Tag*> getAllTags() {
std::vector<Tag*> ret;
ret.reserve(tags.size());
for (auto& [key, value] : tags) {
for (auto&& [key, value] : tags) {
ret.push_back(value.get());
}
return ret;
@ -228,7 +228,7 @@ public:
Tag* copy() {
CompoundTag* tag = new CompoundTag(getName());
for (auto& [key, value] : tags) {
for (auto&& [key, value] : tags) {
tag->put(key, value->copy());
}
return tag;
@ -239,7 +239,7 @@ public:
CompoundTag* o = (CompoundTag*)obj;
if (tags.size() == o->tags.size()) {
for (auto& [key, value] : tags) {
for (auto&& [key, value] : tags) {
auto itFind = o->tags.find(key);
if (itFind == o->tags.end() ||
!value->equals(itFind->second.get())) {