From 9c1c1695a788f9bd174caf6e019c85231d234cc8 Mon Sep 17 00:00:00 2001 From: Tropical <42101043+tropicaaal@users.noreply.github.com> Date: Thu, 9 Apr 2026 09:54:29 -0500 Subject: [PATCH] remove outdated docs, move socket implementation to minecraft/ --- targets/app/Network Implementation Notes.md | 48 ------------------- targets/app/ReadMe.txt | 27 ----------- targets/app/common_sources.txt | 1 - .../Network => minecraft/network}/Socket.cpp | 0 targets/minecraft/sources.txt | 1 + 5 files changed, 1 insertion(+), 76 deletions(-) delete mode 100644 targets/app/Network Implementation Notes.md delete mode 100644 targets/app/ReadMe.txt rename targets/{app/common/Network => minecraft/network}/Socket.cpp (100%) diff --git a/targets/app/Network Implementation Notes.md b/targets/app/Network Implementation Notes.md deleted file mode 100644 index 13280a8bb..000000000 --- a/targets/app/Network Implementation Notes.md +++ /dev/null @@ -1,48 +0,0 @@ -# Network Code Implementation Notes - -## Overview - -The networking classes are organized as follows: - -``` - Game \ - ^ | - | | - +-----------------------------+-----------------------------+ | - | | | - v v | -Game Network Manager <--------------------------------> Network Player Interface |- platform independent layers - ^ ^ | - | | | - v | | -Platform Network Manager Interface | | - ^ | / - | | - v v \ -Platform Network Manager Implementation(1) <------> Network Player Implementation (3) | - ^ ^ |_ platform specific layers - | | | - v v | -Platform specific network code(2) Platform specific player code (4) / -``` - -### Notes - -- In general the game should **only communicate with the `GameNetworkManager` and `NetworkPlayerInterface` APIs**, which provide a platform independent interface for networking functionality. The `GameNetworkManager` may in general have code which is aware of the game itself, but it *shouldn't have any platform-specific networking code*. It communicates with a platform specific implementation of a `PlatformNetworkManagerInterface` to achieve this. - -- The platform specific layers shouldn't contain any general game code, as this is much better placed in the platform independent layers to avoid duplicating effort. - -- Platform specific files for each platform for the numbered classes in the previous diagram are currently: - - -## Platform-Specific Files - -The platform-specific implementations for each numbered class in the diagram: - -| Class | Xbox 360 | Sony | Other | -|-------|---------------------------------|----------------------------|-----------------------| -| (1) | PlatformNetworkManagerXbox | PlatformNetworkManagerSony | PlatformNetworkManagerStub | -| (2) | Provided by QNET | SQRNetworkManager | Qnet stub* | -| (3) | NetworkPlayerXbox | NetworkPlayerSony | NetworkPlayerXbox | -| (4) | Provided by QNET | SQRNetworkPlayer | Qnet stub* | -\*Temporarily provided by `extra64.h` diff --git a/targets/app/ReadMe.txt b/targets/app/ReadMe.txt deleted file mode 100644 index f5f0faa17..000000000 --- a/targets/app/ReadMe.txt +++ /dev/null @@ -1,27 +0,0 @@ -======================================================================== - Xbox 360 APPLICATION : Minecraft.Client Project Overview -======================================================================== - -AppWizard has created this Minecraft.Client application for you. - -This file contains a summary of what you will find in each of the files that -make up your Minecraft.Client application. - -Minecraft.Client.vcxproj - This is the main project file for VC++ projects generated using an Application Wizard. - It contains information about the version of Visual C++ that generated the file, and - information about the platforms, configurations, and project features selected with the - Application Wizard. - -Minecraft.Client.cpp - This is the main application source file. - - - -///////////////////////////////////////////////////////////////////////////// -Other notes: - -AppWizard uses "TODO:" comments to indicate parts of the source code you -should add to or customize. - -///////////////////////////////////////////////////////////////////////////// diff --git a/targets/app/common_sources.txt b/targets/app/common_sources.txt index 3a499968a..b289335c3 100644 --- a/targets/app/common_sources.txt +++ b/targets/app/common_sources.txt @@ -53,7 +53,6 @@ common/Network/GameNetworkManager.cpp common/Network/NetworkPlayerQNet.cpp common/Network/PlatformNetworkManagerStub.cpp common/Network/QNetStubs.cpp -common/Network/Socket.cpp common/NetworkController.cpp common/SaveManager.cpp common/SkinManager.cpp diff --git a/targets/app/common/Network/Socket.cpp b/targets/minecraft/network/Socket.cpp similarity index 100% rename from targets/app/common/Network/Socket.cpp rename to targets/minecraft/network/Socket.cpp diff --git a/targets/minecraft/sources.txt b/targets/minecraft/sources.txt index bffb978e4..e5ee3dfa4 100644 --- a/targets/minecraft/sources.txt +++ b/targets/minecraft/sources.txt @@ -286,6 +286,7 @@ locale/I18n.cpp locale/Language.cpp locale/StringTable.cpp network/Connection.cpp +network/Socket.cpp network/packet/AddEntityPacket.cpp network/packet/AddExperienceOrbPacket.cpp network/packet/AddGlobalEntityPacket.cpp