refactor: move leaderboard/network interfaces back into app

targets/app/common/Leaderboards/LeaderboardManager.h

@@ -2,7 +2,7 @@
 
 #include <string>
 
-#include "platform/IPlatformLeaderboard.h"
+#include "app/common/Leaderboards/IPlatformLeaderboard.h"
 
 class LeaderboardManager : public IPlatformLeaderboard {
 public:

targets/app/common/Network/GameNetworkManager.h

@@ -8,7 +8,7 @@
 #include <qnet.h>
 #endif
 #include "platform/PlatformTypes.h"
-#include "platform/IPlatformNetwork.h"
+#include "app/common/Network/IPlatformNetwork.h"
 #include "platform/NetTypes.h"
 #include "minecraft/network/platform/NetworkPlayerInterface.h"
 #include "PlatformNetworkManagerStub.h"

targets/app/common/Network/PlatformNetworkManagerStub.h

@@ -9,7 +9,7 @@
 #include "minecraft/client/model/SkinBox.h"
 #include "platform/XboxStubs.h"
 #include "minecraft/network/platform/NetworkPlayerInterface.h"
-#include "platform/IPlatformNetwork.h"
+#include "app/common/Network/IPlatformNetwork.h"
 #include "minecraft/network/platform/SessionInfo.h"
 #include "platform/C4JThread.h"
 

targets/minecraft/BuildVer.h

@@ -10,6 +10,11 @@
 #define VER_PRODUCTBUILD 560
 // This goes up if there is any change to network traffic or code in a build
 #define VER_NETWORK 560
+
+// Network protocol version. Sent in the pre-login packet so client and
+// server can detect mismatched builds.
+#define MINECRAFT_NET_VERSION VER_NETWORK
+
 #define VER_PRODUCTBUILD_QFE 0
 
 #define VER_FILEVERSION_STRING "1.6"

targets/minecraft/network/packet/PreLoginPacket.cpp

@@ -6,7 +6,6 @@
 #include <cstring>
 
 #include "minecraft/BuildVer.h"
-#include "platform/IPlatformNetwork.h"
 #include "PacketListener.h"
 #include "java/InputOutputStream/DataInputStream.h"
 #include "java/InputOutputStream/DataOutputStream.h"

targets/minecraft/server/network/PendingConnection.cpp

@@ -12,7 +12,6 @@
 #include "minecraft/GameEnums.h"
 #include "minecraft/BuildVer.h"
 #include "minecraft/network/platform/NetworkPlayerInterface.h"
-#include "platform/IPlatformNetwork.h"
 #include "platform/NetTypes.h"
 #include "PlayerConnection.h"
 #include "ServerConnection.h"

targets/platform/IPlatformSound.h

@@ -1,38 +0,0 @@
-#pragma once
-
-#include <memory>
-#include <string>
-
-class File;
-class Mob;
-class Options;
-
-class IPlatformSound {
-public:
-    virtual ~IPlatformSound() = default;
-
-    virtual void init(Options*) = 0;
-    virtual void destroy() = 0;
-    virtual void tick(std::shared_ptr<Mob>* players, float a) = 0;
-
-    // SFX
-    virtual void play(int iSound, float x, float y, float z, float volume,
-                      float pitch) = 0;
-    virtual void playUI(int iSound, float volume, float pitch) = 0;
-
-    // Streaming / music
-    virtual void playStreaming(const std::string& name, float x, float y,
-                               float z, float volume, float pitch,
-                               bool bMusicDelay = true) = 0;
-    virtual void playMusicTick() = 0;
-    virtual void updateMusicVolume(float fVal) = 0;
-    virtual void updateSystemMusicPlaying(bool isPlaying) = 0;
-    virtual void updateSoundEffectVolume(float fVal) = 0;
-
-    // Asset registration
-    virtual void add(const std::string& name, File* file) = 0;
-    virtual void addMusic(const std::string& name, File* file) = 0;
-    virtual void addStreaming(const std::string& name, File* file) = 0;
-    virtual char* ConvertSoundPathToName(const std::string& name,
-                                         bool bConvertSpaces = false) = 0;
-};