From 3f1c95418fa165a8f8d8ba42e039a6503c18ef61 Mon Sep 17 00:00:00 2001 From: MathiewMay Date: Mon, 9 Mar 2026 13:25:56 -0400 Subject: [PATCH] removed the turnOnLightLayer on handRenderer so that it renders correctly (similar to how chunk renderer had to be disbaled for proper rednering) Add nullptr check before calling redner on itemInHandRenderre to prevent a occasional seg fault. --- Minecraft.Client/Rendering/GameRenderer.cpp | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Minecraft.Client/Rendering/GameRenderer.cpp b/Minecraft.Client/Rendering/GameRenderer.cpp index 93490f169..3a135655b 100644 --- a/Minecraft.Client/Rendering/GameRenderer.cpp +++ b/Minecraft.Client/Rendering/GameRenderer.cpp @@ -777,11 +777,14 @@ void GameRenderer::renderItemInHand(float a, int eye) { if (!mc->options->hideGui && !mc->gameMode->isCutScene()) { - turnOnLightLayer(a); + //turnOnLightLayer(a); // disable light layer on handrenderer similarly to how it was done on the chunk render (this makes the hand look proper) PIXBeginNamedEvent(0,"Item in hand render"); - itemInHandRenderer->render(a); + // add null pointer check to itemInHandRenderer to prevent a occasional seg fault + if (itemInHandRenderer != nullptr) { + itemInHandRenderer->render(a); + } PIXEndNamedEvent(); - turnOffLightLayer(a); + //turnOffLightLayer(a); // disable light layer on handrenderer similarly to how it was done on the chunk render (this makes the hand look proper) } } glPopMatrix(); @@ -789,7 +792,10 @@ void GameRenderer::renderItemInHand(float a, int eye) //if (!mc->options->thirdPersonView && !mc->cameraTargetPlayer->isSleeping()) if (!localplayer->ThirdPersonView() && !mc->cameraTargetPlayer->isSleeping()) { - itemInHandRenderer->renderScreenEffect(a); + // add null pointer check to itemInHandRenderer to prevent a occasional seg fault + if (itemInHandRenderer != nullptr) { + itemInHandRenderer->renderScreenEffect(a); + } bobHurt(a); } // 4J-PB - changing this to be per player