From 02efbc3b1bb34b1c6005b73a143a615e16c0636b Mon Sep 17 00:00:00 2001 From: neoapps-dev Date: Sun, 12 Jul 2026 17:42:07 +0300 Subject: [PATCH] fix(settings): get rid of controls menu --- RELEASE_NOTES.md | 1 + src/components/views/SettingsView.tsx | 43 ++++----------------------- 2 files changed, 7 insertions(+), 37 deletions(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 66d6b83..b3f0347 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -8,3 +8,4 @@ - Fix random disconnects on Windows - Show multiplayer status on Discord RPC - Fix skipping intro, fullscreen and legacy mode not importing in Settings (thanks Ryuzaki!) +- Remove controls menu from Settings diff --git a/src/components/views/SettingsView.tsx b/src/components/views/SettingsView.tsx index 76f320c..92de37c 100644 --- a/src/components/views/SettingsView.tsx +++ b/src/components/views/SettingsView.tsx @@ -23,7 +23,6 @@ const SettingsView = memo(function SettingsView() { sfxVol: sfxVolume, setSfxVol: setSfxVolume, layout, - setLayout, linuxRunner, setLinuxRunner, perfBoost, @@ -62,7 +61,7 @@ const SettingsView = memo(function SettingsView() { const { isLinux, isMac } = usePlatform(); const [focusIndex, setFocusIndex] = useState(null); const [currentSubMenu, setCurrentSubMenu] = useState< - "main" | "audio" | "video" | "controls" | "launcher" | "game" | "plugins" + "main" | "audio" | "video" | "launcher" | "game" | "plugins" >("main"); const [runners, setRunners] = useState([]); const [pluginsInfo, setPluginsInfo] = useState([]); @@ -74,9 +73,6 @@ const SettingsView = memo(function SettingsView() { const [showModal, setShowModal] = useState< "args" | "prefix" | "envVars" | null >(null); - - const layouts = ["KBM", "PLAYSTATION", "XBOX"]; - useEffect(() => { TauriService.getAvailableRunners().then(setRunners); }, [isRunnerDownloading]); @@ -91,13 +87,6 @@ const SettingsView = memo(function SettingsView() { return () => PluginManager.instance.setEnabledChangedCallback(null!); }, [refreshPlugins]); - const handleLayoutToggle = () => { - playPressSound(); - const currentIndex = layouts.indexOf(layout); - const nextIndex = (currentIndex + 1) % layouts.length; - setLayout(layouts[nextIndex]); - }; - const handleVfxToggle = () => { playPressSound(); setVfxEnabled(!vfxEnabled); @@ -302,16 +291,6 @@ const SettingsView = memo(function SettingsView() { setFocusIndex(0); }, }); - items.push({ - id: "controls_menu", - label: "Controls", - type: "button", - onClick: () => { - playPressSound(); - setCurrentSubMenu("controls"); - setFocusIndex(0); - }, - }); items.push({ id: "launcher_menu", label: "Launcher", @@ -395,13 +374,6 @@ const SettingsView = memo(function SettingsView() { onClick: handlePerfToggle, }); } - } else if (currentSubMenu === "controls") { - items.push({ - id: "layout", - label: `Layout: ${layout}`, - type: "button", - onClick: handleLayoutToggle, - }); } else if (currentSubMenu === "game") { const envVarsCount = launchEnvVars ? Object.keys(launchEnvVars).length @@ -586,7 +558,6 @@ const SettingsView = memo(function SettingsView() { handleRpcToggle, handleLegacyToggle, handleAnimationsToggle, - handleLayoutToggle, handleRunnerToggle, handlePerfToggle, handleMangohudToggle, @@ -713,13 +684,11 @@ const SettingsView = memo(function SettingsView() { ? "Audio" : currentSubMenu === "video" ? "Video" - : currentSubMenu === "controls" - ? "Controls" - : currentSubMenu === "game" - ? "Game" - : currentSubMenu === "plugins" - ? "Plugins" - : "Launcher"} + : currentSubMenu === "game" + ? "Game" + : currentSubMenu === "plugins" + ? "Plugins" + : "Launcher"} {currentSubMenu === "main" ? (